admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #342 from heroin-moose/fix-iscsi-cmdsn-tests

Browse Source 
test-tool: Fix CmdSN tests
This commit is contained in:
Bart Van Assche
2020-09-03 17:14:06 -07:00
committed by GitHub
parent 5553d6bddf 859070854d
commit 2a34e8fe1e
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test-tool/test_iscsi_cmdsn_toohigh.c
View File

@@ -35,10 +35,12 @@ static int my_iscsi_queue_pdu(struct iscsi_context *iscsi, struct iscsi_pdu *pdu
* iscsi_pdu_set_cmdsn(), which also changes pdu->cmdsn? * iscsi_pdu_set_cmdsn(), which also changes pdu->cmdsn?
*/ */
scsi_set_uint32(&pdu->outdata.data[24], iscsi->maxcmdsn + 1); scsi_set_uint32(&pdu->outdata.data[24], iscsi->maxcmdsn + 1);
/* fudge the cmdsn value back to where it should be if this /*
* pdu is ignored. * Fudge the cmdsn value back to where it should be if this pdu
* is ignored. The cmdsn value will be incremented by the
* orig_queue_pdu(), so it's off by one.
*/ */
iscsi->cmdsn = iscsi->expcmdsn; iscsi->cmdsn = iscsi->expcmdsn - 1;
break; break;
} }

8
test-tool/test_iscsi_cmdsn_toolow.c
View File

@@ -35,10 +35,12 @@ static int my_iscsi_queue_pdu(struct iscsi_context *iscsi, struct iscsi_pdu *pdu
* iscsi_pdu_set_cmdsn(), which also changes pdu->cmdsn? * iscsi_pdu_set_cmdsn(), which also changes pdu->cmdsn?
*/ */
scsi_set_uint32(&pdu->outdata.data[24], iscsi->expcmdsn - 1); scsi_set_uint32(&pdu->outdata.data[24], iscsi->expcmdsn - 1);
/* fudge the cmdsn value back to where it should be if this /*
* pdu is ignored. * Fudge the cmdsn value back to where it should be if this pdu
* is ignored. The cmdsn value will be incremented by the
* orig_queue_pdu(), so it's off by one.
*/ */
iscsi->cmdsn = iscsi->expcmdsn; iscsi->cmdsn = iscsi->expcmdsn - 1;
break; break;
} }