Enable -Wno-unused-parameter

Instead of adding __attribute__((unused)) to unused arguments, add the
-Wno-unused-parameter compiler flag.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
This commit is contained in:
Bart Van Assche
2021-05-23 11:40:53 -07:00
parent ea6b2282d4
commit 2a5a0b3291
33 changed files with 71 additions and 72 deletions

View File

@@ -1,4 +1,4 @@
AM_CPPFLAGS=-I. -I${srcdir}/../include "-D_U_=__attribute__((unused))"
AM_CPPFLAGS=-I. -I${srcdir}/../include
AM_CFLAGS=$(WARN_CFLAGS)
AM_LDFLAGS=-no-undefined
LIBS=../lib/libiscsi.la

View File

@@ -102,7 +102,7 @@ void write_cb(struct iscsi_context *iscsi, int status, void *command_data, void
free(wt);
}
void read_cb(struct iscsi_context *iscsi _U_, int status, void *command_data, void *private_data)
void read_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
struct client *client = (struct client *)private_data;
struct scsi_task *task = command_data;
@@ -276,7 +276,7 @@ void populate_param_header(unsigned char *buf, int list_id, int str, int list_id
buf[15] = inline_data_len & 0xFF;
}
void xcopy_cb(struct iscsi_context *iscsi _U_, int status, void *command_data, void *private_data)
void xcopy_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
struct client *client = (struct client *)private_data;
struct scsi_task *task = command_data;

View File

@@ -63,7 +63,7 @@ struct client_state {
unsigned char small_buffer[512];
void tm_at_cb(struct iscsi_context *iscsi _U_, int status _U_, void *command_data _U_, void *private_data)
void tm_at_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
struct client_state *clnt = (struct client_state *)private_data;
@@ -74,7 +74,7 @@ void tm_at_cb(struct iscsi_context *iscsi _U_, int status _U_, void *command_dat
}
void synccache10_cb(struct iscsi_context *iscsi _U_, int status, void *command_data _U_, void *private_data _U_)
void synccache10_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
printf("SYNCCACHE10 status:%d\n", status);
}
@@ -103,7 +103,7 @@ void nop_out_cb(struct iscsi_context *iscsi, int status, void *command_data, voi
}
void write10_1_cb(struct iscsi_context *iscsi _U_, int status, void *command_data, void *private_data _U_)
void write10_1_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
struct scsi_task *task = command_data;
@@ -123,7 +123,7 @@ void write10_1_cb(struct iscsi_context *iscsi _U_, int status, void *command_dat
exit(10);
}
void write10_cb(struct iscsi_context *iscsi _U_, int status, void *command_data, void *private_data _U_)
void write10_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
struct client_state *clnt = (struct client_state *)private_data;
struct scsi_task *task = command_data;
@@ -482,7 +482,7 @@ void reportluns_cb(struct iscsi_context *iscsi, int status, void *command_data,
}
void normallogin_cb(struct iscsi_context *iscsi, int status, void *command_data _U_, void *private_data)
void normallogin_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
if (status != 0) {
printf("Failed to log in to target : %s\n", iscsi_get_error(iscsi));
@@ -497,7 +497,7 @@ void normallogin_cb(struct iscsi_context *iscsi, int status, void *command_data
}
void normalconnect_cb(struct iscsi_context *iscsi, int status, void *command_data _U_, void *private_data)
void normalconnect_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
printf("Connected to iscsi socket\n");
@@ -517,7 +517,7 @@ void normalconnect_cb(struct iscsi_context *iscsi, int status, void *command_dat
void discoverylogout_cb(struct iscsi_context *iscsi, int status, void *command_data _U_, void *private_data)
void discoverylogout_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
struct client_state *clnt = (struct client_state *)private_data;
@@ -586,7 +586,7 @@ void discovery_cb(struct iscsi_context *iscsi, int status, void *command_data, v
}
void discoverylogin_cb(struct iscsi_context *iscsi, int status, void *command_data _U_, void *private_data)
void discoverylogin_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
if (status != 0) {
printf("Failed to log in to target. : %s\n", iscsi_get_error(iscsi));
@@ -601,7 +601,7 @@ void discoverylogin_cb(struct iscsi_context *iscsi, int status, void *command_da
}
void discoveryconnect_cb(struct iscsi_context *iscsi, int status, void *command_data _U_, void *private_data)
void discoveryconnect_cb(struct iscsi_context *iscsi, int status, void *command_data, void *private_data)
{
printf("Connected to iscsi socket status:0x%08x\n", status);
@@ -619,7 +619,7 @@ void discoveryconnect_cb(struct iscsi_context *iscsi, int status, void *command_
}
int main(int argc _U_, char *argv[] _U_)
int main(int argc, char *argv[])
{
struct iscsi_context *iscsi;
struct pollfd pfd;