admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Enable -Wno-unused-parameter

Browse Source 
Instead of adding __attribute__((unused)) to unused arguments, add the
-Wno-unused-parameter compiler flag.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
This commit is contained in:
Bart Van Assche
2021-05-23 11:40:53 -07:00
parent ea6b2282d4
commit 2a5a0b3291
33 changed files with 71 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Makefile.am
View File

@@ -22,8 +22,7 @@ endif
libiscsipriv_la_LDFLAGS = -no-undefined
libiscsipriv_la_CPPFLAGS = -I${srcdir}/../include -I$(srcdir)/include \
"-D_U_=__attribute__((unused))"
libiscsipriv_la_CPPFLAGS = -I${srcdir}/../include -I$(srcdir)/include
AM_CFLAGS=$(WARN_CFLAGS)

10
lib/connect.c
View File

@@ -46,7 +46,7 @@ struct connect_task {
};
static void
iscsi_connect_cb(struct iscsi_context *iscsi, int status, void *command_data _U_,
iscsi_connect_cb(struct iscsi_context *iscsi, int status, void *command_data,
void *private_data);
@@ -144,7 +144,7 @@ iscsi_testunitready_cb(struct iscsi_context *iscsi, int status,
}
static void
iscsi_login_cb(struct iscsi_context *iscsi, int status, void *command_data _U_,
iscsi_login_cb(struct iscsi_context *iscsi, int status, void *command_data,
void *private_data)
{
struct connect_task *ct = private_data;
@@ -184,7 +184,7 @@ iscsi_login_cb(struct iscsi_context *iscsi, int status, void *command_data _U_,
}
static void
iscsi_connect_cb(struct iscsi_context *iscsi, int status, void *command_data _U_,
iscsi_connect_cb(struct iscsi_context *iscsi, int status, void *command_data,
void *private_data)
{
struct connect_task *ct = private_data;
@@ -276,8 +276,8 @@ void iscsi_defer_reconnect(struct iscsi_context *iscsi)
iscsi_cancel_pdus(iscsi);
}
void iscsi_reconnect_cb(struct iscsi_context *iscsi _U_, int status,
void *command_data _U_, void *private_data _U_)
void iscsi_reconnect_cb(struct iscsi_context *iscsi, int status,
void *command_data, void *private_data)
{
struct iscsi_context *old_iscsi;
int i;

4
lib/iscsi-command.c
View File

@@ -40,7 +40,7 @@
static void
iscsi_scsi_response_cb(struct iscsi_context *iscsi, int status,
void *command_data _U_, void *private_data)
void *command_data, void *private_data)
{
struct iscsi_scsi_cbdata *scsi_cbdata =
(struct iscsi_scsi_cbdata *)private_data;
@@ -2433,7 +2433,7 @@ iscsi_get_scsi_task_iovector_in(struct iscsi_context *iscsi, struct iscsi_in_pdu
}
struct scsi_iovector *
iscsi_get_scsi_task_iovector_out(struct iscsi_context *iscsi _U_, struct iscsi_pdu *pdu)
iscsi_get_scsi_task_iovector_out(struct iscsi_context *iscsi, struct iscsi_pdu *pdu)
{
if (pdu->scsi_cbdata.task->iovector_out.iov == NULL) {
return NULL;

6
lib/iser.c
View File

@@ -83,7 +83,7 @@ iscsi_iser_get_fd(struct iscsi_context *iscsi)
* Being used in QEMU iscsi block so we need compatability with TCP
*/
static int
iscsi_iser_which_events(struct iscsi_context *iscsi _U_)
iscsi_iser_which_events(struct iscsi_context *iscsi)
{
/* iSER is waiting to events from CQ that are always POLLIN */
return 1;
@@ -1401,8 +1401,8 @@ no_waitpdu:
*
*/
static int
iser_snd_completion(struct iser_tx_desc *tx_desc _U_,
struct iser_conn *iser_conn _U_)
iser_snd_completion(struct iser_tx_desc *tx_desc,
struct iser_conn *iser_conn)
{
return 0;
}

2
lib/login.c
View File

@@ -1435,7 +1435,7 @@ iscsi_logout_async(struct iscsi_context *iscsi, iscsi_command_cb cb,
int
iscsi_process_logout_reply(struct iscsi_context *iscsi, struct iscsi_pdu *pdu,
struct iscsi_in_pdu *in _U_)
struct iscsi_in_pdu *in)
{
iscsi->is_loggedin = 0;
ISCSI_LOG(iscsi, 2, "logout successful");

2
lib/pdu.c
View File

@@ -330,7 +330,7 @@ int iscsi_process_target_nop_in(struct iscsi_context *iscsi,
}
static void iscsi_reconnect_after_logout(struct iscsi_context *iscsi, int status,
void *command_data _U_, void *opaque _U_)
void *command_data, void *opaque)
{
if (status) {
ISCSI_LOG(iscsi, 1, "logout failed: %s", iscsi_get_error(iscsi));

2
lib/scsi-lowlevel.c
View File

@@ -1246,7 +1246,7 @@ scsi_cdb_report_supported_opcodes(int rctd, int options, enum scsi_opcode opcode
* readcapacity10 datain structure
*/
static int
scsi_readcapacity10_datain_getfullsize(struct scsi_task *task _U_)
scsi_readcapacity10_datain_getfullsize(struct scsi_task *task)
{
return 8;
}

4
lib/socket.c
View File

@@ -1069,7 +1069,7 @@ void iscsi_set_tcp_keepintvl(struct iscsi_context *iscsi, int value)
ISCSI_LOG(iscsi, 2, "TCP_KEEPINTVL will be set to %d on next socket creation",value);
}
int iscsi_set_tcp_keepalive(struct iscsi_context *iscsi, int idle _U_, int count _U_, int interval _U_)
int iscsi_set_tcp_keepalive(struct iscsi_context *iscsi, int idle, int count, int interval)
{
#ifdef SO_KEEPALIVE
int value = 1;
@@ -1104,7 +1104,7 @@ int iscsi_set_tcp_keepalive(struct iscsi_context *iscsi, int idle _U_, int count
return 0;
}
void iscsi_set_bind_interfaces(struct iscsi_context *iscsi, char * interfaces _U_)
void iscsi_set_bind_interfaces(struct iscsi_context *iscsi, char * interfaces)
{
#if __linux
strncpy(iscsi->bind_interfaces,interfaces,MAX_STRING_SIZE);

10
lib/sync.c
View File

@@ -82,8 +82,8 @@ event_loop(struct iscsi_context *iscsi, struct iscsi_sync_state *state)
* Synchronous iSCSI commands
*/
static void
iscsi_sync_cb(struct iscsi_context *iscsi _U_, int status,
void *command_data _U_, void *private_data)
iscsi_sync_cb(struct iscsi_context *iscsi, int status,
void *command_data, void *private_data)
{
struct iscsi_sync_state *state = private_data;
@@ -340,7 +340,7 @@ iscsi_task_mgmt_target_cold_reset_sync(struct iscsi_context *iscsi)
* Synchronous SCSI commands
*/
static void
scsi_sync_cb(struct iscsi_context *iscsi _U_, int status, void *command_data,
scsi_sync_cb(struct iscsi_context *iscsi, int status, void *command_data,
void *private_data)
{
struct scsi_task *task = command_data;
@@ -1820,7 +1820,7 @@ iscsi_modesense10_sync(struct iscsi_context *iscsi, int lun, int llbaa, int dbd,
return state.task;
}
void iscsi_free_discovery_data(struct iscsi_context *iscsi _U_,
void iscsi_free_discovery_data(struct iscsi_context *iscsi,
struct iscsi_discovery_address *da)
{
while (da) {
@@ -1840,7 +1840,7 @@ void iscsi_free_discovery_data(struct iscsi_context *iscsi _U_,
}
static void
iscsi_discovery_cb(struct iscsi_context *iscsi _U_, int status,
iscsi_discovery_cb(struct iscsi_context *iscsi, int status,
void *command_data, void *private_data)
{
struct iscsi_sync_state *state = private_data;