TESTS: Create helpers for PREFETCH16 and switch all tests over to them

This commit is contained in:
Ronnie Sahlberg
2012-12-25 08:57:05 -08:00
parent 047b650151
commit 2afb5accc4
8 changed files with 165 additions and 346 deletions

View File

@@ -32,9 +32,8 @@ int T0250_prefetch16_simple(const char *initiator, const char *url, int data_los
printf("===================\n");
if (show_info) {
printf("Test basic PREFETCH16 functionality.\n");
printf("1, Verify we can prefetch the first 1-256 blocks of the LUN.\n");
printf("2, Verify we can prefetch the last 1-256 blocks of the LUN.\n");
printf("3, Verify we can prefetch the last 256 blocks of the LUN by setting LEN==0.\n");
printf("1, Verify we can prefetch the first 0-256 blocks of the LUN.\n");
printf("2, Verify we can prefetch the last 0-256 blocks of the LUN.\n");
printf("\n");
return 0;
}
@@ -70,80 +69,25 @@ int T0250_prefetch16_simple(const char *initiator, const char *url, int data_los
ret = 0;
/* prefetch the first 1 - 256 blocks at the start of the LUN */
printf("Prefetching first 1-256 blocks ... ");
for (i = 1; i <= 256; i++) {
task = iscsi_prefetch16_sync(iscsi, lun, 0, i, 0, 0);
if (task == NULL) {
printf("[FAILED]\n");
printf("Failed to send prefetch16 command: %s\n", iscsi_get_error(iscsi));
ret = -1;
goto test2;
}
if (task->status == SCSI_STATUS_CHECK_CONDITION
&& task->sense.key == SCSI_SENSE_ILLEGAL_REQUEST
&& task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_OPERATION_CODE) {
printf("[SKIPPED]\n");
printf("Opcode is not implemented on target\n");
scsi_free_scsi_task(task);
ret = -2;
/* prefetch the first 0 - 256 blocks at the start of the LUN */
printf("Prefetching first 0-256 blocks.\n");
for (i = 0; i <= 256; i++) {
ret = prefetch16(iscsi, lun, 0, i, 0, 0);
if (ret != 0) {
goto finished;
}
if (task->status != SCSI_STATUS_GOOD) {
printf("[FAILED]\n");
printf("Prefetch16 command: failed with sense. %s\n", iscsi_get_error(iscsi));
ret = -1;
scsi_free_scsi_task(task);
goto test2;
}
scsi_free_scsi_task(task);
}
printf("[OK]\n");
test2:
/* Prefetch the last 0 - 255 blocks at the end of the LUN */
printf("Prefetching last 0-255 blocks ... ");
printf("Prefetching last 0-255 blocks.\n");
for (i = 1; i < 256; i++) {
task = iscsi_prefetch16_sync(iscsi, lun, num_blocks - i, i, 0, 0);
if (task == NULL) {
printf("[FAILED]\n");
printf("Failed to send prefetch16 command: %s\n", iscsi_get_error(iscsi));
ret = -1;
goto test3;
ret = prefetch16(iscsi, lun, num_blocks - i, i, 0, 0);
if (ret != 0) {
goto finished;
}
if (task->status != SCSI_STATUS_GOOD) {
printf("[FAILED]\n");
printf("Prefetch16 command: failed with sense. %s\n", iscsi_get_error(iscsi));
ret = -1;
scsi_free_scsi_task(task);
goto test3;
}
scsi_free_scsi_task(task);
}
printf("[OK]\n");
test3:
printf("Prefetching last 0-255 blocks ... ");
task = iscsi_prefetch16_sync(iscsi, lun, num_blocks - 256, 0, 0, 0);
if (task == NULL) {
printf("[FAILED]\n");
printf("Failed to send prefetch16 command: %s\n", iscsi_get_error(iscsi));
ret = -1;
goto test4;
}
if (task->status != SCSI_STATUS_GOOD) {
printf("[FAILED]\n");
printf("Prefetch16 command: failed with sense. %s\n", iscsi_get_error(iscsi));
ret = -1;
scsi_free_scsi_task(task);
goto test4;
}
scsi_free_scsi_task(task);
printf("[OK]\n");
test4:
finished:
iscsi_logout_sync(iscsi);