From 30355f8cc0e3dfb6e33ef6e1efc9df3a5c1679d1 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Tue, 14 Oct 2014 11:48:34 +0200 Subject: [PATCH] test_inquiry_block_limits: Only query VPD page B2h if LBPME = 1 In the READ CAPACITY response support for logical block provisioning is indicated via the LBPME (logical block provisioning management enabled) bit. Since the logical block provisioning VPD page (B2h) is optional, only query it if LBPME = 1. Signed-off-by: Bart Van Assche --- test-tool/test_inquiry_block_limits.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/test-tool/test_inquiry_block_limits.c b/test-tool/test_inquiry_block_limits.c index e917f65..3976088 100644 --- a/test-tool/test_inquiry_block_limits.c +++ b/test-tool/test_inquiry_block_limits.c @@ -24,10 +24,19 @@ #include "iscsi-support.h" #include "iscsi-test-cu.h" +static void check_lbp(int *supports_lbp) +{ + *supports_lbp = 0; + + CHECK_FOR_THIN_PROVISIONING; + + *supports_lbp = 1; +} + void test_inquiry_block_limits(void) { - int ret; + int supports_lbp, ret; struct scsi_inquiry_block_limits *bl; struct scsi_task *bl_task = NULL; struct scsi_inquiry_logical_block_provisioning *lbp = NULL; @@ -103,6 +112,9 @@ test_inquiry_block_limits(void) goto finished; } + check_lbp(&supports_lbp); + if (!supports_lbp) + goto finished; /* * MAXIMUM UNMAP LBA COUNT