admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TEST: Improve the test for cmdsn too high with more documentation

Browse Source 
and verify that the target did ignore the command and the session is still good.
This commit is contained in:
Ronnie Sahlberg
2013-04-30 18:46:26 -07:00
parent 1a275bbecc
commit 325360789e
1 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
test-tool/test_iscsi_cmdsn_toohigh.c
View File

@@ -28,11 +28,17 @@ static int change_cmdsn;
static int my_iscsi_queue_pdu(struct iscsi_context *iscsi, struct iscsi_pdu *pdu) static int my_iscsi_queue_pdu(struct iscsi_context *iscsi, struct iscsi_pdu *pdu)
{ {
static uint32_t old_cmdsn;
switch (change_cmdsn) { switch (change_cmdsn) {
case 1: case 1:
old_cmdsn = *(uint32_t *)&pdu->outdata.data[24];
/* change the cmdsn so it becomes too big */ /* change the cmdsn so it becomes too big */
*(uint32_t *)&pdu->outdata.data[24] = htonl(iscsi->maxcmdsn + 1); *(uint32_t *)&pdu->outdata.data[24] = htonl(iscsi->maxcmdsn + 1);
break; break;
case 2:
*(uint32_t *)&pdu->outdata.data[24] = old_cmdsn;
break;
} }
change_cmdsn = 0; change_cmdsn = 0;
@@ -47,8 +53,8 @@ void test_iscsi_cmdsn_toohigh(void)
logging(LOG_VERBOSE, "Test sending invalid iSCSI CMDSN"); logging(LOG_VERBOSE, "Test sending invalid iSCSI CMDSN");
logging(LOG_VERBOSE, "CMDSN MUST be in the range EXPCMDSN and MAXCMDSN"); logging(LOG_VERBOSE, "CMDSN MUST be in the range EXPCMDSN and MAXCMDSN");
logging(LOG_VERBOSE, "Test that a CMDSN > MAXCMDSN is an error"); logging(LOG_VERBOSE, "RFC3720:3.2.2.1 CMDSN > MAXCMDSN must be silently ignored by the target");
logging(LOG_VERBOSE, "Send a TESTUNITREADY with CMDSN == MAXCMDSN+1"); logging(LOG_VERBOSE, "Send a TESTUNITREADY with CMDSN == MAXCMDSN+1. Should be ignored by the target.");
iscsic->use_immediate_data = ISCSI_IMMEDIATE_DATA_NO; iscsic->use_immediate_data = ISCSI_IMMEDIATE_DATA_NO;
iscsic->target_max_recv_data_segment_length = block_size; iscsic->target_max_recv_data_segment_length = block_size;
@@ -62,4 +68,18 @@ void test_iscsi_cmdsn_toohigh(void)
ret = testunitready(iscsic, tgt_lun); ret = testunitready(iscsic, tgt_lun);
CU_ASSERT_EQUAL(ret, -1); CU_ASSERT_EQUAL(ret, -1);
if (ret == -1) {
logging(LOG_VERBOSE, "[SUCCESS] We did not receive a reply");
} else {
logging(LOG_VERBOSE, "[FAILURE] We got a response from the target but SMDSN was outside of the window.");
}
iscsi_set_noautoreconnect(iscsic, 0);
logging(LOG_VERBOSE, "Send a TESTUNITREADY with CMDSN == EXPCMDSN. should work again");
change_cmdsn = 2;
ret = testunitready(iscsic, tgt_lun);
CU_ASSERT_EQUAL(ret, 0);
} }