admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

lib: drop generic sense data descriptor VALID check

Browse Source 
According to SPC-5 (r17), the sense data descriptor format follows:
byte	field
----	-----
0:	DESCRIPTOR TYPE
1:	ADDITIONAL LENGTH
2-n:	Sense data descriptor specific

The VALID bit is a sense data descriptor specific flag, and is not
present in the only sense data descriptor supported by libiscsi -
Sense key specific sense data descriptors.
Drop the generic VALID bit check, in preparation for handling it on
a sense data descriptor specific basis.

Suggested-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: David Disseldorp <ddiss@suse.de>
This commit is contained in:
David Disseldorp
2020-10-19 14:23:12 +02:00
parent 971bac8cfb
commit 34a632a04e
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/iscsi-command.c
View File

@@ -328,8 +328,6 @@ static void parse_sense_descriptors(struct scsi_sense *sense, const uint8_t *sb,
for (p = sb; p < end; p += p[1]) { for (p = sb; p < end; p += p[1]) {
if (p[1] < 4) /* length */ if (p[1] < 4) /* length */
break; break;
if (!(p[2] & 0x80)) /* VALID bit */
break;
switch (p[0]) { switch (p[0]) {
case 2: case 2:
/* Sense key specific sense data descriptor */ /* Sense key specific sense data descriptor */