admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TESTS: Add missing check for not supported : RECEIVE_COPY_RESULTS

Browse Source 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
This commit is contained in:
Ronnie Sahlberg
2015-08-02 12:37:07 -07:00
parent 0bb846c0f5
commit 3b8b42d976
3 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test-tool/test_extendedcopy_descr_limits.c
View File

@@ -66,6 +66,11 @@ test_extendedcopy_descr_limits(void)
logging(LOG_VERBOSE, "Issue RECEIVE COPY RESULTS (OPERATING PARAMS)"); logging(LOG_VERBOSE, "Issue RECEIVE COPY RESULTS (OPERATING PARAMS)");
ret = receive_copy_results(sd, SCSI_COPY_RESULTS_OP_PARAMS, 0, ret = receive_copy_results(sd, SCSI_COPY_RESULTS_OP_PARAMS, 0,
(void **)&opp, EXPECT_STATUS_GOOD); (void **)&opp, EXPECT_STATUS_GOOD);
if (ret == -2) {
CU_PASS("[SKIPPED] Target does not support "
"RECEIVE_COPY_RESULTS. Skipping test");
return;
}
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
/* Allocate buffer to accommodate (MAX+1) target and /* Allocate buffer to accommodate (MAX+1) target and

7
test-tool/test_receive_copy_results_copy_status.c
View File

@@ -42,6 +42,11 @@ test_receive_copy_results_copy_status(void)
logging(LOG_VERBOSE, "No copy in progress"); logging(LOG_VERBOSE, "No copy in progress");
ret = receive_copy_results(sd, SCSI_COPY_RESULTS_COPY_STATUS, ret = receive_copy_results(sd, SCSI_COPY_RESULTS_COPY_STATUS,
list_id, NULL, EXPECT_INVALID_FIELD_IN_CDB); list_id, NULL, EXPECT_INVALID_FIELD_IN_CDB);
if (ret == -2) {
CU_PASS("[SKIPPED] Target does not support "
"RECEIVE_COPY_STATUS. Skipping test");
return;
}
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
CHECK_FOR_DATALOSS; CHECK_FOR_DATALOSS;
@@ -58,7 +63,7 @@ test_receive_copy_results_copy_status(void)
LU_ID_TYPE_LUN, 0, 0, 0, 0, sd); LU_ID_TYPE_LUN, 0, 0, 0, 0, sd);
tgt_desc_len = offset - XCOPY_DESC_OFFSET; tgt_desc_len = offset - XCOPY_DESC_OFFSET;
/* Iniitialize segment descriptor list with one segment descriptor */ /* Initialize segment descriptor list with one segment descriptor */
offset += populate_seg_desc_b2b(xcopybuf+offset, 0, 0, 0, 0, offset += populate_seg_desc_b2b(xcopybuf+offset, 0, 0, 0, 0,
2048, 0, num_blocks - 2048); 2048, 0, num_blocks - 2048);
seg_desc_len = offset - XCOPY_DESC_OFFSET - tgt_desc_len; seg_desc_len = offset - XCOPY_DESC_OFFSET - tgt_desc_len;

4
test-tool/test_receive_copy_results_op_params.c
View File

@@ -37,6 +37,10 @@ test_receive_copy_results_op_params(void)
ret = receive_copy_results(sd, SCSI_COPY_RESULTS_OP_PARAMS, 0, ret = receive_copy_results(sd, SCSI_COPY_RESULTS_OP_PARAMS, 0,
(void **)&opp, EXPECT_STATUS_GOOD); (void **)&opp, EXPECT_STATUS_GOOD);
if (ret == -2) {
CU_PASS("[SKIPPED] RECEIVE_COPY_RESULT is not implemented.");
return;
}
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
logging(LOG_NORMAL, logging(LOG_NORMAL,