iscsi_queue_pdu() can never fail, make it void

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
2025-04-20 13:27:47 +10:00
parent 37bc6fcd81
commit 3fc5d2996b
20 changed files with 49 additions and 102 deletions
--- a/lib/socket.c
+++ b/lib/socket.c
@@ -1136,17 +1136,10 @@ iscsi_service(struct iscsi_context *iscsi, int revents)
 	return iscsi->drv->service(iscsi, revents);
 }

-static int iscsi_tcp_queue_pdu(struct iscsi_context *iscsi,
+static void iscsi_tcp_queue_pdu(struct iscsi_context *iscsi,
                               struct iscsi_pdu *pdu)
 {
-	if (pdu == NULL) {
-		iscsi_set_error(iscsi, "trying to queue NULL pdu");
-		return -1;
-	}
-
 	iscsi_add_to_outqueue(iscsi, pdu);
-
-	return 0;
 }

 void