admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TESTS: fix test for modesense6 residuals. We never get overflow

Browse Source 
but we get underflow if less than EDTL was returned
This commit is contained in:
Ronnie Sahlberg
2013-06-01 07:57:31 -07:00
parent a16dd132db
commit 595b7043b7
1 changed files with 27 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
test-tool/test_modesense6_residuals.c
View File

@@ -75,7 +75,7 @@ test_modesense6_residuals(void)
logging(LOG_VERBOSE, "Try a MODESENSE6 command with 255 bytes of " logging(LOG_VERBOSE, "Try a MODESENSE6 command with 255 bytes of "
"transfer length and verify that we dont get residuals."); "transfer length and verify that we get residuals if the target returns less than the requested amount of data.");
if (task != NULL) { if (task != NULL) {
scsi_free_scsi_task(task); scsi_free_scsi_task(task);
task = NULL; task = NULL;
@@ -94,13 +94,33 @@ test_modesense6_residuals(void)
logging(LOG_VERBOSE, "[SUCCESS] All Pages fetched."); logging(LOG_VERBOSE, "[SUCCESS] All Pages fetched.");
logging(LOG_VERBOSE, "Verify residual underflow flag not set"); if (task->datain.size == 255) {
if (task->residual_status == SCSI_RESIDUAL_UNDERFLOW) { logging(LOG_VERBOSE, "We got all 255 bytes of data back "
logging(LOG_VERBOSE, "[FAILED] Target set residual " "from the target. Verify that underflow is not set.");
"underflow flag");
}
CU_ASSERT_NOT_EQUAL(task->residual_status, SCSI_RESIDUAL_UNDERFLOW);
if (task->residual_status == SCSI_RESIDUAL_UNDERFLOW) {
logging(LOG_VERBOSE, "[FAILED] Target set residual "
"underflow flag");
} else {
logging(LOG_VERBOSE, "[SUCCESS] Residual underflow "
"is not set");
}
CU_ASSERT_NOT_EQUAL(task->residual_status,
SCSI_RESIDUAL_UNDERFLOW);
} else {
logging(LOG_VERBOSE, "We got less than the requested 255 bytes "
"from the target. Verify that underflow is set.");
if (task->residual_status != SCSI_RESIDUAL_UNDERFLOW) {
logging(LOG_VERBOSE, "[FAILED] Target did not set "
"residual underflow flag");
} else {
logging(LOG_VERBOSE, "[SUCCESS] Residual underflow "
"is set");
}
CU_ASSERT_EQUAL(task->residual_status,
SCSI_RESIDUAL_UNDERFLOW);
}
if (task != NULL) { if (task != NULL) {