admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TESTS: Start fixing up the tests so we can test-suite them properly

Browse Source 
Dont call READCAPACITY from every single test.
Remove two arguments from the test signatures and turn them into globals.
remove the ret++ silliness.  Tests return 0 : all ok, -2, skipped or -1 : test failed
This commit is contained in:
Ronnie Sahlberg
2012-12-26 18:34:12 -08:00
parent 3c960c1d42
commit 5ad957b873
126 changed files with 1096 additions and 3554 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test-tool/0161_readcapacity16_alloclen.c
View File

@@ -23,7 +23,7 @@
#include "scsi-lowlevel.h"
#include "iscsi-test.h"
int T0161_readcapacity16_alloclen(const char *initiator, const char *url, int data_loss _U_, int show_info)
int T0161_readcapacity16_alloclen(const char *initiator, const char *url)
{
struct iscsi_context *iscsi;
struct scsi_task *task;
@@ -33,7 +33,7 @@ int T0161_readcapacity16_alloclen(const char *initiator, const char *url, int da
printf("=======================\n");
if (show_info) {
printf("Test allocation-length for READCAPACITY16\n");
printf("1, Readcapacity with alloclen==0 is not an error\n");
printf("1, READCAPACITY16 with alloclen==0 is not an error\n");
printf("\n");
return 0;
}
@@ -48,7 +48,6 @@ int T0161_readcapacity16_alloclen(const char *initiator, const char *url, int da
printf("READCAPACITY16 with AllocationLength==0 ... ");
task = malloc(sizeof(struct scsi_task));
if (task == NULL) {
printf("Failed to allocate task structure\n");
@@ -68,21 +67,19 @@ int T0161_readcapacity16_alloclen(const char *initiator, const char *url, int da
printf("Failed to send READCAPACITY16 command: %s\n", iscsi_get_error(iscsi));
ret = -1;
goto test2;
goto finished;
}
if (task->status != SCSI_STATUS_GOOD) {
printf("[FAILED]\n");
printf("READCAPACITY16 with AllocationLength==0 should not fail. Sense:%s\n", iscsi_get_error(iscsi));
ret = -1;
scsi_free_scsi_task(task);
goto test2;
goto finished;
}
scsi_free_scsi_task(task);
printf("[OK]\n");
test2:
finished:
iscsi_logout_sync(iscsi);
iscsi_destroy_context(iscsi);