From 5ccf2f4d87611ab7f969d42b5e34a7b78a0bb479 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Mon, 4 Jun 2012 20:45:59 +1000 Subject: [PATCH] Add tests for verify10/16 for lba out of range Signed-off-by: Ronnie Sahlberg --- Makefile.am | 4 +- test-tool/0133_verify10_beyondeol.c | 110 ++++++++++++++++++++++++++++ test-tool/0283_verify12_beyondeol.c | 110 ++++++++++++++++++++++++++++ test-tool/iscsi-test.c | 2 + test-tool/iscsi-test.h | 2 + 5 files changed, 226 insertions(+), 2 deletions(-) create mode 100644 test-tool/0133_verify10_beyondeol.c create mode 100644 test-tool/0283_verify12_beyondeol.c diff --git a/Makefile.am b/Makefile.am index 6e4d82d..b6d4d7c 100644 --- a/Makefile.am +++ b/Makefile.am @@ -61,7 +61,7 @@ bin_iscsi_test_SOURCES = test-tool/iscsi-test.c \ test-tool/0120_read6_simple.c \ test-tool/0121_read6_beyond_eol.c test-tool/0122_read6_invalid.c \ test-tool/0130_verify10_simple.c test-tool/0131_verify10_mismatch.c \ - test-tool/0132_verify10_mismatch_no_cmp.c \ + test-tool/0132_verify10_mismatch_no_cmp.c test-tool/0133_verify10_beyondeol.c \ test-tool/0160_readcapacity16_simple.c \ test-tool/0170_unmap_simple.c test-tool/0171_unmap_zero.c \ test-tool/0180_writesame10_unmap.c test-tool/0181_writesame10_unmap_unaligned.c \ @@ -84,7 +84,7 @@ bin_iscsi_test_SOURCES = test-tool/iscsi-test.c \ test-tool/0270_verify16_simple.c test-tool/0271_verify16_mismatch.c \ test-tool/0272_verify16_mismatch_no_cmp.c test-tool/0273_verify16_beyondeol.c \ test-tool/0280_verify12_simple.c test-tool/0281_verify12_mismatch.c \ - test-tool/0282_verify12_mismatch_no_cmp.c + test-tool/0282_verify12_mismatch_no_cmp.c test-tool/0283_verify12_beyondeol.c endif # LD_PRELOAD library. diff --git a/test-tool/0133_verify10_beyondeol.c b/test-tool/0133_verify10_beyondeol.c new file mode 100644 index 0000000..387f5ef --- /dev/null +++ b/test-tool/0133_verify10_beyondeol.c @@ -0,0 +1,110 @@ +/* + Copyright (C) 2012 by Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test.h" + +int T0133_verify10_beyondeol(const char *initiator, const char *url, int data_loss _U_, int show_info) +{ + struct iscsi_context *iscsi; + struct scsi_task *task; + struct scsi_readcapacity16 *rc16; + int ret, i, lun; + uint32_t block_size; + uint64_t num_blocks; + unsigned char buf[512*256]; + + printf("0133_verify10_beyond_eol:\n"); + printf("========================\n"); + if (show_info) { + printf("Test that VERIFY10 fails if reading beyond end-of-lun.\n"); + printf("1, Verify 2-256 blocks one block beyond end-of-lun.\n"); + printf("\n"); + return 0; + } + + iscsi = iscsi_context_login(initiator, url, &lun); + if (iscsi == NULL) { + printf("Failed to login to target\n"); + return -1; + } + + /* find the size of the LUN */ + task = iscsi_readcapacity16_sync(iscsi, lun); + if (task == NULL) { + printf("Failed to send READCAPACITY16 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status != SCSI_STATUS_GOOD) { + printf("READCAPACITY16 command: failed with sense. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + rc16 = scsi_datain_unmarshall(task); + if (rc16 == NULL) { + printf("failed to unmarshall READCAPACITY16 data. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + block_size = rc16->block_length; + num_blocks = rc16->returned_lba; + scsi_free_scsi_task(task); + + + + ret = 0; + + /* verify 2 - 256 blocks beyond the end of the device */ + printf("Verifying 2-256 blocks beyond end-of-device ... "); + for (i = 2; i <= 256; i++) { + task = iscsi_verify10_sync(iscsi, lun, buf, i * block_size, num_blocks, 0, 1, 1, block_size); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send verify10 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status == SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("Verify10 command should fail when reading beyond end of device\n"); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + if (task->status != SCSI_STATUS_CHECK_CONDITION + || task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST + || task->sense.ascq != SCSI_SENSE_ASCQ_LBA_OUT_OF_RANGE) { + printf("[FAILED]\n"); + printf("VERIFY10 failed but with the wrong sense code. It should have failed with ILLEGAL_REQUEST/LBA_OUT_OF_RANGE.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + scsi_free_scsi_task(task); + } + printf("[OK]\n"); + +finished: + iscsi_logout_sync(iscsi); + iscsi_destroy_context(iscsi); + return ret; +} diff --git a/test-tool/0283_verify12_beyondeol.c b/test-tool/0283_verify12_beyondeol.c new file mode 100644 index 0000000..c402760 --- /dev/null +++ b/test-tool/0283_verify12_beyondeol.c @@ -0,0 +1,110 @@ +/* + Copyright (C) 2012 by Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test.h" + +int T0283_verify12_beyondeol(const char *initiator, const char *url, int data_loss _U_, int show_info) +{ + struct iscsi_context *iscsi; + struct scsi_task *task; + struct scsi_readcapacity16 *rc16; + int ret, i, lun; + uint32_t block_size; + uint64_t num_blocks; + unsigned char buf[512*256]; + + printf("0283_verify12_beyond_eol:\n"); + printf("========================\n"); + if (show_info) { + printf("Test that VERIFY12 fails if reading beyond end-of-lun.\n"); + printf("1, Verify 2-256 blocks one block beyond end-of-lun.\n"); + printf("\n"); + return 0; + } + + iscsi = iscsi_context_login(initiator, url, &lun); + if (iscsi == NULL) { + printf("Failed to login to target\n"); + return -1; + } + + /* find the size of the LUN */ + task = iscsi_readcapacity16_sync(iscsi, lun); + if (task == NULL) { + printf("Failed to send READCAPACITY16 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status != SCSI_STATUS_GOOD) { + printf("READCAPACITY16 command: failed with sense. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + rc16 = scsi_datain_unmarshall(task); + if (rc16 == NULL) { + printf("failed to unmarshall READCAPACITY16 data. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + block_size = rc16->block_length; + num_blocks = rc16->returned_lba; + scsi_free_scsi_task(task); + + + + ret = 0; + + /* verify 2 - 256 blocks beyond the end of the device */ + printf("Verifying 2-256 blocks beyond end-of-device ... "); + for (i = 2; i <= 256; i++) { + task = iscsi_verify12_sync(iscsi, lun, buf, i * block_size, num_blocks, 0, 1, 1, block_size); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send verify12 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status == SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("Verify12 command should fail when reading beyond end of device\n"); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + if (task->status != SCSI_STATUS_CHECK_CONDITION + || task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST + || task->sense.ascq != SCSI_SENSE_ASCQ_LBA_OUT_OF_RANGE) { + printf("[FAILED]\n"); + printf("VERIFY12 failed but with the wrong sense code. It should have failed with ILLEGAL_REQUEST/LBA_OUT_OF_RANGE.\n"); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + scsi_free_scsi_task(task); + } + printf("[OK]\n"); + +finished: + iscsi_logout_sync(iscsi); + iscsi_destroy_context(iscsi); + return ret; +} diff --git a/test-tool/iscsi-test.c b/test-tool/iscsi-test.c index 37652aa..c220f1c 100644 --- a/test-tool/iscsi-test.c +++ b/test-tool/iscsi-test.c @@ -59,6 +59,7 @@ struct scsi_test tests[] = { { "T0130_verify10_simple", T0130_verify10_simple }, { "T0131_verify10_mismatch", T0131_verify10_mismatch }, { "T0132_verify10_mismatch_no_cmp", T0132_verify10_mismatch_no_cmp }, +{ "T0133_verify10_beyondeol", T0133_verify10_beyondeol }, /* readcapacity16*/ { "T0160_readcapacity16_simple", T0160_readcapacity16_simple }, @@ -123,6 +124,7 @@ struct scsi_test tests[] = { { "T0280_verify12_simple", T0280_verify12_simple }, { "T0281_verify12_mismatch", T0281_verify12_mismatch }, { "T0282_verify12_mismatch_no_cmp", T0282_verify12_mismatch_no_cmp }, +{ "T0283_verify12_beyondeol", T0283_verify12_beyondeol }, { NULL, NULL } }; diff --git a/test-tool/iscsi-test.h b/test-tool/iscsi-test.h index 75729a4..3543204 100644 --- a/test-tool/iscsi-test.h +++ b/test-tool/iscsi-test.h @@ -35,6 +35,7 @@ int T0122_read6_invalid(const char *initiator, const char *url, int data_loss, i int T0130_verify10_simple(const char *initiator, const char *url, int data_loss, int show_info); int T0131_verify10_mismatch(const char *initiator, const char *url, int data_loss, int show_info); int T0132_verify10_mismatch_no_cmp(const char *initiator, const char *url, int data_loss, int show_info); +int T0133_verify10_beyondeol(const char *initiator, const char *url, int data_loss, int show_info); int T0160_readcapacity16_simple(const char *initiator, const char *url, int data_loss, int show_info); @@ -86,3 +87,4 @@ int T0273_verify16_beyondeol(const char *initiator, const char *url, int data_lo int T0280_verify12_simple(const char *initiator, const char *url, int data_loss, int show_info); int T0281_verify12_mismatch(const char *initiator, const char *url, int data_loss, int show_info); int T0282_verify12_mismatch_no_cmp(const char *initiator, const char *url, int data_loss, int show_info); +int T0283_verify12_beyondeol(const char *initiator, const char *url, int data_loss, int show_info);