From 62684d641adb36cbb2914827110a2da17e2b05b2 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Thu, 26 Jan 2012 16:18:05 +1100 Subject: [PATCH] Add a test to check that if we deliberately send wrong data to the target it will reposnd with sense MISMATCH Signed-off-by: Ronnie Sahlberg --- Makefile.am | 2 +- test-tool/0131_verify10_mismatch.c | 132 +++++++++++++++++++++++++++++ test-tool/iscsi-test.c | 1 + test-tool/iscsi-test.h | 1 + 4 files changed, 135 insertions(+), 1 deletion(-) create mode 100644 test-tool/0131_verify10_mismatch.c diff --git a/Makefile.am b/Makefile.am index 1c5c323..acac02d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -59,7 +59,7 @@ bin_iscsi_test_SOURCES = test-tool/iscsi-test.c \ test-tool/0110_readcapacity10_simple.c \ test-tool/0111_readcapacity10_pmi.c test-tool/0120_read6_simple.c \ test-tool/0121_read6_beyond_eol.c test-tool/0122_read6_invalid.c \ - test-tool/0130_verify10_simple.c + test-tool/0130_verify10_simple.c test-tool/0131_verify10_mismatch.c endif # LD_PRELOAD library. diff --git a/test-tool/0131_verify10_mismatch.c b/test-tool/0131_verify10_mismatch.c new file mode 100644 index 0000000..cbba488 --- /dev/null +++ b/test-tool/0131_verify10_mismatch.c @@ -0,0 +1,132 @@ +/* + Copyright (C) 2010 by Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test.h" + +int T0131_verify10_mismatch(const char *initiator, const char *url) +{ + struct iscsi_context *iscsi; + struct scsi_task *task; + struct scsi_task *vtask; + struct scsi_readcapacity10 *rc10; + int ret, i, lun; + uint32_t block_size, num_blocks; + + iscsi = iscsi_context_login(initiator, url, &lun); + if (iscsi == NULL) { + printf("Failed to login to target\n"); + return -1; + } + + /* find the size of the LUN */ + task = iscsi_readcapacity10_sync(iscsi, lun, 0, 0); + if (task == NULL) { + printf("Failed to send readcapacity10 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status != SCSI_STATUS_GOOD) { + printf("Readcapacity command: failed with sense. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + rc10 = scsi_datain_unmarshall(task); + if (rc10 == NULL) { + printf("failed to unmarshall readcapacity10 data. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + block_size = rc10->block_size; + num_blocks = rc10->lba; + scsi_free_scsi_task(task); + + + + ret = 0; + + /* read and verify the first 1 - 256 blocks at the start of the LUN */ + printf("Read+verify first 1-256 blocks ... "); + for (i = 1; i <= 256; i++) { + char *buf; + + task = iscsi_read10_sync(iscsi, lun, 0, i * block_size, block_size); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send read10 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status != SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("Read10 command: failed with sense. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + + buf = task->datain.data; + if (buf == NULL) { + printf("[FAILED]\n"); + printf("Failed to access DATA-IN buffer %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + /* flip a random byte in the data */ + buf[random() % task->datain.size] ^= 'X'; + + vtask = iscsi_verify10_sync(iscsi, lun, buf, i * block_size, 0, 0, 1, 1, block_size); + if (vtask == NULL) { + printf("[FAILED]\n"); + printf("Failed to send verify10 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + if (vtask->status == SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("Verify10 command returned sense ok but the data is not matching.\n"); + ret = -1; + scsi_free_scsi_task(task); + scsi_free_scsi_task(vtask); + goto finished; + } + + if (vtask->sense.key != SCSI_SENSE_MISCOMPARE) { + printf("[FAILED]\n"); + printf("Verify10 command returned wrong sense key. MISCOMPARE 0x%x expected but got key 0x%x\n", SCSI_SENSE_MISCOMPARE, vtask->sense.key); + ret = -1; + scsi_free_scsi_task(task); + scsi_free_scsi_task(vtask); + goto finished; + } + + scsi_free_scsi_task(task); + scsi_free_scsi_task(vtask); + } + printf("[OK]\n"); + +finished: + iscsi_logout_sync(iscsi); + iscsi_destroy_context(iscsi); + return ret; +} diff --git a/test-tool/iscsi-test.c b/test-tool/iscsi-test.c index 70d69ae..3a0d854 100644 --- a/test-tool/iscsi-test.c +++ b/test-tool/iscsi-test.c @@ -55,6 +55,7 @@ struct scsi_test tests[] = { /* verify10*/ { "T0130_verify10_simple", T0130_verify10_simple }, +{ "T0131_verify10_mismatch", T0131_verify10_mismatch }, { NULL, NULL } }; diff --git a/test-tool/iscsi-test.h b/test-tool/iscsi-test.h index 527c324..23c32e0 100644 --- a/test-tool/iscsi-test.h +++ b/test-tool/iscsi-test.h @@ -35,3 +35,4 @@ int T0121_read6_beyond_eol(const char *initiator, const char *url); int T0122_read6_invalid(const char *initiator, const char *url); int T0130_verify10_simple(const char *initiator, const char *url); +int T0131_verify10_mismatch(const char *initiator, const char *url);