admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TEST: Add test that invalid DATASN for DATAIN is detected as an error

Browse Source 
Send a write containing two DATA-IN PDUs in a sequence but both PDUs have DATASN==0
This is an error and the target should react to this as an invalid command

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
This commit is contained in:
Ronnie Sahlberg
2012-08-10 16:08:55 +10:00
parent 0cf42c3662
commit 6412834754
5 changed files with 184 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
test-tool/iscsi-test.c
View File

@@ -17,6 +17,10 @@
along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
#define _GNU_SOURCE
#include <sys/syscall.h>
#include <dlfcn.h>
#include <sys/types.h>
#include <stdio.h>
#include <stdlib.h>
#include <stdint.h>
@@ -26,7 +30,7 @@
#include <fnmatch.h>
#include "iscsi.h"
#include "scsi-lowlevel.h"
#include "iscsi.h"
#include "iscsi-private.h"
#include "iscsi-test.h"
const char *initiator = "iqn.2007-10.com.github:sahlberg:libiscsi:iscsi-test";
@@ -194,6 +198,9 @@ struct scsi_test tests[] = {
/* invalid cmdsn from initiator */
{ "T1000_cmdsn_invalid", T1000_cmdsn_invalid },
/* invalid datasn from initiator */
{ "T1010_datasn_invalid", T1010_datasn_invalid },
{ NULL, NULL }
};
@@ -304,6 +311,16 @@ void wait_until_test_finished(struct iscsi_context *iscsi, struct iscsi_async_st
}
}
static int (*real_iscsi_queue_pdu)(struct iscsi_context *iscsi, struct iscsi_pdu *pdu);
int iscsi_queue_pdu(struct iscsi_context *iscsi, struct iscsi_pdu *pdu)
{
if (local_iscsi_queue_pdu != NULL) {
local_iscsi_queue_pdu(iscsi, pdu);
}
return real_iscsi_queue_pdu(iscsi, pdu);
}
int main(int argc, const char *argv[])
{
poptContext pc;
@@ -326,6 +343,8 @@ int main(int argc, const char *argv[])
POPT_TABLEEND
};
real_iscsi_queue_pdu = dlsym(RTLD_NEXT, "iscsi_queue_pdu");
pc = poptGetContext(argv[0], argc, argv, popt_options, POPT_CONTEXT_POSIXMEHARDER);
if ((res = poptGetNextOpt(pc)) < -1) {
fprintf(stderr, "Failed to parse option : %s %s\n",