From 65caf10cab0107e1c21916cc46943117f5f67733 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Wed, 4 Mar 2020 19:28:43 -0800 Subject: [PATCH] iser: Remove a superfluous pointer check Checking whether a pointer is NULL after it has been dereferenced is not useful. This was detected by Coverity. Signed-off-by: Bart Van Assche --- lib/iser.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/iser.c b/lib/iser.c index 1440f37..976ffce 100644 --- a/lib/iser.c +++ b/lib/iser.c @@ -278,14 +278,10 @@ iser_conn_terminate(struct iser_conn *iser_conn) int ret; struct iscsi_context *iscsi = iser_conn->cma_id->context; - if(iser_conn->cma_id) { - ret = rdma_disconnect(iser_conn->cma_id); - if (ret) - iscsi_set_error(iscsi, "Failed to disconnect, conn: 0x%p, err %d\n", - iser_conn, ret); - } - - return; + ret = rdma_disconnect(iser_conn->cma_id); + if (ret) + iscsi_set_error(iscsi, "Failed to disconnect, conn: 0x%p, err %d\n", + iser_conn, ret); } /*