Add tests for WRITE_ATOMIC_16

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
2015-09-08 10:09:26 -07:00
parent 02fd6217cb
commit 6c16f9e322
12 changed files with 489 additions and 0 deletions
--- a/test-tool/test_writeatomic16_dpofua.c
+++ b/test-tool/test_writeatomic16_dpofua.c
@@ -0,0 +1,140 @@
+/*
+   Copyright (C) 2015 by Ronnie Sahlberg <sahlberg@gmail.com>
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include <CUnit/CUnit.h>
+
+#include "iscsi.h"
+#include "scsi-lowlevel.h"
+#include "iscsi-test-cu.h"
+
+void
+test_writeatomic16_dpofua(void)
+{
+	int ret, dpofua, usage_data_dpofua;
+	struct scsi_task *ms_task = NULL;
+	struct scsi_mode_sense *ms;
+	struct scsi_task *rso_task = NULL;
+	struct scsi_report_supported_op_codes_one_command *rsoc;
+	unsigned char *buf = alloca(block_size);
+
+	logging(LOG_VERBOSE, LOG_BLANK_LINE);
+	logging(LOG_VERBOSE, "Test WRITEATOMIC16 DPO/FUA flags");
+
+	CHECK_FOR_SBC;
+	CHECK_FOR_DATALOSS;
+
+	logging(LOG_VERBOSE, "Read the DPOFUA flag from mode sense data");
+	ret = modesense6(sd, &ms_task, 0, SCSI_MODESENSE_PC_CURRENT,
+			 SCSI_MODEPAGE_RETURN_ALL_PAGES, 0, 255,
+			 EXPECT_STATUS_GOOD);
+	CU_ASSERT_EQUAL(ret, 0);
+	logging(LOG_VERBOSE, "[SUCCESS] Mode sense returned status GOOD");
+	ms = scsi_datain_unmarshall(ms_task);
+	dpofua = ms && (ms->device_specific_parameter & 0x10);
+	scsi_free_scsi_task(ms_task);
+
+	if (dpofua) {
+		logging(LOG_VERBOSE, "DPOFUA flag is set. Device should allow "
+			"DPO/FUA flags in CDBs");
+	} else {
+		logging(LOG_VERBOSE, "DPOFUA flag is clear. Device should fail "
+			"CDBs with DPO/FUA set");
+	}
+
+	logging(LOG_VERBOSE, "Test WRITEATOMIC16 with DPO==1");
+	memset(buf, 0xa6, block_size);
+	if (dpofua) {
+		ret = writeatomic16(sd, 0, block_size,
+				    block_size, 0, 1, 0, 0, buf,
+				    EXPECT_STATUS_GOOD);
+		if (ret == -2) {
+			logging(LOG_NORMAL, "[SKIPPED] WRITEATOMIC16 is not implemented.");
+			CU_PASS("WRITEATOMIC16 is not implemented.");
+			return;
+		}
+		CU_ASSERT_EQUAL(ret, 0);
+	} else {
+		ret = writeatomic16(sd, 0, block_size,
+				    block_size, 0, 1, 0, 0, buf,
+				    EXPECT_INVALID_FIELD_IN_CDB);
+		if (ret == -2) {
+			logging(LOG_NORMAL, "[SKIPPED] WRITEATOMIC16 is not implemented.");
+			CU_PASS("WRITEATOMIC16 is not implemented.");
+			return;
+		}
+		CU_ASSERT_EQUAL(ret, 0);
+	}
+
+	logging(LOG_VERBOSE, "Test WRITEATOMIC16 with FUA==1");
+	if (dpofua) {
+		ret = writeatomic16(sd, 0, block_size,
+				    block_size, 0, 0, 1, 0, buf,
+				    EXPECT_STATUS_GOOD);
+		CU_ASSERT_EQUAL(ret, 0);
+	} else {
+		ret = writeatomic16(sd, 0, block_size,
+				    block_size, 0, 0, 1, 0, buf,
+				    EXPECT_INVALID_FIELD_IN_CDB);
+		CU_ASSERT_EQUAL(ret, 0);
+	}
+
+	logging(LOG_VERBOSE, "Test WRITEATOMIC16 with DPO==1 FUA==1");
+	if (dpofua) {
+		ret = writeatomic16(sd, 0, block_size,
+				    block_size, 0, 1, 1, 0, buf,
+				    EXPECT_STATUS_GOOD);
+		CU_ASSERT_EQUAL(ret, 0);
+	} else {
+		ret = writeatomic16(sd, 0, block_size,
+				    block_size, 0, 1, 1, 0, buf,
+				    EXPECT_INVALID_FIELD_IN_CDB);
+		CU_ASSERT_EQUAL(ret, 0);
+	}
+
+
+	logging(LOG_VERBOSE, "Try fetching REPORT_SUPPORTED_OPCODES "
+		"for WRITEATOMIC16");
+	ret = report_supported_opcodes(sd, &rso_task,
+				       0, SCSI_REPORT_SUPPORTING_OPCODE,
+				       SCSI_OPCODE_WRITE_ATOMIC16,
+				       0,
+				       65535,
+				       EXPECT_STATUS_GOOD);
+	if (ret == -2) {
+		logging(LOG_NORMAL, "REPORT_SUPPORTED_OPCODES not implemented. "
+			"Skipping this part of the test");
+		return;
+	}
+	logging(LOG_VERBOSE, "Unmarshall the DATA-IN buffer");
+	rsoc = scsi_datain_unmarshall(rso_task);
+	CU_ASSERT_NOT_EQUAL(rsoc, NULL);
+	usage_data_dpofua = rsoc ? rsoc->cdb_usage_data[1] & 0x18 : -1;
+	if (dpofua) {
+		logging(LOG_VERBOSE, "DPOFUA is set. Verify the DPO/FUA flags "
+			"are set in the CDB_USAGE_DATA");
+		CU_ASSERT_EQUAL(usage_data_dpofua, 0x18);
+	} else {
+		logging(LOG_VERBOSE, "DPOFUA is clear. Verify the DPO/FUA "
+			"flags are clear in the CDB_USAGE_DATA");
+		CU_ASSERT_EQUAL(usage_data_dpofua, 0x00);
+	}
+	scsi_free_scsi_task(rso_task);
+}