From 6e2f04455f65cf5e58bfb35e282828e96a8e4220 Mon Sep 17 00:00:00 2001
From: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Date: Thu, 20 Sep 2012 18:27:04 -0700
Subject: [PATCH] TEST: Add a test that INQUIRY where EVPD==0 but PAGE_CODE!=0
 is an error

---
 Makefile.am                   |  1 +
 test-tool/0402_inquiry_evpd.c | 87 +++++++++++++++++++++++++++++++++++
 test-tool/iscsi-test.c        |  1 +
 test-tool/iscsi-test.h        |  1 +
 4 files changed, 90 insertions(+)
 create mode 100644 test-tool/0402_inquiry_evpd.c

diff --git a/Makefile.am b/Makefile.am
index 59a5a02..b7b8b95 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -129,6 +129,7 @@ bin_iscsi_test_SOURCES = test-tool/iscsi-test.c \
 	test-tool/0390_mandatory_opcodes_sbc.c \
 	test-tool/0400_inquiry_basic.c \
 	test-tool/0401_inquiry_alloclen.c \
+	test-tool/0402_inquiry_evpd.c \
 	\
 	test-tool/1000_cmdsn_invalid.c \
 	test-tool/1010_datasn_invalid.c \
diff --git a/test-tool/0402_inquiry_evpd.c b/test-tool/0402_inquiry_evpd.c
new file mode 100644
index 0000000..6db9370
--- /dev/null
+++ b/test-tool/0402_inquiry_evpd.c
@@ -0,0 +1,87 @@
+/* 
+   Copyright (C) 2012 by Ronnie Sahlberg <ronniesahlberg@gmail.com>
+   
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+   
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+   
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include <stdio.h>
+#include <string.h>
+#include <ctype.h>
+#include "iscsi.h"
+#include "scsi-lowlevel.h"
+#include "iscsi-test.h"
+
+int T0402_inquiry_evpd(const char *initiator, const char *url, int data_loss, int show_info)
+{ 
+	struct iscsi_context *iscsi;
+	struct scsi_task *task;
+	int ret, lun, i;
+
+	printf("0402_inquiry_evpd:\n");
+	printf("===================\n");
+	if (show_info) {
+		printf("Test the EVPD flag.\n");
+		printf("1, Test that EVPD==0 and PC!=0 is an error\n");
+		printf("\n");
+		return 0;
+	}
+
+	iscsi = iscsi_context_login(initiator, url, &lun);
+	if (iscsi == NULL) {
+		printf("Failed to login to target\n");
+		return -1;
+	}
+
+
+	ret = 0;
+
+
+
+	printf("Test INQUIRY with EVPD==0 and PC!=0 ... ");
+	for (i = 1; i < 256; i++) {
+		task = iscsi_inquiry_sync(iscsi, lun, 0, i, 255);
+		if (task == NULL) {
+			printf("[FAILED]\n");
+			printf("Failed to send INQUIRY command : %s\n", iscsi_get_error(iscsi));
+			ret = -1;
+			goto test2;
+		}
+		if (task->status == SCSI_STATUS_GOOD) {
+			printf("[FAILED]\n");
+			printf("INQUIRY should have failed with CHECK_CONDITION/ILLEGAL_REQUEST/INVALID_FIELD_IN_CDB %s\n", iscsi_get_error(iscsi));
+			scsi_free_scsi_task(task);
+			ret = -1;
+			goto test2;
+		}
+		if (task->status        != SCSI_STATUS_CHECK_CONDITION
+		    || task->sense.key  != SCSI_SENSE_ILLEGAL_REQUEST
+		    || task->sense.ascq != SCSI_SENSE_ASCQ_INVALID_FIELD_IN_CDB) {
+			printf("[FAILED]\n");
+			printf("INQUIRY should have failed with wrong sense code. It failed with %s but should have failed with ILLEGAL_REQUEST/INVALID_FIELD_IN_CDB\n", iscsi_get_error(iscsi));
+			scsi_free_scsi_task(task);
+			ret = -1;
+			goto test2;
+		}
+		scsi_free_scsi_task(task);
+	}
+	printf("[OK]\n");
+
+test2:
+
+
+finished:
+	iscsi_logout_sync(iscsi);
+	iscsi_destroy_context(iscsi);
+	return ret;
+}
diff --git a/test-tool/iscsi-test.c b/test-tool/iscsi-test.c
index 29fa4c7..a7c9d06 100644
--- a/test-tool/iscsi-test.c
+++ b/test-tool/iscsi-test.c
@@ -204,6 +204,7 @@ struct scsi_test tests[] = {
 /* inquiry*/
 { "T0400_inquiry_basic",		T0400_inquiry_basic },
 { "T0401_inquiry_alloclen",		T0401_inquiry_alloclen },
+{ "T0402_inquiry_evpd",			T0402_inquiry_evpd },
 
 /* iSCSI protocol tests */
 
diff --git a/test-tool/iscsi-test.h b/test-tool/iscsi-test.h
index 007b8f3..76fdac2 100644
--- a/test-tool/iscsi-test.h
+++ b/test-tool/iscsi-test.h
@@ -158,6 +158,7 @@ int T0390_mandatory_opcodes_sbc(const char *initiator, const char *url, int data
 
 int T0400_inquiry_basic(const char *initiator, const char *url, int data_loss, int show_info);
 int T0401_inquiry_alloclen(const char *initiator, const char *url, int data_loss, int show_info);
+int T0402_inquiry_evpd(const char *initiator, const char *url, int data_loss, int show_info);
 
 int T1000_cmdsn_invalid(const char *initiator, const char *url, int data_loss, int show_info);
 int T1010_datasn_invalid(const char *initiator, const char *url, int data_loss, int show_info);