From 703d9120bc1b13323c86f4ef49144f02126be904 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Thu, 20 Sep 2012 19:38:30 -0700 Subject: [PATCH] TEST: Add test for TESTUNITREADY Add an explicit test for this opcode. We already have plenty of implicit tests via the normal iscsi login functions. --- Makefile.am | 1 + test-tool/0000_testunitready_simple.c | 69 +++++++++++++++++++++++++++ test-tool/iscsi-test.c | 3 ++ test-tool/iscsi-test.h | 2 + 4 files changed, 75 insertions(+) create mode 100644 test-tool/0000_testunitready_simple.c diff --git a/Makefile.am b/Makefile.am index b7b8b95..4162795 100644 --- a/Makefile.am +++ b/Makefile.am @@ -56,6 +56,7 @@ dist_noinst_HEADERS += test-tool/iscsi-test.h bin_iscsi_test_CPPFLAGS = $(AM_CPPFLAGS) -I$(srcdir)/test-tool bin_iscsi_test_LDFLAGS = -ldl bin_iscsi_test_SOURCES = test-tool/iscsi-test.c \ + test-tool/0000_testunitready_simple.c \ test-tool/0100_read10_simple.c test-tool/0101_read10_beyond_eol.c \ test-tool/0102_read10_0blocks.c test-tool/0103_read10_rdprotect.c \ test-tool/0104_read10_flags.c test-tool/0105_read10_invalid.c \ diff --git a/test-tool/0000_testunitready_simple.c b/test-tool/0000_testunitready_simple.c new file mode 100644 index 0000000..1cbbbc9 --- /dev/null +++ b/test-tool/0000_testunitready_simple.c @@ -0,0 +1,69 @@ +/* + Copyright (C) 2012 by Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test.h" + +int T0000_testunitready_simple(const char *initiator, const char *url, int data_loss _U_, int show_info) +{ + struct iscsi_context *iscsi; + struct scsi_task *task; + int ret, i, lun; + + printf("0000_testunitready_simple:\n"); + printf("===================\n"); + if (show_info) { + printf("Test basic TESTUNITREADY functionality.\n"); + printf("1, Verify TESTUNITREADY works.\n"); + printf("\n"); + return 0; + } + + iscsi = iscsi_context_login(initiator, url, &lun); + if (iscsi == NULL) { + printf("Failed to login to target\n"); + return -1; + } + + + printf("Test TESTUNITREADY ... "); + task = iscsi_testunitready_sync(iscsi, lun); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send TEST UNIT READY command: %s\n", iscsi_get_error(iscsi)); + ret++; + goto test2; + } + if (task->status != SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("TEST UNIT READY command: failed with sense %s\n", iscsi_get_error(iscsi)); + ret++; + scsi_free_scsi_task(task); + goto test2; + } + scsi_free_scsi_task(task); + printf("[OK]\n"); + +test2: + +finished: + iscsi_logout_sync(iscsi); + iscsi_destroy_context(iscsi); + return ret; +} diff --git a/test-tool/iscsi-test.c b/test-tool/iscsi-test.c index a7c9d06..a8b3720 100644 --- a/test-tool/iscsi-test.c +++ b/test-tool/iscsi-test.c @@ -46,6 +46,9 @@ struct scsi_test { struct scsi_test tests[] = { /* SCSI protocol tests */ +/* testunitready*/ +{ "T0000_testunitready_simple", T0000_testunitready_simple }, + /* read10*/ { "T0100_read10_simple", T0100_read10_simple }, { "T0101_read10_beyond_eol", T0101_read10_beyond_eol }, diff --git a/test-tool/iscsi-test.h b/test-tool/iscsi-test.h index 76fdac2..756567c 100644 --- a/test-tool/iscsi-test.h +++ b/test-tool/iscsi-test.h @@ -29,6 +29,8 @@ void wait_until_test_finished(struct iscsi_context *iscsi, struct iscsi_async_st struct iscsi_pdu; int (*local_iscsi_queue_pdu)(struct iscsi_context *iscsi, struct iscsi_pdu *pdu); +int T0000_testunitready_simple(const char *initiator, const char *url, int data_loss, int show_info); + int T0100_read10_simple(const char *initiator, const char *url, int data_loss, int show_info); int T0101_read10_beyond_eol(const char *initiator, const char *url, int data_loss, int show_info); int T0102_read10_0blocks(const char *initiator, const char *url, int data_loss, int show_info);