admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Silence clang missing-field-initializers warning

Browse Source 
When libiscsi is built with clang several spurious
missing-field-initializers warnings like the following are reported:

test_async_write.c:61:45: error: missing field 'completed' initializer
[-Werror,-Wmissing-field-initializers]
	struct tests_async_write_state state = { 0 };

These appear to be due to clang being overzealous in its checking
because the code is legal C (see
https://llvm.org/bugs/show_bug.cgi?id=21689 ) but it causes compilation
to be aborted. Workaround the problem by specifying a 0 or NULL for each
structure member.
This commit is contained in:
Sitsofe Wheeler
2016-03-31 20:13:13 +01:00
parent 2bba2fedf9
commit 71879c913a
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test-tool/test_async_abort_simple.c
View File

@@ -87,7 +87,7 @@ void
test_async_abort_simple(void) test_async_abort_simple(void)
{ {
int ret; int ret;
struct tests_async_abort_state state = { 0 }; struct tests_async_abort_state state = { NULL, 0, 0, 0, 0 };
int blocksize = 512; int blocksize = 512;
int blocks_per_io = 8; int blocks_per_io = 8;
unsigned char buf[blocksize * blocks_per_io]; unsigned char buf[blocksize * blocks_per_io];

2
test-tool/test_async_read.c
View File

@@ -59,7 +59,7 @@ void
test_async_read(void) test_async_read(void)
{ {
int i, ret; int i, ret;
struct tests_async_read_state state = { 0 }; struct tests_async_read_state state = { 0, 0, 0 };
int blocksize = 512; int blocksize = 512;
int blocks_per_io = 8; int blocks_per_io = 8;
int num_ios = 1000; int num_ios = 1000;

2
test-tool/test_async_write.c
View File

@@ -58,7 +58,7 @@ void
test_async_write(void) test_async_write(void)
{ {
int i, ret; int i, ret;
struct tests_async_write_state state = { 0 }; struct tests_async_write_state state = { 0, 0, 0 };
int blocksize = 512; int blocksize = 512;
int blocks_per_io = 8; int blocks_per_io = 8;
int num_ios = 1000; int num_ios = 1000;

2
test-tool/test_multipathio_async_caw.c
View File

@@ -102,7 +102,7 @@ test_mpio_async_caw(void)
{ {
int i, ret; int i, ret;
int sd_i; int sd_i;
struct test_mpio_async_caw_state state = { 0 }; struct test_mpio_async_caw_state state = { 0, 0, 0 };
int blocksize = 512; int blocksize = 512;
int num_ios = 1000; int num_ios = 1000;
uint32_t lba = 0; uint32_t lba = 0;