Tests: Make null pointer asserts abort the test
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
This commit is contained in:
@@ -54,7 +54,7 @@ test_write10_residuals(void)
|
||||
|
||||
/* Try a write10 of 1 block but xferlength == 0 */
|
||||
task = malloc(sizeof(struct scsi_task));
|
||||
CU_ASSERT_PTR_NOT_NULL(task);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task);
|
||||
|
||||
memset(task, 0, sizeof(struct scsi_task));
|
||||
task->cdb[0] = SCSI_OPCODE_WRITE10;
|
||||
@@ -72,7 +72,7 @@ test_write10_residuals(void)
|
||||
logging(LOG_VERBOSE, "Try writing one block but with iSCSI expected transfer length==0");
|
||||
|
||||
task_ret = iscsi_scsi_command_sync(sd->iscsi_ctx, sd->iscsi_lun, task, NULL);
|
||||
CU_ASSERT_PTR_NOT_NULL(task_ret);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task_ret);
|
||||
CU_ASSERT_NOT_EQUAL(task->status, SCSI_STATUS_CANCELLED); /* XXX redundant? */
|
||||
|
||||
if (task->status == SCSI_STATUS_CHECK_CONDITION
|
||||
@@ -113,7 +113,7 @@ test_write10_residuals(void)
|
||||
|
||||
logging(LOG_VERBOSE, "Try writing one block but with iSCSI expected transfer length==10000");
|
||||
task = malloc(sizeof(struct scsi_task));
|
||||
CU_ASSERT_PTR_NOT_NULL(task);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task);
|
||||
|
||||
memset(task, 0, sizeof(struct scsi_task));
|
||||
task->cdb[0] = SCSI_OPCODE_WRITE10;
|
||||
@@ -126,7 +126,7 @@ test_write10_residuals(void)
|
||||
data.size = task->expxferlen;
|
||||
data.data = &buf[0];
|
||||
task_ret = iscsi_scsi_command_sync(sd->iscsi_ctx, sd->iscsi_lun, task, &data);
|
||||
CU_ASSERT_PTR_NOT_NULL(task_ret);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task_ret);
|
||||
|
||||
logging(LOG_VERBOSE, "Verify that the target returned SUCCESS");
|
||||
if (task->status != SCSI_STATUS_GOOD) {
|
||||
@@ -156,7 +156,7 @@ test_write10_residuals(void)
|
||||
|
||||
logging(LOG_VERBOSE, "Try writing one block but with iSCSI expected transfer length==200");
|
||||
task = malloc(sizeof(struct scsi_task));
|
||||
CU_ASSERT_PTR_NOT_NULL(task);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task);
|
||||
|
||||
memset(task, 0, sizeof(struct scsi_task));
|
||||
task->cdb[0] = SCSI_OPCODE_WRITE10;
|
||||
@@ -168,7 +168,7 @@ test_write10_residuals(void)
|
||||
data.size = task->expxferlen;
|
||||
data.data = &buf[0];
|
||||
task_ret = iscsi_scsi_command_sync(sd->iscsi_ctx, sd->iscsi_lun, task, &data);
|
||||
CU_ASSERT_PTR_NOT_NULL(task_ret);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task_ret);
|
||||
|
||||
logging(LOG_VERBOSE, "Verify that the target returned SUCCESS");
|
||||
ok = task->status == SCSI_STATUS_GOOD ||
|
||||
@@ -205,7 +205,7 @@ test_write10_residuals(void)
|
||||
logging(LOG_VERBOSE, "Try writing two blocks but iSCSI expected "
|
||||
"transfer length==%zu (==one block)", block_size);
|
||||
task = malloc(sizeof(struct scsi_task));
|
||||
CU_ASSERT_PTR_NOT_NULL(task);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task);
|
||||
|
||||
memset(task, 0, sizeof(struct scsi_task));
|
||||
task->cdb[0] = SCSI_OPCODE_WRITE10;
|
||||
@@ -217,7 +217,7 @@ test_write10_residuals(void)
|
||||
data.size = task->expxferlen;
|
||||
data.data = &buf[0];
|
||||
task_ret = iscsi_scsi_command_sync(sd->iscsi_ctx, sd->iscsi_lun, task, &data);
|
||||
CU_ASSERT_PTR_NOT_NULL(task_ret);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task_ret);
|
||||
|
||||
logging(LOG_VERBOSE, "Verify that the target returned SUCCESS");
|
||||
if (task->status != SCSI_STATUS_GOOD) {
|
||||
@@ -258,7 +258,7 @@ test_write10_residuals(void)
|
||||
|
||||
logging(LOG_VERBOSE, "Write one block of 'b' but set iSCSI EDTL to 2 blocks.");
|
||||
task = malloc(sizeof(struct scsi_task));
|
||||
CU_ASSERT_PTR_NOT_NULL(task);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task);
|
||||
|
||||
memset(buf, 'b', 10000);
|
||||
|
||||
@@ -272,7 +272,7 @@ test_write10_residuals(void)
|
||||
data.size = task->expxferlen;
|
||||
data.data = &buf[0];
|
||||
task_ret = iscsi_scsi_command_sync(sd->iscsi_ctx, sd->iscsi_lun, task, &data);
|
||||
CU_ASSERT_PTR_NOT_NULL(task_ret);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task_ret);
|
||||
|
||||
logging(LOG_VERBOSE, "Verify that the target returned SUCCESS");
|
||||
if (task->status != SCSI_STATUS_GOOD) {
|
||||
@@ -334,7 +334,7 @@ test_write10_residuals(void)
|
||||
|
||||
logging(LOG_VERBOSE, "Write two blocks of 'b' but set iSCSI EDTL to 1 blocks.");
|
||||
task = malloc(sizeof(struct scsi_task));
|
||||
CU_ASSERT_PTR_NOT_NULL(task);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task);
|
||||
|
||||
memset(buf, 'b', 10000);
|
||||
|
||||
@@ -348,7 +348,7 @@ test_write10_residuals(void)
|
||||
data.size = task->expxferlen;
|
||||
data.data = &buf[0];
|
||||
task_ret = iscsi_scsi_command_sync(sd->iscsi_ctx, sd->iscsi_lun, task, &data);
|
||||
CU_ASSERT_PTR_NOT_NULL(task_ret);
|
||||
CU_ASSERT_PTR_NOT_NULL_FATAL(task_ret);
|
||||
|
||||
logging(LOG_VERBOSE, "Verify that the target returned SUCCESS");
|
||||
if (task->status != SCSI_STATUS_GOOD) {
|
||||
|
||||
Reference in New Issue
Block a user