admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

libiscsi: Fix RECEIVE COPY RESULTS response unmarshalling

Browse Source 
Allocate the correct amount of memory for the scsi_copy_results_copy_status
and scsi_copy_results_op_params structures.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
This commit is contained in:
Ronnie Sahlberg
2015-12-24 10:34:45 -08:00
parent 9ab1cc8baa
commit 7b8363827b
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/scsi-lowlevel.c
View File

@@ -845,8 +845,9 @@ scsi_receivecopyresults_datain_unmarshall(struct scsi_task *task)
switch (sa) { switch (sa) {
case SCSI_COPY_RESULTS_COPY_STATUS: case SCSI_COPY_RESULTS_COPY_STATUS:
len = task_get_uint32(task, 0); len = task_get_uint32(task, 0);
if (len < 8)
cs = scsi_malloc(task, len+4); return NULL;
cs = scsi_malloc(task, sizeof(*cs));
if (cs == NULL) { if (cs == NULL) {
return NULL; return NULL;
} }
@@ -860,8 +861,9 @@ scsi_receivecopyresults_datain_unmarshall(struct scsi_task *task)
case SCSI_COPY_RESULTS_OP_PARAMS: case SCSI_COPY_RESULTS_OP_PARAMS:
len = task_get_uint32(task, 0); len = task_get_uint32(task, 0);
if (len < 40)
op = scsi_malloc(task, len+4); return NULL;
op = scsi_malloc(task, sizeof(*op) + task_get_uint8(task, 43));
if (op == NULL) { if (op == NULL) {
return NULL; return NULL;
} }