diff --git a/Makefile.am b/Makefile.am index 0cd804a..11d3eac 100644 --- a/Makefile.am +++ b/Makefile.am @@ -114,7 +114,8 @@ bin_iscsi_test_SOURCES = test-tool/iscsi-test.c \ test-tool/0382_preventallow_itnexus_loss.c \ test-tool/0383_preventallow_target_warm_reset.c \ test-tool/0384_preventallow_target_cold_reset.c \ - test-tool/0385_preventallow_lun_reset.c + test-tool/0385_preventallow_lun_reset.c \ + test-tool/0386_preventallow_2_it_nexuses.c endif diff --git a/test-tool/0382_preventallow_itnexus_loss.c b/test-tool/0382_preventallow_itnexus_loss.c index 9860856..c580682 100644 --- a/test-tool/0382_preventallow_itnexus_loss.c +++ b/test-tool/0382_preventallow_itnexus_loss.c @@ -164,7 +164,7 @@ test2: printf("Eject failed. [OK]\n"); test3: - printf("Tear down the I_T_Nexus and create a new one ... "); + printf("Tear down the IT_Nexus and create a new one ... "); iscsi_destroy_context(iscsi); iscsi = iscsi_context_login(initiator, url, &lun); if (iscsi == NULL) { diff --git a/test-tool/0386_preventallow_2_it_nexuses.c b/test-tool/0386_preventallow_2_it_nexuses.c new file mode 100644 index 0000000..128cfec --- /dev/null +++ b/test-tool/0386_preventallow_2_it_nexuses.c @@ -0,0 +1,279 @@ +/* + Copyright (C) 2012 by Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include +#include +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test.h" + +int T0386_preventallow_2_itl_nexuses(const char *initiator, const char *url, int data_loss, int show_info) +{ + struct iscsi_context *iscsi; + struct iscsi_context *iscsi2 = NULL; + struct scsi_task *task; + struct scsi_readcapacity16 *rc16; + struct scsi_inquiry_standard *inq; + int ret, lun, removable; + uint32_t block_size; + uint64_t num_blocks; + int full_size; + + printf("0386_preventallow_2_itl_nexuses:\n"); + printf("============================\n"); + if (show_info) { + printf("Test that each IT nexus has its own PREVENT setting\n"); + printf("1, Verify we can set PREVENTALLOW on two IT_Nexuses(if the medium is removable)\n"); + printf("2, Verify we can no longer eject the media\n"); + printf("3, Remove the PREVENT on this IT_Nexus\n"); + printf("4, Verify we can still not eject the media\n"); + printf("5, Load the media again in case it was ejected\n"); + printf("6, Clear PREVENTALLOW again\n"); + printf("\n"); + return 0; + } + + iscsi = iscsi_context_login(initiator, url, &lun); + if (iscsi == NULL) { + printf("Failed to login to target\n"); + return -1; + } + + /* find the size of the LUN */ + task = iscsi_readcapacity16_sync(iscsi, lun); + if (task == NULL) { + printf("Failed to send READCAPACITY16 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status != SCSI_STATUS_GOOD) { + printf("READCAPACITY16 command: failed with sense. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + rc16 = scsi_datain_unmarshall(task); + if (rc16 == NULL) { + printf("failed to unmarshall READCAPACITY16 data. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + block_size = rc16->block_length; + num_blocks = rc16->returned_lba; + scsi_free_scsi_task(task); + + /* See how big this inquiry data is */ + task = iscsi_inquiry_sync(iscsi, lun, 0, 0, 64); + if (task == NULL || task->status != SCSI_STATUS_GOOD) { + printf("Inquiry command failed : %s\n", iscsi_get_error(iscsi)); + return -1; + } + full_size = scsi_datain_getfullsize(task); + if (full_size > task->datain.size) { + scsi_free_scsi_task(task); + + /* we need more data for the full list */ + if ((task = iscsi_inquiry_sync(iscsi, lun, 0, 0, full_size)) == NULL) { + printf("Inquiry command failed : %s\n", iscsi_get_error(iscsi)); + return -1; + } + } + inq = scsi_datain_unmarshall(task); + if (inq == NULL) { + printf("failed to unmarshall inquiry datain blob\n"); + scsi_free_scsi_task(task); + return -1; + } + removable = inq->rmb; + + scsi_free_scsi_task(task); + + if (!data_loss) { + printf("--dataloss flag is not set. Skipping test\n"); + ret = -1; + goto finished; + } + + + ret = 0; + + + if (!removable) { + printf("Media is not removable. Skipping tests\n"); + goto finished; + } + + + printf("Try to set PREVENTALLOW ... "); + task = iscsi_preventallow_sync(iscsi, lun, 1); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send PREVENTALLOW command: %s\n", iscsi_get_error(iscsi)); + ret++; + goto test2; + } + + /* SPC doesnt really say anything about what should happen if using PREVENTALLOW + * on a device that does not support medium removals. + */ + if (removable) { + if (task->status != SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("PREVENTALLOW command: failed with sense %s\n", iscsi_get_error(iscsi)); + ret++; + scsi_free_scsi_task(task); + goto test2; + } + } + scsi_free_scsi_task(task); + + iscsi2 = iscsi_context_login(initiator, url, &lun); + if (iscsi == NULL) { + printf("Failed to login to target\n"); + return -1; + } + task = iscsi_preventallow_sync(iscsi2, lun, 1); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send PREVENTALLOW command: %s\n", iscsi_get_error(iscsi2)); + ret++; + goto test2; + } + scsi_free_scsi_task(task); + + printf("[OK]\n"); + +test2: + printf("Try to eject the media ... "); + task = iscsi_startstopunit_sync(iscsi, lun, 1, 0, 0, 0, 1, 0); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send STARTSTOPUNIT command: %s\n", iscsi_get_error(iscsi)); + ret++; + goto test3; + } + if (task->status != SCSI_STATUS_CHECK_CONDITION + || task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST + || task->sense.ascq != SCSI_SENSE_ASCQ_MEDIUM_REMOVAL_PREVENTED) { + printf("[FAILED]\n"); + printf("STARTSTOPUNIT command should have failed with ILLEGAL_REQUEST/MEDIUM_REMOVAL_PREVENTED with : failed with sense. %s\n", iscsi_get_error(iscsi)); + ret++; + scsi_free_scsi_task(task); + goto test3; + } + scsi_free_scsi_task(task); + printf("Eject failed. [OK]\n"); + +test3: + printf("Remove the PREVENT on this IT_Nexus ... "); + task = iscsi_preventallow_sync(iscsi, lun, 0); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send PREVENTALLOW command: %s\n", iscsi_get_error(iscsi)); + ret++; + goto test4; + } + + scsi_free_scsi_task(task); + printf("[OK]\n"); + +test4: + + printf("Try to eject the media ... "); + task = iscsi_startstopunit_sync(iscsi, lun, 1, 0, 0, 0, 1, 0); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send STARTSTOPUNIT command: %s\n", iscsi_get_error(iscsi)); + ret++; + goto test5; + } + if (task->status != SCSI_STATUS_CHECK_CONDITION + || task->sense.key != SCSI_SENSE_ILLEGAL_REQUEST + || task->sense.ascq != SCSI_SENSE_ASCQ_MEDIUM_REMOVAL_PREVENTED) { + printf("[FAILED]\n"); + printf("STARTSTOPUNIT command should have failed with ILLEGAL_REQUEST/MEDIUM_REMOVAL_PREVENTED with : failed with sense. %s\n", iscsi_get_error(iscsi)); + ret++; + scsi_free_scsi_task(task); + goto test3; + } + scsi_free_scsi_task(task); + printf("Eject failed. [OK]\n"); + +test5: + + + printf("Load the media again in case it was ejected ... "); + task = iscsi_startstopunit_sync(iscsi, lun, 1, 0, 0, 0, 1, 1); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send STARTSTOPUNIT command: %s\n", iscsi_get_error(iscsi)); + ret++; + goto test6; + } + /* SBC doesnt really say anything about whether we can LOAD media when the prevent + * flag is set + */ + scsi_free_scsi_task(task); + printf("[OK]\n"); + +test6: + + + printf("Clear the PREVENTALLOW again ... "); + task = iscsi_preventallow_sync(iscsi, lun, 0); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send PREVENTALLOW command: %s\n", iscsi_get_error(iscsi)); + ret++; + goto test7; + } + /* SPC doesnt really say anything about what should happen if using PREVENTALLOW + * on a device that does not support medium removals. + */ + if (removable) { + if (task->status != SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("PREVENTALLOW command: failed with sense %s\n", iscsi_get_error(iscsi)); + ret++; + scsi_free_scsi_task(task); + goto test7; + } + } + scsi_free_scsi_task(task); + + task = iscsi_preventallow_sync(iscsi2, lun, 0); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send PREVENTALLOW command: %s\n", iscsi_get_error(iscsi2)); + ret++; + goto test7; + } + scsi_free_scsi_task(task); + + printf("[OK]\n"); + +test7: + +finished: + iscsi_logout_sync(iscsi); + iscsi_destroy_context(iscsi); + if (iscsi2 != NULL) { + iscsi_destroy_context(iscsi2); + } + return ret; +} diff --git a/test-tool/iscsi-test.c b/test-tool/iscsi-test.c index 3a3957a..faa1b86 100644 --- a/test-tool/iscsi-test.c +++ b/test-tool/iscsi-test.c @@ -181,6 +181,7 @@ struct scsi_test tests[] = { { "T0383_preventallow_target_warm_reset", T0383_preventallow_target_warm_reset }, { "T0384_preventallow_target_cold_reset", T0384_preventallow_target_cold_reset }, { "T0385_preventallow_lun_reset", T0385_preventallow_lun_reset }, +{ "T0386_preventallow_2_itl_nexuses", T0386_preventallow_2_itl_nexuses }, { NULL, NULL } }; diff --git a/test-tool/iscsi-test.h b/test-tool/iscsi-test.h index fd1599b..76db0d1 100644 --- a/test-tool/iscsi-test.h +++ b/test-tool/iscsi-test.h @@ -134,3 +134,4 @@ int T0382_preventallow_itnexus_loss(const char *initiator, const char *url, int int T0383_preventallow_target_warm_reset(const char *initiator, const char *url, int data_loss, int show_info); int T0384_preventallow_target_cold_reset(const char *initiator, const char *url, int data_loss, int show_info); int T0385_preventallow_lun_reset(const char *initiator, const char *url, int data_loss, int show_info); +int T0386_preventallow_2_itl_nexuses(const char *initiator, const char *url, int data_loss, int show_info);