From 114bbf00e17ded3256a1045099a5a486144666f3 Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Fri, 22 May 2026 18:35:43 +1000 Subject: [PATCH] configure: fix bogus TEST_CHAP_BASE64 conditional The conditional should be checking for gnutls presence. On openSUSE Tumbleweed without gnutls this gives me: > ./test-tool/iscsi-test-cu --list|grep -i chap ALL.iSCSICHAP ALL.iSCSICHAP.Simple ALL.iSCSICHAP.Invalid iSCSI.iSCSICHAP iSCSI.iSCSICHAP.Simple iSCSI.iSCSICHAP.Invalid Install gnutls, rebuild and check for base64 test presence: > sudo zypper in gnutls-devel > git clean -fxd . > ./test-tool/iscsi-test-cu --list|grep -i chap ALL.iSCSICHAP ALL.iSCSICHAP.Simple ALL.iSCSICHAP.Invalid ALL.iSCSICHAP.Base64 ALL.iSCSICHAP.Base64Oversize iSCSI.iSCSICHAP iSCSI.iSCSICHAP.Simple iSCSI.iSCSICHAP.Invalid iSCSI.iSCSICHAP.Base64 iSCSI.iSCSICHAP.Base64Oversize Signed-off-by: David Disseldorp --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 2e829b2..8874db6 100644 --- a/configure.ac +++ b/configure.ac @@ -109,7 +109,7 @@ if test "$WITH_LIBGCRYPT" != no; then WITH_LIBGCRYPT=$ac_cv_lib_gcrypt_gcry_control fi # gnutls_base64_encode2() was added >8 years ago so should be present -AM_CONDITIONAL(TEST_CHAP_BASE64, [test "$WITH_LIBGCRYPT"]) +AM_CONDITIONAL(TEST_CHAP_BASE64, [test "$WITH_GNUTLS" = yes]) NEED_MD5=no if test "$WITH_GNUTLS" = no && test "$WITH_LIBGCRYPT" = no; then