From 9e303bf6351d31d21a757129f5739684c2cac532 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Wed, 2 May 2012 21:38:43 +1000 Subject: [PATCH] TEST: Add a test reading beyond the end of the device for read12/16 --- Makefile.am | 6 +- test-tool/0204_read16_beyondeol.c | 92 +++++++++++++++++++++++++++++++ test-tool/0214_read12_beyondeol.c | 92 +++++++++++++++++++++++++++++++ test-tool/iscsi-test.c | 2 + test-tool/iscsi-test.h | 2 + 5 files changed, 192 insertions(+), 2 deletions(-) create mode 100644 test-tool/0204_read16_beyondeol.c create mode 100644 test-tool/0214_read12_beyondeol.c diff --git a/Makefile.am b/Makefile.am index 5db8234..3a61925 100644 --- a/Makefile.am +++ b/Makefile.am @@ -68,9 +68,11 @@ bin_iscsi_test_SOURCES = test-tool/iscsi-test.c \ test-tool/0180_writesame10_unmap.c test-tool/0181_writesame10_unmap_unaligned.c \ test-tool/0190_writesame16_unmap.c test-tool/0191_writesame16_unmap_unaligned.c \ test-tool/0200_read16_simple.c test-tool/0201_read16_rdprotect.c \ - test-tool/0202_read16_flags.c test-tool/0203_read16_0blocks.c \ + test-tool/0202_read16_flags.c test-tool/0203_read16_0blocks.c \ + test-tool/0204_read16_beyondeol.c \ test-tool/0210_read12_simple.c test-tool/0211_read12_rdprotect.c \ - test-tool/0212_read12_flags.c test-tool/0213_read12_0blocks.c + test-tool/0212_read12_flags.c test-tool/0213_read12_0blocks.c \ + test-tool/0214_read12_beyondeol.c endif # LD_PRELOAD library. diff --git a/test-tool/0204_read16_beyondeol.c b/test-tool/0204_read16_beyondeol.c new file mode 100644 index 0000000..406696f --- /dev/null +++ b/test-tool/0204_read16_beyondeol.c @@ -0,0 +1,92 @@ +/* + Copyright (C) 2012 by Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test.h" + +int T0204_read16_beyondeol(const char *initiator, const char *url) +{ + struct iscsi_context *iscsi; + struct scsi_task *task; + struct scsi_readcapacity16 *rc16; + int ret, i, lun; + uint32_t block_size; + uint64_t num_blocks; + + iscsi = iscsi_context_login(initiator, url, &lun); + if (iscsi == NULL) { + printf("Failed to login to target\n"); + return -1; + } + + /* find the size of the LUN */ + task = iscsi_readcapacity16_sync(iscsi, lun); + if (task == NULL) { + printf("Failed to send READCAPACITY16 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status != SCSI_STATUS_GOOD) { + printf("READCAPACITY16 command: failed with sense. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + rc16 = scsi_datain_unmarshall(task); + if (rc16 == NULL) { + printf("failed to unmarshall READCAPACITY10 data. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + block_size = rc16->block_length; + num_blocks = rc16->returned_lba; + scsi_free_scsi_task(task); + + + + ret = 0; + + /* read 1 - 256 blocks beyond the end of the device */ + printf("Reading 1-256 blocks beyond end-of-device ... "); + for (i = 2; i <= 257; i++) { + task = iscsi_read16_sync(iscsi, lun, num_blocks, i * block_size, block_size, 0, 0, 0, 0, 0); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send read16 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status == SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("Read16 command should fail when reading beyond end of device\n"); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + scsi_free_scsi_task(task); + } + printf("[OK]\n"); + + +finished: + iscsi_logout_sync(iscsi); + iscsi_destroy_context(iscsi); + return ret; +} diff --git a/test-tool/0214_read12_beyondeol.c b/test-tool/0214_read12_beyondeol.c new file mode 100644 index 0000000..590e698 --- /dev/null +++ b/test-tool/0214_read12_beyondeol.c @@ -0,0 +1,92 @@ +/* + Copyright (C) 2012 by Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-test.h" + +int T0214_read12_beyondeol(const char *initiator, const char *url) +{ + struct iscsi_context *iscsi; + struct scsi_task *task; + struct scsi_readcapacity16 *rc16; + int ret, i, lun; + uint32_t block_size; + uint64_t num_blocks; + + iscsi = iscsi_context_login(initiator, url, &lun); + if (iscsi == NULL) { + printf("Failed to login to target\n"); + return -1; + } + + /* find the size of the LUN */ + task = iscsi_readcapacity16_sync(iscsi, lun); + if (task == NULL) { + printf("Failed to send READCAPACITY16 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status != SCSI_STATUS_GOOD) { + printf("READCAPACITY16 command: failed with sense. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + rc16 = scsi_datain_unmarshall(task); + if (rc16 == NULL) { + printf("failed to unmarshall READCAPACITY10 data. %s\n", iscsi_get_error(iscsi)); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + block_size = rc16->block_length; + num_blocks = rc16->returned_lba; + scsi_free_scsi_task(task); + + + + ret = 0; + + /* read 1 - 256 blocks beyond the end of the device */ + printf("Reading 1-256 blocks beyond end-of-device ... "); + for (i = 2; i <= 257; i++) { + task = iscsi_read12_sync(iscsi, lun, num_blocks, i * block_size, block_size, 0, 0, 0, 0, 0); + if (task == NULL) { + printf("[FAILED]\n"); + printf("Failed to send read12 command: %s\n", iscsi_get_error(iscsi)); + ret = -1; + goto finished; + } + if (task->status == SCSI_STATUS_GOOD) { + printf("[FAILED]\n"); + printf("Read12 command should fail when reading beyond end of device\n"); + ret = -1; + scsi_free_scsi_task(task); + goto finished; + } + scsi_free_scsi_task(task); + } + printf("[OK]\n"); + + +finished: + iscsi_logout_sync(iscsi); + iscsi_destroy_context(iscsi); + return ret; +} diff --git a/test-tool/iscsi-test.c b/test-tool/iscsi-test.c index a550fca..0789e65 100644 --- a/test-tool/iscsi-test.c +++ b/test-tool/iscsi-test.c @@ -85,12 +85,14 @@ struct scsi_test tests[] = { { "T0201_read16_rdprotect", T0201_read16_rdprotect }, { "T0202_read16_flags", T0202_read16_flags }, { "T0203_read16_0blocks", T0203_read16_0blocks }, +{ "T0204_read16_beyondeol", T0204_read16_beyondeol }, /* read12*/ { "T0210_read12_simple", T0210_read12_simple }, { "T0211_read12_rdprotect", T0211_read12_rdprotect }, { "T0212_read12_flags", T0212_read12_flags }, { "T0213_read12_0blocks", T0213_read12_0blocks }, +{ "T0214_read12_beyondeol", T0214_read12_beyondeol }, { NULL, NULL } }; diff --git a/test-tool/iscsi-test.h b/test-tool/iscsi-test.h index 46f45b9..d784958 100644 --- a/test-tool/iscsi-test.h +++ b/test-tool/iscsi-test.h @@ -58,8 +58,10 @@ int T0200_read16_simple(const char *initiator, const char *url); int T0201_read16_rdprotect(const char *initiator, const char *url); int T0202_read16_flags(const char *initiator, const char *url); int T0203_read16_0blocks(const char *initiator, const char *url); +int T0204_read16_beyondeol(const char *initiator, const char *url); int T0210_read12_simple(const char *initiator, const char *url); int T0211_read12_rdprotect(const char *initiator, const char *url); int T0212_read12_flags(const char *initiator, const char *url); int T0213_read12_0blocks(const char *initiator, const char *url); +int T0214_read12_beyondeol(const char *initiator, const char *url);