From 9fdb2b16b4a72d450ae1cd379c7b6a8e7374fcc9 Mon Sep 17 00:00:00 2001
From: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Date: Mon, 10 Sep 2012 20:35:09 -0700
Subject: [PATCH] TESTS: Add a test for READCAPACITY16  with allocation-length
 == 0

Add a READCAPACITY16 testcase from the Microsoft scsi compliance test suite.
---
 Makefile.am                              |  1 +
 test-tool/0161_readcapacity16_alloclen.c | 91 ++++++++++++++++++++++++
 test-tool/iscsi-test.c                   |  1 +
 test-tool/iscsi-test.h                   |  1 +
 4 files changed, 94 insertions(+)
 create mode 100644 test-tool/0161_readcapacity16_alloclen.c

diff --git a/Makefile.am b/Makefile.am
index dcdf9cb..f8f0e62 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -65,6 +65,7 @@ bin_iscsi_test_SOURCES = test-tool/iscsi-test.c \
 	test-tool/0130_verify10_simple.c test-tool/0131_verify10_mismatch.c \
 	test-tool/0132_verify10_mismatch_no_cmp.c test-tool/0133_verify10_beyondeol.c \
 	test-tool/0160_readcapacity16_simple.c \
+	test-tool/0161_readcapacity16_alloclen.c \
 	test-tool/0170_unmap_simple.c test-tool/0171_unmap_zero.c \
 	test-tool/0180_writesame10_unmap.c test-tool/0181_writesame10_unmap_unaligned.c \
 	test-tool/0182_writesame10_beyondeol.c \
diff --git a/test-tool/0161_readcapacity16_alloclen.c b/test-tool/0161_readcapacity16_alloclen.c
new file mode 100644
index 0000000..6f31f98
--- /dev/null
+++ b/test-tool/0161_readcapacity16_alloclen.c
@@ -0,0 +1,91 @@
+/* 
+   Copyright (C) 2010 by Ronnie Sahlberg <ronniesahlberg@gmail.com>
+   
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+   
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+   
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include "iscsi.h"
+#include "iscsi-private.h"
+#include "scsi-lowlevel.h"
+#include "iscsi-test.h"
+
+int T0161_readcapacity16_alloclen(const char *initiator, const char *url, int data_loss _U_, int show_info)
+{ 
+	struct iscsi_context *iscsi;
+	struct scsi_task *task;
+	struct iscsi_data data;
+	int ret, lun;
+
+	printf("0161_readcapacity16_alloclen:\n");
+	printf("=======================\n");
+	if (show_info) {
+		printf("Test allocation-length for READCAPACITY16\n");
+		printf("1, Readcapacity with alloclen==0 is not an error\n");
+		printf("\n");
+		return 0;
+	}
+
+	iscsi = iscsi_context_login(initiator, url, &lun);
+	if (iscsi == NULL) {
+		printf("Failed to login to target\n");
+		return -1;
+	}
+
+	ret = 0;
+
+
+	printf("READCAPACITY16 with AllocationLength==0 ... ");
+
+	task = malloc(sizeof(struct scsi_task));
+	if (task == NULL) {
+		printf("Failed to allocate task structure\n");
+		ret = -1;
+		goto finished;
+	}
+
+	memset(task, 0, sizeof(struct scsi_task));
+	task->cdb[0] = 0x9e;
+	task->cdb[1] = 0x10;
+	task->cdb_size = 16;
+	task->xfer_dir = SCSI_XFER_NONE;
+	task->expxferlen = 0;
+
+	if (iscsi_scsi_command_sync(iscsi, lun, task, NULL) == NULL) {
+	        printf("[FAILED]\n");
+		printf("Failed to send READCAPACITY16 command: %s\n", iscsi_get_error(iscsi));
+		ret = -1;
+
+		goto test2;
+	}
+	if (task->status != SCSI_STATUS_GOOD) {
+	        printf("[FAILED]\n");
+		printf("READCAPACITY16 with AllocationLength==0 should not fail. Sense:%s\n", iscsi_get_error(iscsi));
+		ret = -1;
+		scsi_free_scsi_task(task);
+		goto test2;
+	}
+	scsi_free_scsi_task(task);
+	printf("[OK]\n");
+
+
+test2:
+
+finished:
+	iscsi_logout_sync(iscsi);
+	iscsi_destroy_context(iscsi);
+	return ret;
+}
diff --git a/test-tool/iscsi-test.c b/test-tool/iscsi-test.c
index 81bd398..5d7d365 100644
--- a/test-tool/iscsi-test.c
+++ b/test-tool/iscsi-test.c
@@ -70,6 +70,7 @@ struct scsi_test tests[] = {
 
 /* readcapacity16*/
 { "T0160_readcapacity16_simple",	T0160_readcapacity16_simple },
+{ "T0161_readcapacity16_alloclen",	T0161_readcapacity16_alloclen },
 
 /* unmap*/
 { "T0170_unmap_simple",			T0170_unmap_simple },
diff --git a/test-tool/iscsi-test.h b/test-tool/iscsi-test.h
index d0ed7e2..2bb8540 100644
--- a/test-tool/iscsi-test.h
+++ b/test-tool/iscsi-test.h
@@ -48,6 +48,7 @@ int T0132_verify10_mismatch_no_cmp(const char *initiator, const char *url, int d
 int T0133_verify10_beyondeol(const char *initiator, const char *url, int data_loss, int show_info);
 
 int T0160_readcapacity16_simple(const char *initiator, const char *url, int data_loss, int show_info);
+int T0161_readcapacity16_alloclen(const char *initiator, const char *url, int data_loss, int show_info);
 
 int T0170_unmap_simple(const char *initiator, const char *url, int data_loss, int show_info);
 int T0171_unmap_zero(const char *initiator, const char *url, int data_loss, int show_info);