admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

ERROR fix error string creation

Browse Source 
At some points in the code the error string includes itself. This
generates self-repeating error messages.
This commit is contained in:
Peter Lieven
2012-10-30 16:38:09 +01:00
parent 820410526e
commit a0fb2d179d
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/init.c
View File

@@ -243,13 +243,15 @@ void
iscsi_set_error(struct iscsi_context *iscsi, const char *error_string, ...) iscsi_set_error(struct iscsi_context *iscsi, const char *error_string, ...)
{ {
va_list ap; va_list ap;
char errstr[MAX_STRING_SIZE+1] = {0};
va_start(ap, error_string); va_start(ap, error_string);
if (vsnprintf(iscsi->error_string, MAX_STRING_SIZE, error_string, ap) < 0) { if (vsnprintf(errstr, MAX_STRING_SIZE, error_string, ap) < 0) {
strncpy(iscsi->error_string,"could not format error string!",MAX_STRING_SIZE); strncpy(errstr,"could not format error string!",MAX_STRING_SIZE);
} }
va_end(ap); va_end(ap);
strncpy(iscsi->error_string,errstr,MAX_STRING_SIZE);
DPRINTF(iscsi,1,"%s",iscsi->error_string); DPRINTF(iscsi,1,"%s",iscsi->error_string);
} }