admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

lib/iser.c: fix overflow_data_size NULL ptr dereference

Browse Source 
Discovered this while running iSCSI.iSCSITMF AbortTaskSimpleAsync
test case. For Task Management command iser_pdu->iscsi_pdu.scsi_cbdata
is not set. When test case tries to send Task Management command
via common API iser_send_command() - it calls overflow_data_size
which tries to dereference scsi_cbdata leading to SEGFAULT.

Added a non-NULL check for scsi_cbdata before accessing it.
This commit is contained in:
Sumit Rai
2019-06-20 10:15:11 +05:30
parent 29df7d8171
commit a664ca8c43
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/iser.c
View File

@@ -624,6 +624,9 @@ overflow_data_size(struct iser_pdu *iser_pdu)
{ {
int data_size; int data_size;
if (!iser_pdu->iscsi_pdu.scsi_cbdata.task) {
return 0;
}
data_size = iser_pdu->iscsi_pdu.scsi_cbdata.task->expxferlen; data_size = iser_pdu->iscsi_pdu.scsi_cbdata.task->expxferlen;
return (data_size > DATA_BUFFER_SIZE); return (data_size > DATA_BUFFER_SIZE);