From a6fc65b4ef7b934fa5ff3b91980cca4f47d41d13 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Sun, 1 May 2016 12:35:29 -0700 Subject: [PATCH] Tests: remove the warning if a SSD supports SANITIZE/OVERWRITE There is technically no reason why a SSD with (assumingly with thin provisioning) can not support SANITIZE/OVERWRITE instead or or in addition to the more expected SANITIZE/BLOCK-ERASE so remove the warning for this. Signed-off-by: Ronnie Sahlberg --- include/scsi-lowlevel.h | 2 ++ lib/scsi-lowlevel.c | 4 ++++ test-tool/test_sanitize_overwrite.c | 4 ---- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/scsi-lowlevel.h b/include/scsi-lowlevel.h index adb1be1..4a32d1f 100644 --- a/include/scsi-lowlevel.h +++ b/include/scsi-lowlevel.h @@ -563,6 +563,8 @@ struct scsi_inquiry_block_limits { uint32_t max_atomic_xfer_len; uint32_t atomic_align; uint32_t atomic_gran; + uint32_t max_atomic_tl_with_atomic_boundary; + uint32_t max_atomic_boundary_size; }; struct scsi_inquiry_block_device_characteristics { diff --git a/lib/scsi-lowlevel.c b/lib/scsi-lowlevel.c index 2e5e495..0737d8d 100644 --- a/lib/scsi-lowlevel.c +++ b/lib/scsi-lowlevel.c @@ -1428,6 +1428,10 @@ scsi_inquiry_unmarshall_block_limits(struct scsi_task *task) inq->max_atomic_xfer_len = task_get_uint32(task, 44); inq->atomic_align = task_get_uint32(task, 48); inq->atomic_gran = task_get_uint32(task, 52); + inq->max_atomic_tl_with_atomic_boundary = + task_get_uint32(task, 56); + inq->max_atomic_boundary_size = + task_get_uint32(task, 60); return inq; } diff --git a/test-tool/test_sanitize_overwrite.c b/test-tool/test_sanitize_overwrite.c index 7dd4534..d74eac4 100644 --- a/test-tool/test_sanitize_overwrite.c +++ b/test-tool/test_sanitize_overwrite.c @@ -86,10 +86,6 @@ test_sanitize_overwrite(void) "or a SSD device."); if (inq_bdc && inq_bdc->medium_rotation_rate == 0) { logging(LOG_NORMAL, "This is a HDD device"); - logging(LOG_NORMAL, "[WARNING] SANITIZE OVERWRITE opcode is " - "supported but MediumRotationRate is 0 " - "indicating that this is an SSD. Only HDDs should " - "implement OVERWRITE"); } else { logging(LOG_NORMAL, "This is a SSD device"); }