From b73e91c89a003eaa08636327e3b50353341e4ee5 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Sat, 29 Jun 2013 12:10:43 -0700 Subject: [PATCH] Don't use -Wwrite-strings on Solaris They have a weirdass struct option {} so we can't use this warning. --- configure.ac | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6dce230..7f26910 100644 --- a/configure.ac +++ b/configure.ac @@ -11,14 +11,27 @@ AC_CANONICAL_HOST AM_CONDITIONAL(LD_ISCSI, [expr "$host_os" : linux > /dev/null 2>&1]) +enable_write_strings="yes" + +case $host in + *solaris*) + enable_write_strings="no" + ;; + *) + ;; +esac + AC_ARG_ENABLE([werror], [AS_HELP_STRING([--disable-werror], [Disables building with -Werror by default])]) if test "$ac_cv_prog_gcc" = yes; then - WARN_CFLAGS="-Wall -W -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-align -Wwrite-strings -Wno-strict-aliasing" + WARN_CFLAGS="-Wall -W -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-align -Wno-strict-aliasing" if test "x$enable_werror" != "xno"; then WARN_CFLAGS="$WARN_CFLAGS -Werror" fi + if test "x$enable_write_strings" != "xno"; then + WARN_CFLAGS="$WARN_CFLAGS -Wwrite-strings" + fi fi AC_SUBST(WARN_CFLAGS)