admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

TEST: Add a test that is cmdsn is too low the target just ignores the pdu

Browse Source
This commit is contained in:
Ronnie Sahlberg
2013-04-30 19:05:23 -07:00
parent 325360789e
commit b7dd6b533b
9 changed files with 135 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test-tool/iscsi-test-cu.c
View File

@@ -432,6 +432,7 @@ static CU_SuiteInfo scsi_suites[] = {
static CU_TestInfo tests_iscsi_cmdsn[] = {
{ (char *)"iSCSICmdSnTooHigh", test_iscsi_cmdsn_toohigh },
{ (char *)"iSCSICmdSnTooLow", test_iscsi_cmdsn_toolow },
CU_TEST_INFO_NULL
};

1
test-tool/iscsi-test-cu.h
View File

@@ -50,6 +50,7 @@ void test_inquiry_supported_vpd(void);
void test_inquiry_mandatory_vpd_sbc(void);
void test_iscsi_cmdsn_toohigh(void);
void test_iscsi_cmdsn_toolow(void);
void test_mandatory_sbc(void);

9
test-tool/test_iscsi_cmdsn_toohigh.c
View File

@@ -35,6 +35,10 @@ static int my_iscsi_queue_pdu(struct iscsi_context *iscsi, struct iscsi_pdu *pdu
old_cmdsn = *(uint32_t *)&pdu->outdata.data[24];
/* change the cmdsn so it becomes too big */
*(uint32_t *)&pdu->outdata.data[24] = htonl(iscsi->maxcmdsn + 1);
/* fudge the cmdsn value back to where it should be if this
* pdu is ignored.
*/
iscsi->cmdsn--;
break;
case 2:
*(uint32_t *)&pdu->outdata.data[24] = old_cmdsn;
@@ -60,8 +64,8 @@ void test_iscsi_cmdsn_toohigh(void)
iscsic->target_max_recv_data_segment_length = block_size;
local_iscsi_queue_pdu = my_iscsi_queue_pdu;
change_cmdsn = 1;
/* we dont want autoreconnect since some targets will drop the
* connection on this condition.
/* we dont want autoreconnect since some targets will incorrectly
* drop the connection on this condition.
*/
iscsi_set_noautoreconnect(iscsic, 1);
iscsi_set_timeout(iscsic, 3);
@@ -75,7 +79,6 @@ void test_iscsi_cmdsn_toohigh(void)
}
iscsi_set_noautoreconnect(iscsic, 0);
logging(LOG_VERBOSE, "Send a TESTUNITREADY with CMDSN == EXPCMDSN. should work again");
change_cmdsn = 2;

89
test-tool/test_iscsi_cmdsn_toolow.c Normal file
View File

@@ -0,0 +1,89 @@
/*
Copyright (C) 2013 by Ronnie Sahlberg <ronniesahlberg@gmail.com>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
#include <stdio.h>
#include <arpa/inet.h>
#include <CUnit/CUnit.h>
#include "iscsi.h"
#include "iscsi-private.h"
#include "scsi-lowlevel.h"
#include "iscsi-test-cu.h"
static int change_cmdsn;
static int my_iscsi_queue_pdu(struct iscsi_context *iscsi, struct iscsi_pdu *pdu)
{
static uint32_t old_cmdsn;
switch (change_cmdsn) {
case 1:
old_cmdsn = *(uint32_t *)&pdu->outdata.data[24];
/* change the cmdsn so it becomes too big */
*(uint32_t *)&pdu->outdata.data[24] = htonl(iscsi->expcmdsn + 1);
/* fudge the cmdsn value back to where it should be if this
* pdu is ignored.
*/
iscsi->cmdsn--;
break;
case 2:
*(uint32_t *)&pdu->outdata.data[24] = old_cmdsn;
break;
}
change_cmdsn = 0;
return 0;
}
void test_iscsi_cmdsn_toolow(void)
{
int ret;
logging(LOG_VERBOSE, LOG_BLANK_LINE);
logging(LOG_VERBOSE, "Test sending invalid iSCSI CMDSN");
logging(LOG_VERBOSE, "CMDSN MUST be in the range EXPCMDSN and MAXCMDSN");
logging(LOG_VERBOSE, "RFC3720:3.2.2.1 CMDSN < EXPCMDSN must be silently ignored by the target");
logging(LOG_VERBOSE, "Send a TESTUNITREADY with CMDSN == EXPCMDSN-1. Should be ignored by the target.");
iscsic->use_immediate_data = ISCSI_IMMEDIATE_DATA_NO;
iscsic->target_max_recv_data_segment_length = block_size;
local_iscsi_queue_pdu = my_iscsi_queue_pdu;
change_cmdsn = 1;
/* we dont want autoreconnect since some targets will incorrectly
* drop the connection on this condition.
*/
iscsi_set_noautoreconnect(iscsic, 1);
iscsi_set_timeout(iscsic, 3);
ret = testunitready(iscsic, tgt_lun);
CU_ASSERT_EQUAL(ret, -1);
if (ret == -1) {
logging(LOG_VERBOSE, "[SUCCESS] We did not receive a reply");
} else {
logging(LOG_VERBOSE, "[FAILURE] We got a response from the target but SMDSN was outside of the window.");
}
iscsi_set_noautoreconnect(iscsic, 0);
logging(LOG_VERBOSE, "Send a TESTUNITREADY with CMDSN == EXPCMDSN. should work again");
change_cmdsn = 2;
ret = testunitready(iscsic, tgt_lun);
CU_ASSERT_EQUAL(ret, 0);
}