admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Tests: Create helper macros for the WriteVerify* commands

Browse Source 
By creating a helper macros for WriteVerify we can save a lot of boilerplate
code.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
This commit is contained in:
Ronnie Sahlberg
2016-02-20 19:05:15 -08:00
parent 72cfdbb5f1
commit bd29dab95b
22 changed files with 169 additions and 341 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
test-tool/test_writeverify12_simple.c
View File

@@ -30,7 +30,7 @@
void
test_writeverify12_simple(void)
{
int i, ret;
int i;
unsigned char *buf = alloca(256 * block_size);
CHECK_FOR_DATALOSS;
@@ -42,15 +42,9 @@ test_writeverify12_simple(void)
if (maximum_transfer_length && maximum_transfer_length < i) {
break;
}
ret = writeverify12(sd, 0, i * block_size,
block_size, 0, 0, 0, 0, buf,
EXPECT_STATUS_GOOD);
if (ret == -2) {
logging(LOG_NORMAL, "[SKIPPED] WRITEVERIFY12 is not implemented.");
CU_PASS("WRITEVERIFY12 is not implemented.");
return;
}
CU_ASSERT_EQUAL(ret, 0);
WRITEVERIFY12(sd, 0, i * block_size,
block_size, 0, 0, 0, 0, buf,
EXPECT_STATUS_GOOD);
}
logging(LOG_VERBOSE, "Test WRITE12 of 1-256 blocks at the end of the LUN");
@@ -58,10 +52,8 @@ test_writeverify12_simple(void)
if (maximum_transfer_length && maximum_transfer_length < i) {
break;
}
ret = writeverify12(sd, num_blocks - i,
i * block_size, block_size, 0, 0, 0, 0, buf,
EXPECT_STATUS_GOOD);
CU_ASSERT_EQUAL(ret, 0);
WRITEVERIFY12(sd, num_blocks - i,
i * block_size, block_size, 0, 0, 0, 0, buf,
EXPECT_STATUS_GOOD);
}
}