admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

test-tool: Avoid that login failure causes a segmentation fault

Browse Source 
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
This commit is contained in:
Bart Van Assche
2015-10-06 13:51:20 -07:00
committed by Ronnie Sahlberg
parent 5532325042
commit e9536d3333
11 changed files with 43 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test-tool/test_preventallow_2_itnexuses.c
View File

@@ -62,6 +62,8 @@ test_preventallow_2_itnexuses(void)
logging(LOG_VERBOSE, "Create a second connection to the target"); logging(LOG_VERBOSE, "Create a second connection to the target");
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
logging(LOG_VERBOSE, "Try to eject the medium on the second connection"); logging(LOG_VERBOSE, "Try to eject the medium on the second connection");
ret = startstopunit(sd2, 0, 0, 0, 0, 1, 0, ret = startstopunit(sd2, 0, 0, 0, 0, 1, 0,

3
test-tool/test_prout_preempt.c
View File

@@ -70,6 +70,9 @@ test_prout_preempt_rm_reg(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
/* register secondary key */ /* register secondary key */
ret = prout_register_and_ignore(sd2, k2); ret = prout_register_and_ignore(sd2, k2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);

12
test-tool/test_prout_reserve_access.c
View File

@@ -135,6 +135,8 @@ test_prout_reserve_access_ea(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_access(sd, sd2, verify_persistent_reserve_access(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS, SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS,
0, 0, 0, 0); 0, 0, 0, 0);
@@ -157,6 +159,8 @@ test_prout_reserve_access_we(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_access(sd, sd2, verify_persistent_reserve_access(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE, SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE,
1, 0, 1, 0); 1, 0, 1, 0);
@@ -179,6 +183,8 @@ test_prout_reserve_access_earo(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_access(sd, sd2, verify_persistent_reserve_access(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS_REGISTRANTS_ONLY, SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS_REGISTRANTS_ONLY,
1, 1, 0, 0); 1, 1, 0, 0);
@@ -201,6 +207,8 @@ test_prout_reserve_access_wero(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_access(sd, sd2, verify_persistent_reserve_access(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE_REGISTRANTS_ONLY, SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE_REGISTRANTS_ONLY,
1, 1, 1, 0); 1, 1, 1, 0);
@@ -223,6 +231,8 @@ test_prout_reserve_access_eaar(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_access(sd, sd2, verify_persistent_reserve_access(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS_ALL_REGISTRANTS, SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS_ALL_REGISTRANTS,
1, 1, 0, 0); 1, 1, 0, 0);
@@ -245,6 +255,8 @@ test_prout_reserve_access_wear(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_access(sd, sd2, verify_persistent_reserve_access(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE_ALL_REGISTRANTS, SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE_ALL_REGISTRANTS,
1, 1, 1, 0); 1, 1, 1, 0);

12
test-tool/test_prout_reserve_ownership.c
View File

@@ -109,6 +109,8 @@ test_prout_reserve_ownership_ea(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_ownership(sd, sd2, verify_persistent_reserve_ownership(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS, 0); SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS, 0);
mpath_sd2_put(sd2); mpath_sd2_put(sd2);
@@ -130,6 +132,8 @@ test_prout_reserve_ownership_we(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_ownership(sd, sd2, verify_persistent_reserve_ownership(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE, 0); SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE, 0);
mpath_sd2_put(sd2); mpath_sd2_put(sd2);
@@ -151,6 +155,8 @@ test_prout_reserve_ownership_earo(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_ownership(sd, sd2, verify_persistent_reserve_ownership(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS_REGISTRANTS_ONLY, 0); SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS_REGISTRANTS_ONLY, 0);
mpath_sd2_put(sd2); mpath_sd2_put(sd2);
@@ -172,6 +178,8 @@ test_prout_reserve_ownership_wero(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_ownership(sd, sd2, verify_persistent_reserve_ownership(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE_REGISTRANTS_ONLY, 0); SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE_REGISTRANTS_ONLY, 0);
mpath_sd2_put(sd2); mpath_sd2_put(sd2);
@@ -193,6 +201,8 @@ test_prout_reserve_ownership_eaar(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_ownership(sd, sd2, verify_persistent_reserve_ownership(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS_ALL_REGISTRANTS, 1); SCSI_PERSISTENT_RESERVE_TYPE_EXCLUSIVE_ACCESS_ALL_REGISTRANTS, 1);
mpath_sd2_put(sd2); mpath_sd2_put(sd2);
@@ -214,6 +224,8 @@ test_prout_reserve_ownership_wear(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
verify_persistent_reserve_ownership(sd, sd2, verify_persistent_reserve_ownership(sd, sd2,
SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE_ALL_REGISTRANTS, 1); SCSI_PERSISTENT_RESERVE_TYPE_WRITE_EXCLUSIVE_ALL_REGISTRANTS, 1);
mpath_sd2_put(sd2); mpath_sd2_put(sd2);

2
test-tool/test_reserve6_2initiators.c
View File

@@ -58,6 +58,8 @@ test_reserve6_2initiators(void)
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
logging(LOG_NORMAL, "Try to take out a RESERVE6 from the second initiator"); logging(LOG_NORMAL, "Try to take out a RESERVE6 from the second initiator");
ret = reserve6_conflict(sd2); ret = reserve6_conflict(sd2);

2
test-tool/test_reserve6_itnexus_loss.c
View File

@@ -55,6 +55,8 @@ test_reserve6_itnexus_loss(void)
logging(LOG_VERBOSE, "Create a second connection to the target"); logging(LOG_VERBOSE, "Create a second connection to the target");
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
logging(LOG_NORMAL, "Try to take out a RESERVE6 from the second initiator"); logging(LOG_NORMAL, "Try to take out a RESERVE6 from the second initiator");
ret = reserve6_conflict(sd2); ret = reserve6_conflict(sd2);

2
test-tool/test_reserve6_logout.c
View File

@@ -55,6 +55,8 @@ test_reserve6_logout(void)
logging(LOG_VERBOSE, "Create a second connection to the target"); logging(LOG_VERBOSE, "Create a second connection to the target");
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
logging(LOG_NORMAL, "Try to take out a RESERVE6 from the second initiator"); logging(LOG_NORMAL, "Try to take out a RESERVE6 from the second initiator");
ret = reserve6_conflict(sd2); ret = reserve6_conflict(sd2);

2
test-tool/test_reserve6_target_cold_reset.c
View File

@@ -65,6 +65,8 @@ test_reserve6_target_cold_reset(void)
logging(LOG_VERBOSE, "Create a second connection to the target"); logging(LOG_VERBOSE, "Create a second connection to the target");
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
logging(LOG_VERBOSE, "RESERVE6 from the second initiator should work now"); logging(LOG_VERBOSE, "RESERVE6 from the second initiator should work now");
ret = reserve6(sd2); ret = reserve6(sd2);

2
test-tool/test_reserve6_target_warm_reset.c
View File

@@ -66,6 +66,8 @@ test_reserve6_target_warm_reset(void)
logging(LOG_VERBOSE, "Create a second connection to the target"); logging(LOG_VERBOSE, "Create a second connection to the target");
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
logging(LOG_VERBOSE, "RESERVE6 from the second initiator should work now"); logging(LOG_VERBOSE, "RESERVE6 from the second initiator should work now");
ret = reserve6(sd2); ret = reserve6(sd2);

2
test-tool/test_sanitize_readonly.c
View File

@@ -52,6 +52,8 @@ test_sanitize_readonly(void)
logging(LOG_VERBOSE, "Create a second connection to the target"); logging(LOG_VERBOSE, "Create a second connection to the target");
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
logging(LOG_VERBOSE, "Set Software Write Protect on the second connection"); logging(LOG_VERBOSE, "Set Software Write Protect on the second connection");
ret = set_swp(sd2); ret = set_swp(sd2);

2
test-tool/test_sanitize_reservations.c
View File

@@ -52,6 +52,8 @@ test_sanitize_reservations(void)
logging(LOG_VERBOSE, "Create a second connection to the target"); logging(LOG_VERBOSE, "Create a second connection to the target");
ret = mpath_sd2_get_or_clone(sd, &sd2); ret = mpath_sd2_get_or_clone(sd, &sd2);
CU_ASSERT_EQUAL(ret, 0); CU_ASSERT_EQUAL(ret, 0);
if (ret < 0)
return;
logging(LOG_VERBOSE, "Take out a RESERVE6 from the second " logging(LOG_VERBOSE, "Take out a RESERVE6 from the second "
"initiator"); "initiator");