admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: use correct maximum length for TargetName and InitiatorName

Browse Source 
Signed-off-by: Peter Lieven <pl@dlhnet.de>
This commit is contained in:
Peter Lieven
2025-03-26 13:28:23 +00:00
parent 90036a167d
commit eb0853e36e
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/iscsi-private.h
View File

@@ -82,8 +82,8 @@ struct iscsi_context {
void *opaque; void *opaque;
enum iscsi_transport_type transport; enum iscsi_transport_type transport;
char initiator_name[MAX_STRING_SIZE+1]; char initiator_name[MAX_ISCSI_NAME_SIZE+1];
char target_name[MAX_STRING_SIZE+1]; char target_name[MAX_ISCSI_NAME_SIZE+1];
char target_address[MAX_STRING_SIZE+1]; /* If a redirect */ char target_address[MAX_STRING_SIZE+1]; /* If a redirect */
char connected_portal[MAX_STRING_SIZE+1]; char connected_portal[MAX_STRING_SIZE+1];
char portal[MAX_STRING_SIZE+1]; char portal[MAX_STRING_SIZE+1];

2
include/iscsi.h
View File

@@ -44,6 +44,8 @@ struct scsi_iovec;
#define LIBISCSI_FEATURE_ISER (1) #define LIBISCSI_FEATURE_ISER (1)
#define MAX_STRING_SIZE (255) #define MAX_STRING_SIZE (255)
/* RFC 3720 Section 3.2.6.1 */
#define MAX_ISCSI_NAME_SIZE (223)
/* /*
* Syntax for normal and portal/discovery URLs. * Syntax for normal and portal/discovery URLs.

4
lib/init.c
View File

@@ -222,7 +222,7 @@ iscsi_create_context(const char *initiator_name)
return NULL; return NULL;
} }
strncpy(iscsi->initiator_name,initiator_name,MAX_STRING_SIZE); strncpy(iscsi->initiator_name,initiator_name,MAX_ISCSI_NAME_SIZE);
iscsi->fd = -1; iscsi->fd = -1;
@@ -386,7 +386,7 @@ iscsi_set_targetname(struct iscsi_context *iscsi, const char *target_name)
return -1; return -1;
} }
strncpy(iscsi->target_name,target_name,MAX_STRING_SIZE); strncpy(iscsi->target_name,target_name,MAX_ISCSI_NAME_SIZE);
return 0; return 0;
} }