From ec4266392ebc889ddc344784a76e3e41c39afa69 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Tue, 24 Feb 2015 07:01:20 -0800 Subject: [PATCH] connect.c: improve comment in reconnect code that we ONLY requeue SCSI COMMAND The only PDU type that does not have ISCSI_PDU_DROP_ON_RECONNECT is the SCSI COMMAND PDU. Thsi is the only PDU that we re-queue on reconnect. All other, including DATA-OUT, NOP, task management, PDUs are simply dropped. Signed-off-by: Ronnie Sahlberg --- lib/connect.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/connect.c b/lib/connect.c index 39ca909..204d0b2 100644 --- a/lib/connect.c +++ b/lib/connect.c @@ -343,9 +343,9 @@ try_again: if (pdu->flags & ISCSI_PDU_DROP_ON_RECONNECT) { /* - * We don't want to requeue NOPs or DATA-OUT PDUs. - * Any DATA-OUTs we need will be regenerated when we - * call iscsi_scsi_command_async() below. + * We only want to re-queue SCSI COMMAND PDUs. + * All other PDUs are discarded at this point. + * This includes DATA-OUT, NOP and task management. */ iscsi_free_pdu(old_iscsi, pdu); continue;