From f49a1beb16e64c9f66e9199366a64c6807b9f8f8 Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg Date: Mon, 13 May 2013 20:03:56 -0700 Subject: [PATCH] TEST: Add test for the protection information setting in READCAPACITY16 If the device does not support PI (INQ->PROTECT) then verify that PROT_EN, P_TYPE and P_I_EXP are all zero. If the device does support PI and IF PROT_EN is clear then verify that both P_TYPE and P_I_EXP are zero. If the device does support PI and IF PROT_EN is set then verify that P_TYPE is 0, 1 or 2 --- Makefile.am | 3 +- test-tool/iscsi-test-cu.c | 1 + test-tool/iscsi-test-cu.h | 3 +- test-tool/test_readcapacity16_protection.c | 112 +++++++++++++++++++++ 4 files changed, 117 insertions(+), 2 deletions(-) create mode 100644 test-tool/test_readcapacity16_protection.c diff --git a/Makefile.am b/Makefile.am index 7aeb549..645ae68 100644 --- a/Makefile.am +++ b/Makefile.am @@ -251,8 +251,9 @@ bin_iscsi_test_cu_SOURCES = test-tool/iscsi-test-cu.c \ test-tool/test_read16_flags.c \ test-tool/test_read16_residuals.c \ test-tool/test_readcapacity10_simple.c \ - test-tool/test_readcapacity16_simple.c \ test-tool/test_readcapacity16_alloclen.c \ + test-tool/test_readcapacity16_protection.c \ + test-tool/test_readcapacity16_simple.c \ test-tool/test_readonly_sbc.c \ test-tool/test_reserve6_simple.c \ test-tool/test_reserve6_2initiators.c \ diff --git a/test-tool/iscsi-test-cu.c b/test-tool/iscsi-test-cu.c index 69dd257..620a768 100644 --- a/test-tool/iscsi-test-cu.c +++ b/test-tool/iscsi-test-cu.c @@ -212,6 +212,7 @@ static CU_TestInfo tests_readcapacity10[] = { static CU_TestInfo tests_readcapacity16[] = { { (char *)"ReadCapacity16Simple", test_readcapacity16_simple }, { (char *)"ReadCapacity16Alloclen", test_readcapacity16_alloclen }, + { (char *)"ReadCapacity16PI", test_readcapacity16_protection }, CU_TEST_INFO_NULL }; diff --git a/test-tool/iscsi-test-cu.h b/test-tool/iscsi-test-cu.h index 3c64d8d..af961a5 100644 --- a/test-tool/iscsi-test-cu.h +++ b/test-tool/iscsi-test-cu.h @@ -132,8 +132,9 @@ void test_read16_residuals(void); void test_readcapacity10_simple(void); -void test_readcapacity16_simple(void); void test_readcapacity16_alloclen(void); +void test_readcapacity16_protection(void); +void test_readcapacity16_simple(void); void test_readonly_sbc(void); diff --git a/test-tool/test_readcapacity16_protection.c b/test-tool/test_readcapacity16_protection.c new file mode 100644 index 0000000..54e0ea3 --- /dev/null +++ b/test-tool/test_readcapacity16_protection.c @@ -0,0 +1,112 @@ +/* + Copyright (C) 2013 by Ronnie Sahlberg + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, see . +*/ + +#include + +#include + +#include "iscsi.h" +#include "scsi-lowlevel.h" +#include "iscsi-support.h" +#include "iscsi-test-cu.h" + + +void +test_readcapacity16_protection(void) +{ + logging(LOG_VERBOSE, LOG_BLANK_LINE); + logging(LOG_VERBOSE, "Test READCAPACITY16 Protection Information"); + + CHECK_FOR_SBC; + + if (rc16 == NULL) { + logging(LOG_NORMAL, "[SKIPPED] READCAPACITY16 is not implemented on this target."); + CU_PASS("READCAPACITY16 is not implemented."); + return; + } + + if (!inq->protect) { + logging(LOG_VERBOSE, "This device does not support PI. " + "Verify that all relevant fields in READCAPACITY16 " + "are 0"); + + logging(LOG_VERBOSE, "Verify that PROT_EN is 0"); + if (rc16->prot_en) { + logging(LOG_VERBOSE, "[FAILED] PROT_EN is set but " + "the device does not claim support for " + "protection information in the standard " + "inquiry VPD."); + } + CU_ASSERT_EQUAL(rc16->prot_en, 0); + + logging(LOG_VERBOSE, "Verify that P_TYPE is 0"); + if (rc16->p_type) { + logging(LOG_VERBOSE, "[FAILED] P_TYPE is non-zero but " + "the device does not claim support for " + "protection information in the standard " + "inquiry VPD."); + } + CU_ASSERT_EQUAL(rc16->p_type, 0); + + logging(LOG_VERBOSE, "Verify that P_I_EXP is 0"); + if (rc16->p_i_exp) { + logging(LOG_VERBOSE, "[FAILED] P_I_EXP is non-zero but " + "the device does not claim support for " + "protection information in the standard " + "inquiry VPD."); + } + CU_ASSERT_EQUAL(rc16->p_i_exp, 0); + + return; + } + + logging(LOG_VERBOSE, "This device supports PI. " + "Verify that all relevant fields are sane"); + if (!rc16->prot_en) { + logging(LOG_VERBOSE, "Protection is not enabled. Verify " + "that all relevant fields are zero"); + + logging(LOG_VERBOSE, "Verify that P_TYPE is 0"); + if (rc16->p_type) { + logging(LOG_VERBOSE, "[FAILED] P_TYPE is non-zero but " + "protection information is not enabled."); + } + CU_ASSERT_EQUAL(rc16->p_type, 0); + + logging(LOG_VERBOSE, "Verify that P_I_EXP is 0"); + if (rc16->p_i_exp) { + logging(LOG_VERBOSE, "[FAILED] P_I_EXP is non-zero but " + "protection information is not enabled"); + } + CU_ASSERT_EQUAL(rc16->p_i_exp, 0); + + return; + } + + logging(LOG_VERBOSE, "Protection is enabled. Verify " + "that all relevant fields are sane"); + switch (rc16->p_type) { + case 0: + case 1: + case 2: + break; + default: + logging(LOG_VERBOSE, "[FAILED] P_TYPE is invalid. Must be " + "0,1,2 but was %d", rc16->p_type); + CU_FAIL("P_TYPE is invalid"); + } +}