Tests: Create a global scratch buffer and avoid allocating memory in the tests

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
This commit is contained in:
Ronnie Sahlberg
2016-02-21 07:56:47 -08:00
parent b4e4649ae5
commit f88bcf61cc
89 changed files with 454 additions and 545 deletions

View File

@@ -34,7 +34,6 @@ test_write12_dpofua(void)
struct scsi_mode_sense *ms;
struct scsi_task *rso_task = NULL;
struct scsi_report_supported_op_codes_one_command *rsoc;
unsigned char *buf = alloca(block_size);
logging(LOG_VERBOSE, LOG_BLANK_LINE);
logging(LOG_VERBOSE, "Test WRITE12 DPO/FUA flags");
@@ -61,30 +60,30 @@ test_write12_dpofua(void)
}
logging(LOG_VERBOSE, "Test WRITE12 with DPO==1");
memset(buf, 0xa6, block_size);
memset(scratch, 0xa6, block_size);
if (dpofua) {
WRITE12(sd, 0, block_size, block_size, 0, 1, 0, 0, 0, buf,
WRITE12(sd, 0, block_size, block_size, 0, 1, 0, 0, 0, scratch,
EXPECT_STATUS_GOOD);
} else {
WRITE12(sd, 0, block_size, block_size, 0, 1, 0, 0, 0, buf,
WRITE12(sd, 0, block_size, block_size, 0, 1, 0, 0, 0, scratch,
EXPECT_INVALID_FIELD_IN_CDB);
}
logging(LOG_VERBOSE, "Test WRITE12 with FUA==1");
if (dpofua) {
WRITE12(sd, 0, block_size, block_size, 0, 0, 1, 0, 0, buf,
WRITE12(sd, 0, block_size, block_size, 0, 0, 1, 0, 0, scratch,
EXPECT_STATUS_GOOD);
} else {
WRITE12(sd, 0, block_size, block_size, 0, 0, 1, 0, 0, buf,
WRITE12(sd, 0, block_size, block_size, 0, 0, 1, 0, 0, scratch,
EXPECT_INVALID_FIELD_IN_CDB);
}
logging(LOG_VERBOSE, "Test WRITE12 with DPO==1 FUA==1");
if (dpofua) {
WRITE12(sd, 0, block_size, block_size, 0, 1, 1, 0, 0, buf,
WRITE12(sd, 0, block_size, block_size, 0, 1, 1, 0, 0, scratch,
EXPECT_STATUS_GOOD);
} else {
WRITE12(sd, 0, block_size, block_size, 0, 1, 1, 0, 0, buf,
WRITE12(sd, 0, block_size, block_size, 0, 1, 1, 0, 0, scratch,
EXPECT_INVALID_FIELD_IN_CDB);
}