Tests: Create a global scratch buffer and avoid allocating memory in the tests
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
This commit is contained in:
@@ -32,7 +32,6 @@ test_writesame10_unmap(void)
|
||||
{
|
||||
int ret;
|
||||
unsigned int i;
|
||||
unsigned char *buf = alloca(256 * block_size);
|
||||
|
||||
CHECK_FOR_DATALOSS;
|
||||
CHECK_FOR_THIN_PROVISIONING;
|
||||
@@ -42,17 +41,18 @@ test_writesame10_unmap(void)
|
||||
logging(LOG_VERBOSE, LOG_BLANK_LINE);
|
||||
logging(LOG_VERBOSE, "Test WRITESAME10 of 1-256 blocks at the start of "
|
||||
"the LUN");
|
||||
memset(buf, 0xa6, 256 * block_size);
|
||||
memset(scratch, 0xa6, 256 * block_size);
|
||||
for (i = 1; i <= 256; i++) {
|
||||
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
||||
memset(buf, 0xff, i * block_size);
|
||||
WRITE10(sd, 0, i * block_size, block_size, 0, 0, 0, 0, 0, buf,
|
||||
memset(scratch, 0xff, i * block_size);
|
||||
WRITE10(sd, 0, i * block_size, block_size,
|
||||
0, 0, 0, 0, 0, scratch,
|
||||
EXPECT_STATUS_GOOD);
|
||||
|
||||
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME10", i);
|
||||
memset(buf, 0, block_size);
|
||||
memset(scratch, 0, block_size);
|
||||
ret = writesame10(sd, 0,
|
||||
block_size, i, 0, 1, 0, 0, buf,
|
||||
block_size, i, 0, 1, 0, 0, scratch,
|
||||
EXPECT_STATUS_GOOD);
|
||||
CU_ASSERT_EQUAL(ret, 0);
|
||||
|
||||
@@ -64,9 +64,9 @@ test_writesame10_unmap(void)
|
||||
"are now zero", i);
|
||||
ret = read10(sd, NULL, 0,
|
||||
i * block_size, block_size,
|
||||
0, 0, 0, 0, 0, buf,
|
||||
0, 0, 0, 0, 0, scratch,
|
||||
EXPECT_STATUS_GOOD);
|
||||
CU_ASSERT(all_zeroes(buf, i * block_size));
|
||||
CU_ASSERT(all_zeroes(scratch, i * block_size));
|
||||
} else {
|
||||
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
||||
"and verify zero test");
|
||||
@@ -78,15 +78,15 @@ test_writesame10_unmap(void)
|
||||
"the LUN");
|
||||
for (i = 1; i <= 256; i++) {
|
||||
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
||||
memset(buf, 0xff, i * block_size);
|
||||
memset(scratch, 0xff, i * block_size);
|
||||
WRITE10(sd, num_blocks - i,
|
||||
i * block_size, block_size, 0, 0, 0, 0, 0, buf,
|
||||
i * block_size, block_size, 0, 0, 0, 0, 0, scratch,
|
||||
EXPECT_STATUS_GOOD);
|
||||
|
||||
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME10", i);
|
||||
memset(buf, 0, block_size);
|
||||
memset(scratch, 0, block_size);
|
||||
ret = writesame10(sd, num_blocks - i,
|
||||
block_size, i, 0, 1, 0, 0, buf,
|
||||
block_size, i, 0, 1, 0, 0, scratch,
|
||||
EXPECT_STATUS_GOOD);
|
||||
CU_ASSERT_EQUAL(ret, 0);
|
||||
|
||||
@@ -98,9 +98,9 @@ test_writesame10_unmap(void)
|
||||
"are now zero", i);
|
||||
ret = read10(sd, NULL, num_blocks - i,
|
||||
i * block_size, block_size,
|
||||
0, 0, 0, 0, 0, buf,
|
||||
0, 0, 0, 0, 0, scratch,
|
||||
EXPECT_STATUS_GOOD);
|
||||
CU_ASSERT(all_zeroes(buf, i * block_size));
|
||||
CU_ASSERT(all_zeroes(scratch, i * block_size));
|
||||
} else {
|
||||
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
||||
"and verify zero test");
|
||||
@@ -110,7 +110,7 @@ test_writesame10_unmap(void)
|
||||
logging(LOG_VERBOSE, "Verify that WRITESAME10 ANCHOR==1 + UNMAP==0 is "
|
||||
"invalid");
|
||||
ret = writesame10(sd, 0,
|
||||
block_size, 1, 1, 0, 0, 0, buf,
|
||||
block_size, 1, 1, 0, 0, 0, scratch,
|
||||
EXPECT_INVALID_FIELD_IN_CDB);
|
||||
CU_ASSERT_EQUAL(ret, 0);
|
||||
|
||||
@@ -118,15 +118,15 @@ test_writesame10_unmap(void)
|
||||
|
||||
if (inq_lbp->anc_sup) {
|
||||
logging(LOG_VERBOSE, "Test WRITESAME10 ANCHOR==1 + UNMAP==0");
|
||||
memset(buf, 0, block_size);
|
||||
memset(scratch, 0, block_size);
|
||||
ret = writesame10(sd, 0,
|
||||
block_size, 1, 1, 1, 0, 0, buf,
|
||||
block_size, 1, 1, 1, 0, 0, scratch,
|
||||
EXPECT_STATUS_GOOD);
|
||||
} else {
|
||||
logging(LOG_VERBOSE, "Test WRITESAME10 ANCHOR==1 + UNMAP==0 no "
|
||||
"ANC_SUP so expecting to fail");
|
||||
ret = writesame10(sd, 0,
|
||||
block_size, 1, 1, 1, 0, 0, buf,
|
||||
block_size, 1, 1, 1, 0, 0, scratch,
|
||||
EXPECT_INVALID_FIELD_IN_CDB);
|
||||
}
|
||||
CU_ASSERT_EQUAL(ret, 0);
|
||||
@@ -149,15 +149,15 @@ test_writesame10_unmap(void)
|
||||
"lengths", i, i);
|
||||
|
||||
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
||||
memset(buf, 0xff, i * block_size);
|
||||
memset(scratch, 0xff, i * block_size);
|
||||
WRITE10(sd, 0,
|
||||
i * block_size, block_size, 0, 0, 0, 0, 0, buf,
|
||||
i * block_size, block_size, 0, 0, 0, 0, 0, scratch,
|
||||
EXPECT_STATUS_GOOD);
|
||||
|
||||
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME10", i);
|
||||
memset(buf, 0, block_size);
|
||||
memset(scratch, 0, block_size);
|
||||
ret = writesame10(sd, 0,
|
||||
block_size, i, 0, 1, 0, 0, buf,
|
||||
block_size, i, 0, 1, 0, 0, scratch,
|
||||
EXPECT_STATUS_GOOD);
|
||||
CU_ASSERT_EQUAL(ret, 0);
|
||||
|
||||
@@ -169,9 +169,9 @@ test_writesame10_unmap(void)
|
||||
"are now zero", i);
|
||||
ret = read10(sd, NULL, 0,
|
||||
i * block_size, block_size,
|
||||
0, 0, 0, 0, 0, buf,
|
||||
0, 0, 0, 0, 0, scratch,
|
||||
EXPECT_STATUS_GOOD);
|
||||
CU_ASSERT(all_zeroes(buf, i * block_size));
|
||||
CU_ASSERT(all_zeroes(scratch, i * block_size));
|
||||
} else {
|
||||
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
||||
"and verify zero test");
|
||||
@@ -183,7 +183,7 @@ test_writesame10_unmap(void)
|
||||
|
||||
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME10", i);
|
||||
ret = writesame10(sd, 0,
|
||||
block_size, i, 0, 1, 0, 0, buf,
|
||||
block_size, i, 0, 1, 0, 0, scratch,
|
||||
EXPECT_INVALID_FIELD_IN_CDB);
|
||||
CU_ASSERT_EQUAL(ret, 0);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user