Tests: Create a global scratch buffer and avoid allocating memory in the tests

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
This commit is contained in:
Ronnie Sahlberg
2016-02-21 07:56:47 -08:00
parent b4e4649ae5
commit f88bcf61cc
89 changed files with 454 additions and 545 deletions

View File

@@ -34,7 +34,6 @@ test_writeverify10_dpo(void)
struct scsi_mode_sense *ms;
struct scsi_task *rso_task = NULL;
struct scsi_report_supported_op_codes_one_command *rsoc;
unsigned char *buf = alloca(block_size);
logging(LOG_VERBOSE, LOG_BLANK_LINE);
logging(LOG_VERBOSE, "Test WRITEVERIFY10 DPO flag");
@@ -42,7 +41,7 @@ test_writeverify10_dpo(void)
CHECK_FOR_SBC;
ret = read10(sd, NULL, 0, block_size,
block_size, 0, 0, 0, 0, 0, buf,
block_size, 0, 0, 0, 0, 0, scratch,
EXPECT_STATUS_GOOD);
CU_ASSERT_EQUAL(ret, 0);
@@ -67,11 +66,11 @@ test_writeverify10_dpo(void)
logging(LOG_VERBOSE, "Test WRITEVERIFY10 with DPO==1");
if (dpofua) {
WRITEVERIFY10(sd, 0, block_size,
block_size, 0, 1, 0, 0, buf,
block_size, 0, 1, 0, 0, scratch,
EXPECT_STATUS_GOOD);
} else {
WRITEVERIFY10(sd, 0, block_size,
block_size, 0, 1, 0, 0, buf,
block_size, 0, 1, 0, 0, scratch,
EXPECT_INVALID_FIELD_IN_CDB);
}