admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
1,975 Commits 1 Branch 0 Tags
33c66f2c39a01b4e109270ffcc83e2e2daf73ecb
Commit Graph

27 Commits

Author SHA1 Message Date
shawn
dfff7e9d16 specify number of blocks in write_same command 
If "number of blocks" is 0, write_same will not erase the LBA range and
read-verify will fail.
 2020-03-03 17:31:50 -08:00
Tim Crawford
9347cfebf2 Replace file variables with .dir-locals.el 
Signed-off-by: Tim Crawford <tcrawford@datto.com>
 2019-02-21 11:54:02 -05:00
David Disseldorp
dc0c3c76c0 test_writesame_unmap_until_end: fix unsupported fallback 
2e947cc1de added logic to check that
targets missing zero block writesame support return INVALID_FIELD_IN_CDB
to such requests. However, this change incorrectly set the writesame
number_of_logical_blocks field to one.

Signed-off-by: David Disseldorp <ddiss@suse.de>
 2017-12-20 17:54:18 +01:00
Ronnie Sahlberg
2e947cc1de TESTS: WRITESAME1* with 0 DataOut should fail if WSNZ is set 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2016-09-22 18:44:44 -07:00
Ronnie Sahlberg
875c0222f2 Revert "TESTS: Fix writesame1* unmap until end tests" 
This reverts commit 6aa8c17b59.
 2016-09-22 06:26:12 -07:00
Ronnie Sahlberg
6aa8c17b59 TESTS: Fix writesame1* unmap until end tests 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2016-09-21 19:05:15 -07:00
Ronnie Sahlberg
8a44851128 Tests: Add a helper for the all_zero checker 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2016-02-23 19:26:15 -08:00
Ronnie Sahlberg
b4320bd76c Tests: convert tabs to 8 spaces 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2016-02-21 16:17:18 -08:00
Ronnie Sahlberg
c48283fe75 Tests: add helpers for read* 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2016-02-21 15:45:23 -08:00
Ronnie Sahlberg
0b5b724f17 Tests: Add helpers for WRITESAME 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2016-02-21 15:28:59 -08:00
Ronnie Sahlberg
f88bcf61cc Tests: Create a global scratch buffer and avoid allocating memory in the tests 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2016-02-21 15:17:43 -08:00
Ronnie Sahlberg
eba1ac059a Tests: Add helper macros for Write* 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2016-02-21 15:07:55 -08:00
Ronnie Sahlberg
99a5f99527 Add some emacs defaults. Tabs are 8 spaces. 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2016-02-18 21:34:43 -08:00
Bart Van Assche
2d412530c1 test-tool: Move all_zeroes() helper function to iscsi-support.c 
This patch does not change any functionality.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
 2015-10-07 07:44:18 -07:00
Chris Zankel
fff67ba7dd test_writesame*_0blocks: skip 0-block test if unsupported 
Skip 0-block WRITE SAME tests for targets that don't support these
operations, ie. they have write_same_no_zero (WSNZ) set in the
block limits vpd.

Also, fix the test:
  "Test WRITESAME10 of 1-256 blocks at the end of the LUN by setting
number-of-blocks==0"
to actually pass 0 blocks instead of the number of remaining blocks to the end.

Signed-off-by: Chris Zankel <chris@zankel.net>
 2015-04-23 17:36:38 -07:00
Ronnie Sahlberg
072291c852 TESTS: change the function signatures for the helpers 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-18 18:19:04 -07:00
Ronnie Sahlberg
9b768f7de9 TESTS: move the default url, lun and iscsi context into a structure 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-18 16:42:45 -07:00
Ronnie Sahlberg
832d88797a TESTS: remove the read10_task helper 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
28b0a0ab11 TESTS: update the READ tests to the new API 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 13:12:58 -07:00
Ronnie Sahlberg
8585e4509b TESTS: update writesame tests to new API 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:08:01 -07:00
Ronnie Sahlberg
8ffd78c117 temp: redo the write10/12/16 commands to the new saner api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:57 -07:00
Bart Van Assche
ded75ae18a Fix WRITE SAME data buffer length handling 
From the SPC-4 paragraph about WRITE SAME(10): "The WRITE SAME (10)
command requests that the device server transfer a single logical
block from the Data-Out Buffer [ ... ]". Hence always pass a data
buffer when sending a WRITE SAME(10) command.

Set the NDOB bit in the WRITE SAME(16) command if no data out buffer
is present.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
 2014-08-21 06:42:49 -07:00
Ronnie Sahlberg
e66b50f8ec tests: use alloca when allocating scratch buffer for writesame 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-05-20 17:52:23 -07:00
jpocas
b0c57802bc - test_unmap_simple: was assuming that zero buffer was already cleared, which is not guaranteed and resulted in spurious failures 
- writesame10_unmap_until_end, writesame16_unmap, writesame16_unmap_until_end were doing an CU_ASSERT *PER-BYTE* in the verification phase,
which was very CPU-intensive. This change uses memcmp on a whole block which finishes much quicker.
 2014-05-07 13:32:21 -04:00
Ronnie Sahlberg
8c22f8d986 TESTS: UNMAP/WRITESAME10/16 Check LBPRZ before we read the unmapped blocks and verify they are blank. 2013-05-15 17:10:20 -07:00
Lee Duncan
990af4a427 Added printf format checking to logging function. 
This also required changing the logging of "" at the
start of each test to appeal the otherwise-friendly
compiler.
 2013-02-13 18:04:51 -08:00
Ronnie Sahlberg
aefa88b724 TESTS: Add tests that WRITESAME10/16 UNMAP will unmap until end of the device when number-of-blocks is set to 0 2013-01-27 10:32:00 -08:00