admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
1,276 Commits 1 Branch 0 Tags
47d7e4b0acf3dd0912a8d406ffc8eff73be73ea7
Commit Graph

123 Commits

Author SHA1 Message Date
Ronnie Sahlberg
47d7e4b0ac TESTS: make sure ascq_ok is initialized 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-21 15:30:40 -07:00
Ronnie Sahlberg
264ea509c8 iscsi-support.c: fix memory leaks. Thanks valgrind, you rock 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-21 15:14:51 -07:00
Ronnie Sahlberg
38798e2090 initialize task->datain.data to keep valgrind happy 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-21 15:10:38 -07:00
Ronnie Sahlberg
2af45d9ad4 initialize sense to keep valgrind happy 
valgrind does not know that sense will be initialized by the ioctl
so we need to to it explicitely to keep it from warning us.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-21 14:58:12 -07:00
Ronnie Sahlberg
d11e4175f7 TESTS: Dont memcpy if task==NULL 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-19 17:33:21 -07:00
Ronnie Sahlberg
1e3cc445c8 TESTS: Remove some tests that wont work yet for /dev/sg 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-19 17:15:48 -07:00
Ronnie Sahlberg
55c1f0d2ec TESTS: Add support to test against a /dev/sg device on linux 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-19 16:26:46 -07:00
Ronnie Sahlberg
48e14f5ccf TESTS: update main program to use helpers instead of calling directly to libiscsi 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-19 06:21:02 -07:00
Ronnie Sahlberg
8ed2ad9b69 TESTS: start abstracting away the error string handling from transports 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-18 19:20:49 -07:00
Ronnie Sahlberg
5efc7bf925 TESTS: create a helper/wrapper for sending scsi commands 
Create a wrapper for sending scsi_commands so that we can hide the
libiscsi function far away from the "opcode" helpers.
This means we only have a single place later to switch to a different
type of device, such as a SG_IO one.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-18 18:52:08 -07:00
Ronnie Sahlberg
072291c852 TESTS: change the function signatures for the helpers 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-18 18:19:04 -07:00
Ronnie Sahlberg
9b768f7de9 TESTS: move the default url, lun and iscsi context into a structure 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-18 16:42:45 -07:00
Ronnie Sahlberg
f015ab095a TESTS: update reportsupportedopcodes to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
9be6ddaf09 TESTS: update inquiry to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
398f03205d TESTS: update unmap to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
832d88797a TESTS: remove the read10_task helper 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
9e75b10103 TESTS: change get_lba_status to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
fd21a8f2c4 TESTS: convert readcapacity to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
46eaa7dcc3 TESTS: convert compareandwrite to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
44d88e3bc6 TESTS: update synchronizecache to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
1c14b9b911 TESTS: update read6 to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
3ee3964332 TESTS: change testunitready to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:21 -07:00
Ronnie Sahlberg
fe11a6178b TESTS: add ASCQ check to miscompare 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 13:12:59 -07:00
Ronnie Sahlberg
f1d198c684 TESTS: update startstopunit to use new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 13:12:58 -07:00
Ronnie Sahlberg
28b0a0ab11 TESTS: update the READ tests to the new API 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 13:12:58 -07:00
Ronnie Sahlberg
4b2e9bd417 TESTS: update the prefetch tests to the new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:08:02 -07:00
Ronnie Sahlberg
8585e4509b TESTS: update writesame tests to new API 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:08:01 -07:00
Ronnie Sahlberg
d3f98dfdd5 TESTS: rework WRITEVERIFY* tests to the new API 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:59 -07:00
Ronnie Sahlberg
8ffd78c117 temp: redo the write10/12/16 commands to the new saner api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:57 -07:00
Ronnie Sahlberg
8aefc7d579 TEST: update all the verify tests to a new API 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:55 -07:00
Ronnie Sahlberg
138939cb0e TESTS: change ORWRITE to use a single helper function for all 
Switch orwrite helpers to use _command_async instead of calling _orwrite_sync()
to prepare for switching to non-iscsi targets. Use the new check_result API
so that we only need a single helper function for ORWRITE instead of one
helper for each expected result.

Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:52 -07:00
Ronnie Sahlberg
905695575f TESTS: add a new helper check_result to validate the result of SCSI helpers 
Many/most all SCSI helpers do pretty much the same checking for the SCSI
result and status. Break this out into a separate helper that we can use
to reduce code duplication.

Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:49 -07:00
Peter Lieven
8e4e03d85d test-tool: allow get_lba_status to return provisioning type 
Signed-off-by: Peter Lieven <pl@kamp.de>
 2014-08-13 17:02:51 +02:00
Bart Van Assche
b631a2146c SPC-2 RESERVE tests: Use MODE SENSE instead of TEST UNIT READY 
Although SPC-2 specifies that a reservation conflict should be
reported when TEST UNIT READY is received from another initiator than
the registered initiator, it is an established practice that TEST
UNIT READY is accepted in this case. Hence use the MODE SENSE command
to test the effect of the RESERVE command instead of TEST UNIT READY.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
 2014-08-04 16:05:25 -07:00
Peter Lieven
d6af861c57 iscsi-test: check for invalid descriptors offsets in get_lba_status 
Dell Equallogic sans report an invalid LBA offset in the descriptor when
using 4k LUNs. Check the descriptor for consistency with the request.

Signed-off-by: Peter Lieven <pl@kamp.de>
 2014-07-10 14:44:16 +02:00
jpocas
69c466a6c9 - writesame10 and writesame16 were looking at the datalen, when they wanted to be looking at the number of blocks 2014-05-07 13:49:25 -04:00
Ronnie Sahlberg
717b95cb8a slist.h: rename SLIST_ to ISCSI_LIST_ to avoid clash on *BSD 
Rename the macros for managing the linked lists from SLIST_* to ISCSI_LIST_*
to avoid a clash on *BSD which already have other macros SLIST_*

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-05-07 06:44:19 -07:00
Bart Van Assche
e8545d6a03 verify1[02]_invalidfieldincdb(): Fix an error message 
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
 2014-03-15 08:45:21 -07:00
Ronnie Sahlberg
b0dbecaff7 TESTS: compare and write: Invalidfieldincdb is illegal-request, not miscompare 2014-03-06 17:30:46 -08:00
Ronnie Sahlberg
879f542ebf TESTS: CompareAndWrite are bounded by the max block setting in BlockLimits 
Make sure that we check that a target returns an error if we try to compare and write too much.
 2014-03-05 18:47:24 -08:00
Sitsofe Wheeler
e1659b1973 TESTS: Fix WRITESAME tests to handle targets that don't like datalen == 0 
Recent SBC specs say (when the WSNZ bit is set to one and the NUMBER OF LOGICAL
BLOCKS field is set to zero) or (if MAXIMUM WRITE SAME LENGTH is greater than 0
and the number of logical blocks specified to be written exceeds the MAXIMUM
WRITE SAME LENGTH) the server should terminate with CHECK CONDITION, set the
sense key to ILLEGAL REQUEST and the additional sense code to INVALID FIELD IN
CDB.

Update the WRITESAME tests to cope with this.
 2014-01-25 05:37:45 +00:00
Michael Tokarev
120b308741 Spelling fixes: Dont => Don't 
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
 2013-12-16 18:19:24 -08:00
Bart Van Assche
9c7092e85c test tool: Fix a memory leak in testunitready_clear_ua() 
Avoid leaking 'task' if task->status != SCSI_STATUS_GOOD.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
 2013-10-23 05:34:36 -07:00
Ronnie Sahlberg
8aa6d9de8f TESTS: Add a test for COMPARE_AND_WRITE when the data to verify does not match 2013-09-23 21:58:55 -07:00
Ronnie Sahlberg
9f1a28f753 TESTS: Add an initial simple test for COMPARE_AND_WRITE 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2013-09-22 17:02:30 -07:00
Ronnie Sahlberg
e7df1af3b9 TESTS: READ10 and STARTSTOPUNIT should fail while sanitize is in progress 
Other commands should fail too  but we dont need to test them all
 2013-07-21 14:33:22 -07:00
Ronnie Sahlberg
d901700633 Add a test that a sanitize operation will continue across resets 
Verify that abort task/abort task set/lun reset/warm reset/cold reset
and full blown session failures will not affect a sanitize that is in
progress
 2013-07-21 14:11:13 -07:00
Ronnie Sahlberg
b1b3c603af TESTS: clear unit attention after changing SWP settings in the readonly test 2013-07-21 09:20:00 -07:00
Ronnie Sahlberg
52a83e91af Add POWER_CONDITION modepage marshalling/unmarshalling 2013-07-20 15:35:38 -07:00
Ronnie Sahlberg
a3283fbafd TESTS: Add a test that SANITIZE fails when SWP is on. 2013-07-09 02:27:30 -07:00