admin/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
1,587 Commits 1 Branch 0 Tags
bd29dab95beece4f2eafefe34b01588ecdfa2bc0
Commit Graph

103 Commits

Author SHA1 Message Date
Ronnie Sahlberg
bd29dab95b Tests: Create helper macros for the WriteVerify* commands 
By creating a helper macros for WriteVerify we can save a lot of boilerplate
code.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2016-02-21 15:04:36 -08:00
Bart Van Assche
be9b803334 test-tool: Avoid that using receive_copy_results() triggers a use-after-free 
Move the scsi_free_scsi_task() call from receive_copy_results() to the
callers of this function to avoid that accessing the unmarshalled data
triggers a use-after-free.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
 2015-12-24 10:38:38 -08:00
Bart Van Assche
2d412530c1 test-tool: Move all_zeroes() helper function to iscsi-support.c 
This patch does not change any functionality.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
 2015-10-07 07:44:18 -07:00
Bart Van Assche
393165d66a test-tool: Remove three casts 
This patch does not change any functionality but removes the number
of casts in the test tool source code.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
 2015-10-07 07:43:00 -07:00
David Disseldorp
a1d11eb0f9 test: move UA drain helper function into iscsi-support 
test_iscsi_tur_until_good() dispatches TUR requests until the target has
cleared all UAs for the given sd, or the maximum number of retries is
reached.
This helper function is useful for any test that needs to deal with UAs
(e.g. PRs), so should be moved out into common code.

Signed-off-by: David Disseldorp <ddiss@suse.de>
 2015-09-30 11:00:25 +02:00
David Disseldorp
760ae95d9c test: add prout_preempt() helper function 
Issue a Persistent Reservation Out PREEMPT request, with keys and type
provided.
PREEMPT allows for the removal of registrations, and replacement of
reservations.

Signed-off-by: David Disseldorp <ddiss@suse.de>
 2015-09-30 11:00:25 +02:00
David Disseldorp
9c524b37fa test: add prin_report_caps() helper function 
Issue a Persistent Reservation In REPORT CAPABILITIES request and parse
the response. Callers can obtain the unmarshalled response data via the
_rcaps parameter.

Signed-off-by: David Disseldorp <ddiss@suse.de>
 2015-09-30 11:00:19 +02:00
David Disseldorp
a90e5a3d4c test/iscsi-support: PR Out CLEAR helper function 
Add a helper function to dispatch Persistent Reserve Out requests with
CLEAR service action.

Signed-off-by: David Disseldorp <ddiss@suse.de>
 2015-09-18 18:06:19 +02:00
Ronnie Sahlberg
6c16f9e322 Add tests for WRITE_ATOMIC_16 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2015-09-08 10:17:15 -07:00
Ronnie Sahlberg
a6f7c06119 Add support and tests for ExtendedCopy and ReceiveCopyResults 
From sushma.gurram@sandisk.com
Add support to libiscsi and tests for these two opcodes.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2015-08-02 12:57:21 -07:00
Ronnie Sahlberg
811c04f01a TESTS: read12/read16 change signature to return an optional task structure 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2015-05-12 20:25:04 -07:00
Ronnie Sahlberg
68acbb7c3f rand_key: fix non-randomness in rand_key() 
If rand_key() is called twive within the same second it would return the
same key both times. Not very random.
Redo how rand_key() works to make it more likely to be random and more likely
that two consequtive calls do not yield the same result.

Reported-by: CyberLoiter <yanming.xiao@gmail.com>
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2015-02-10 16:57:22 -08:00
Ronnie Sahlberg
58f06b0e74 TESTS: get rid of a sanitize helper 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-10-14 19:39:27 -07:00
Ronnie Sahlberg
8ac7d64082 TESTS: convert most of SANITIZE to new saner api 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-10-14 19:25:17 -07:00
Ronnie Sahlberg
14461757c4 TESTS: Allow Hardware/Software write protect as valid ASCQ 
Add 0x2701/0x2702 to the list of valid ASCQ values we accept for devices
that are write protected.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-10-08 06:23:43 -07:00
Ronnie Sahlberg
45d87238e2 TESTS: Flag a whole bunch of tests as not supported on non-iSCSI backends 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-27 08:58:24 -07:00
Ronnie Sahlberg
abbf9a11b0 TESTS: change modeselect to become /dev/sg-aware 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-27 08:10:14 -07:00
Ronnie Sahlberg
55c1f0d2ec TESTS: Add support to test against a /dev/sg device on linux 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-19 16:26:46 -07:00
Ronnie Sahlberg
48e14f5ccf TESTS: update main program to use helpers instead of calling directly to libiscsi 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-19 06:21:02 -07:00
Ronnie Sahlberg
8ed2ad9b69 TESTS: start abstracting away the error string handling from transports 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-18 19:20:49 -07:00
Ronnie Sahlberg
072291c852 TESTS: change the function signatures for the helpers 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-18 18:19:04 -07:00
Ronnie Sahlberg
9b768f7de9 TESTS: move the default url, lun and iscsi context into a structure 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-09-18 16:42:45 -07:00
Ronnie Sahlberg
f015ab095a TESTS: update reportsupportedopcodes to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
9be6ddaf09 TESTS: update inquiry to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
398f03205d TESTS: update unmap to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
832d88797a TESTS: remove the read10_task helper 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
9e75b10103 TESTS: change get_lba_status to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
fd21a8f2c4 TESTS: convert readcapacity to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
46eaa7dcc3 TESTS: convert compareandwrite to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
44d88e3bc6 TESTS: update synchronizecache to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
1c14b9b911 TESTS: update read6 to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:22 -07:00
Ronnie Sahlberg
3ee3964332 TESTS: change testunitready to new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 14:07:21 -07:00
Ronnie Sahlberg
fe11a6178b TESTS: add ASCQ check to miscompare 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 13:12:59 -07:00
Ronnie Sahlberg
f1d198c684 TESTS: update startstopunit to use new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 13:12:58 -07:00
Ronnie Sahlberg
28b0a0ab11 TESTS: update the READ tests to the new API 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 13:12:58 -07:00
Ronnie Sahlberg
4b2e9bd417 TESTS: update the prefetch tests to the new api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:08:02 -07:00
Ronnie Sahlberg
8585e4509b TESTS: update writesame tests to new API 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:08:01 -07:00
Ronnie Sahlberg
d3f98dfdd5 TESTS: rework WRITEVERIFY* tests to the new API 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:59 -07:00
Ronnie Sahlberg
8ffd78c117 temp: redo the write10/12/16 commands to the new saner api 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:57 -07:00
Ronnie Sahlberg
8aefc7d579 TEST: update all the verify tests to a new API 
Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:55 -07:00
Ronnie Sahlberg
138939cb0e TESTS: change ORWRITE to use a single helper function for all 
Switch orwrite helpers to use _command_async instead of calling _orwrite_sync()
to prepare for switching to non-iscsi targets. Use the new check_result API
so that we only need a single helper function for ORWRITE instead of one
helper for each expected result.

Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:52 -07:00
Ronnie Sahlberg
905695575f TESTS: add a new helper check_result to validate the result of SCSI helpers 
Many/most all SCSI helpers do pretty much the same checking for the SCSI
result and status. Break this out into a separate helper that we can use
to reduce code duplication.

Signed-off-by: Ronnie Sahlberg <sahlberg@localhost>
 2014-09-18 12:07:49 -07:00
Peter Lieven
8e4e03d85d test-tool: allow get_lba_status to return provisioning type 
Signed-off-by: Peter Lieven <pl@kamp.de>
 2014-08-13 17:02:51 +02:00
Bart Van Assche
b631a2146c SPC-2 RESERVE tests: Use MODE SENSE instead of TEST UNIT READY 
Although SPC-2 specifies that a reservation conflict should be
reported when TEST UNIT READY is received from another initiator than
the registered initiator, it is an established practice that TEST
UNIT READY is accepted in this case. Hence use the MODE SENSE command
to test the effect of the RESERVE command instead of TEST UNIT READY.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
 2014-08-04 16:05:25 -07:00
Ronnie Sahlberg
cefb6a6127 TESTS: update the get_lba_status + unmap test to account for lbppbe 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2014-07-16 05:37:34 -07:00
Ronnie Sahlberg
879f542ebf TESTS: CompareAndWrite are bounded by the max block setting in BlockLimits 
Make sure that we check that a target returns an error if we try to compare and write too much.
 2014-03-05 18:47:24 -08:00
Ronnie Sahlberg
8aa6d9de8f TESTS: Add a test for COMPARE_AND_WRITE when the data to verify does not match 2013-09-23 21:58:55 -07:00
Ronnie Sahlberg
9f1a28f753 TESTS: Add an initial simple test for COMPARE_AND_WRITE 
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
 2013-09-22 17:02:30 -07:00
Ronnie Sahlberg
e7df1af3b9 TESTS: READ10 and STARTSTOPUNIT should fail while sanitize is in progress 
Other commands should fail too  but we dont need to test them all
 2013-07-21 14:33:22 -07:00
Ronnie Sahlberg
d901700633 Add a test that a sanitize operation will continue across resets 
Verify that abort task/abort task set/lun reset/warm reset/cold reset
and full blown session failures will not affect a sanitize that is in
progress
 2013-07-21 14:11:13 -07:00