Arne Redlich
551298adfb
scsi-lowlevel: remove scsi_serviceactionin_params and plug potential memleaks
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 22:57:59 +01:00
Peter Lieven
f9dc2da672
Revert "CONNECT only read/write from sockets when connection is established"
...
Fixed the login process in qemu-kvm. This makes this fix obsolete.
This reverts commit a9257d52a7 .
2012-11-18 13:57:57 -08:00
Peter Lieven
00baa9bd6c
CONNECT fixed memleak in case iscsi_connect_async fails directly
2012-11-18 13:57:02 -08:00
Ronnie Sahlberg
bdfa2833e5
tiny style change
2012-11-18 13:55:15 -08:00
Peter Lieven
6f3a575238
INIT check iscsi==NULL in iscsi_get_error()
...
qemu-kvm calls iscsi_get_error(NULL) if we specify an invalid URL
2012-11-18 13:54:07 -08:00
Peter Lieven
6f7b02989a
LOGGING log target_name and not initator_name
2012-11-18 13:52:55 -08:00
Peter Lieven
bd1d5ec70f
LOGGING add target name to log output
2012-11-18 13:52:48 -08:00
Arne Redlich
fa158865d2
scsi-lowlevel: remove scsi_modesense6_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 22:47:14 +01:00
Arne Redlich
5f414317dc
scsi-lowlevel: remove scsi_inquiry_params and refactor INQUIRY data-in unmarshalling
...
Split the INQUIRY data-in unmarshalling into smaller chunks, fixing some
potential memory leaks along the way.
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 22:46:04 +01:00
Arne Redlich
b5a9ba6159
scsi-lowlevel: remove scsi_readcapacity10_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 22:04:57 +01:00
Arne Redlich
188505a72d
scsi-lowlevel: remove scsi_verify16_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:59:42 +01:00
Arne Redlich
de67d86e64
scsi-lowlevel: remove scsi_verify12_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:58:30 +01:00
Arne Redlich
10fd2f560b
scsi-lowlevel: remove scsi_verify10_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:57:00 +01:00
Arne Redlich
1dbdd04795
scsi-lowlevel: remove scsi_writeverify16_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:55:01 +01:00
Arne Redlich
a262d07c4b
scsi-lowlevel: remove scsi_writeverify12_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:53:44 +01:00
Arne Redlich
fff2527cda
scsi-lowlevel: remove scsi_writeverify10_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:52:34 +01:00
Arne Redlich
8169c3e280
scsi-lowlevel: remove scsi_compareandwrite_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:51:10 +01:00
Arne Redlich
9f7f7f1e0d
scsi-lowlevel: remove scsi_orwrite_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:48:17 +01:00
Arne Redlich
8f513c23f5
scsi-lowlevel: remove scsi_preventallow_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:46:52 +01:00
Arne Redlich
a02cd53cfc
scsi-lowlevel: remove scsi_startstopunit_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:45:02 +01:00
Arne Redlich
3ec1a2147f
scsi-lowlevel: remove scsi_write16_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:43:15 +01:00
Arne Redlich
f95d86f762
scsi-lowlevel: remove scsi_write12_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:41:53 +01:00
Arne Redlich
1ca5f447fc
scsi-lowlevel: remove scsi_write10_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:40:27 +01:00
Arne Redlich
daed6117c8
scsi-lowlevel: remove scsi_read16_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:38:35 +01:00
Arne Redlich
17eff2d8d9
scsi-lowlevel: remove scsi_read12_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:37:05 +01:00
Arne Redlich
f955449ecc
scsi-lowlevel: remove scsi_read10_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:35:37 +01:00
Arne Redlich
d95e811ccf
scsi-lowlevel: remove scsi_read6_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:34:08 +01:00
Arne Redlich
76aa2693c4
scsi-lowlevel: remove scsi_reportluns_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:31:11 +01:00
Ronnie Sahlberg
3ccc2f2834
TESTS: Update the VERIFY10/12/16 tests for BYTCHK==0
2012-11-18 10:10:04 -08:00
Ronnie Sahlberg
f9767e729a
VERIFY10/12/16 If BYTCHK is false we dont need to transfer any blocks to the target
...
If BYTCHK is false the target will perform a medium check of the indicated
LBAs only and not compare with anything out of the DATA-OUT buffers.
As such we dont need to/should not transfer any DAT-OUT to the target.
2012-11-18 09:46:51 -08:00
Arne Redlich
44cb5d60c5
iscsi.h: include <sys/types.h> as iscsi_data gained a size_t member
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 00:36:28 +01:00
Ronnie Sahlberg
e661c22875
Merge pull request #36 from plieven/master
...
Merge of my patches as discussed
2012-11-12 16:44:18 -08:00
Peter Lieven
b1374b42ed
Rename scsi-command.c to iscsi-command.c
2012-11-12 16:12:29 +01:00
Peter Lieven
8cb369b87f
Merge remote-tracking branch 'upstream-git/master'
...
Conflicts:
include/iscsi-private.h
include/iscsi.h
lib/connect.c
lib/init.c
lib/scsi-lowlevel.c
2012-11-12 16:02:57 +01:00
Peter Lieven
5e1d011270
SCSI-LOWLEVEL revert changes to scsi-lowlevel
...
The memory tracking code reports memory allocated by iscsi_allocate_pdu_with_itt_flags_size() as lost.
This memory is allocated by the iscsi part of libiscsi, but later freed by the lowlevel scsi part. We
will fix this later by introducing an iscsi_task object.
2012-11-12 15:43:29 +01:00
Ronnie Sahlberg
736e175e83
Build with -Werror
2012-11-11 10:15:52 -08:00
Ronnie Sahlberg
5a95010b59
Fix some compiler warnings
2012-11-11 10:12:39 -08:00
Ronnie Sahlberg
9eb26a368d
Fix compiler warnings related to 'const'
2012-11-11 10:03:45 -08:00
Ronnie Sahlberg
a5b8224f4e
Dont include iscsi headers from the scsi implementation in scsi-lowlevel.c
2012-11-11 09:49:49 -08:00
Ronnie Sahlberg
3b05e9996f
Move cancel_task and cancel_all_tasks from scsi-lowlevel.c to scsi-command.c
...
These two functions belong in the iscsi layer, not the scsi layer so move them
out from scsi-lowlevel.c so that we can start turning scsi-lowlevel.c to a pure
scsi layer and remove all dependencies to iscsi from it.
2012-11-11 09:44:11 -08:00
Ronnie Sahlberg
49af416f47
When we cancel a scsi task we don't need to unlink the in_buffers
...
We dont need to unlink the in-buffers when cancelling a scsi task
since the whole task structure will go away shortly anyway and all
entries in the link will be automatically freed when the task is freed.
2012-11-11 09:35:34 -08:00
Peter Lieven
5722ad7e98
LOGIN change dynamic string allocations to statics
2012-11-11 08:42:06 -08:00
Peter Lieven
8512f19911
ISCSI-READCAPACITY16 fix missing free of scsi_task
2012-11-11 08:32:05 -08:00
Peter Lieven
864a4d60a0
LD_ISCSI invalidate get_lba_status cache on write
2012-11-11 08:17:27 -08:00
Peter Lieven
f331556d65
LD_ISCSI add pwrite and dlsym it at init
2012-11-11 08:15:51 -08:00
Peter Lieven
bd04f4bfa6
LD_ISCSI add pwite
2012-11-11 08:15:26 -08:00
Peter Lieven
6884b6eb75
LD_ISCSI add write
...
the write command is limited in the sense that file offset and
count bytes must be multiple of the targets blocksize. for most
copy/dd etc. operations this is sufficient to work.
2012-11-11 08:14:38 -08:00
Peter Lieven
bf758c7833
LD_ISCSI add pread
2012-11-11 08:14:10 -08:00
Peter Lieven
59860df16a
LD_ISCSI add lseek
2012-11-11 08:13:47 -08:00
Peter Lieven
01cd2ee42b
LD_ISCSI fix segfault on reconnect
...
iscsi_reconnect calls dup2 which is intercepted in ld_iscsi. Fix this by
calling the real dup2 in this case.
2012-11-11 08:13:03 -08:00