Avoid that Valgrind reports complaints similar to the following: Syscall param writev(vector[...]) points to uninitialised byte(s) at 0x5567087: writev (writev.c:49) by 0x5265AE0: iscsi_iovector_readv_writev (socket.c:492) by 0x52666B5: iscsi_write_to_socket (socket.c:710) by 0x5266CCC: iscsi_service (socket.c:852) by 0x526751F: event_loop (sync.c:67) by 0x5269B41: iscsi_scsi_command_sync (sync.c:1153) by 0x4050F6: send_scsi_command (iscsi-support.c:245) by 0x408007: compareandwrite (iscsi-support.c:1512) by 0x40B6AD: test_compareandwrite_dpofua (test_compareandwrite_dpofua.c:69) by 0x503EC99: ??? (in /usr/lib/libcunit.so.1.0.1) by 0x503EF27: ??? (in /usr/lib/libcunit.so.1.0.1) by 0x503F2A5: CU_run_all_tests (in /usr/lib/libcunit.so.1.0.1) Address 0xffeffff10 is on thread 1's stack in frame #8, created by test_compareandwrite_dpofua (test_compareandwrite_dpofua.c:30) Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
157 lines
4.8 KiB
C
157 lines
4.8 KiB
C
/*
|
|
Copyright (C) 2013 by Ronnie Sahlberg <ronniesahlberg@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <CUnit/CUnit.h>
|
|
|
|
#include "iscsi.h"
|
|
#include "scsi-lowlevel.h"
|
|
#include "iscsi-support.h"
|
|
#include "iscsi-test-cu.h"
|
|
|
|
|
|
void
|
|
test_readonly_sbc(void)
|
|
{
|
|
int ret;
|
|
unsigned char buf[4096];
|
|
struct unmap_list list[1];
|
|
|
|
CHECK_FOR_DATALOSS;
|
|
CHECK_FOR_READONLY;
|
|
CHECK_FOR_SBC;
|
|
|
|
logging(LOG_VERBOSE, LOG_BLANK_LINE);
|
|
logging(LOG_VERBOSE, "Test that Medium write commands fail for READ-ONLY SBC devices");
|
|
|
|
|
|
logging(LOG_VERBOSE, "Test WRITE10 fails with WRITE_PROTECTED");
|
|
memset(buf, 0xa6, sizeof(buf));
|
|
ret = write10(sd, 0, block_size, block_size,
|
|
0, 0, 0, 0, 0, buf,
|
|
EXPECT_WRITE_PROTECTED);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITE12 fails with WRITE_PROTECTED");
|
|
ret = write12(sd, 0, block_size, block_size,
|
|
0, 0, 0, 0, 0, buf,
|
|
EXPECT_WRITE_PROTECTED);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITE16 fails with WRITE_PROTECTED");
|
|
ret = write16(sd, 0, block_size, block_size,
|
|
0, 0, 0, 0, 0, buf,
|
|
EXPECT_WRITE_PROTECTED);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITE_SAME10 fails with WRITE_PROTECTED");
|
|
ret = writesame10(sd, 0, block_size, 1,
|
|
0, 0, 0, 0, buf,
|
|
EXPECT_WRITE_PROTECTED);
|
|
if (ret == -2) {
|
|
logging(LOG_VERBOSE, "WRITE_SAME10 not supported on target. Skipped.");
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, -1);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITE_SAME16 fails with WRITE_PROTECTED");
|
|
ret = writesame16(sd, 0, block_size, 1,
|
|
0, 0, 0, 0, buf,
|
|
EXPECT_WRITE_PROTECTED);
|
|
if (ret == -2) {
|
|
logging(LOG_VERBOSE, "WRITE_SAME16 not supported on target. Skipped.");
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, -1);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITE_SAME10 UNMAP fails with WRITE_PROTECTED");
|
|
ret = writesame10(sd, 0,
|
|
block_size, 1, 0, 1, 0, 0, NULL,
|
|
EXPECT_WRITE_PROTECTED);
|
|
if (ret == -2) {
|
|
logging(LOG_VERBOSE, "WRITE_SAME10 not supported on target. Skipped.");
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, -1);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITE_SAME16 UNMAP fails with WRITE_PROTECTED");
|
|
ret = writesame16(sd, 0,
|
|
block_size, 1, 0, 1, 0, 0, NULL,
|
|
EXPECT_WRITE_PROTECTED);
|
|
if (ret == -2) {
|
|
logging(LOG_VERBOSE, "WRITE_SAME16 not supported on target. Skipped.");
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, -1);
|
|
|
|
logging(LOG_VERBOSE, "Test UNMAP of one physical block fails with WRITE_PROTECTED");
|
|
list[0].lba = 0;
|
|
list[0].num = lbppb;
|
|
ret = unmap(sd, 0, list, 1,
|
|
EXPECT_WRITE_PROTECTED);
|
|
if (ret == -2) {
|
|
logging(LOG_VERBOSE, "UNMAP not supported on target. Skipped.");
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, -1);
|
|
|
|
logging(LOG_VERBOSE, "Test UNMAP of one logical block fails with WRITE_PROTECTED");
|
|
list[0].lba = 0;
|
|
list[0].num = 1;
|
|
ret = unmap(sd, 0, list, 1,
|
|
EXPECT_WRITE_PROTECTED);
|
|
if (ret == -2) {
|
|
logging(LOG_VERBOSE, "UNMAP not supported on target. Skipped.");
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, -1);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITEVERIFY10 fails with WRITE_PROTECTED");
|
|
ret = writeverify10(sd, 0,
|
|
block_size, block_size, 0, 0, 0, 0, buf,
|
|
EXPECT_WRITE_PROTECTED);
|
|
if (ret == -2) {
|
|
logging(LOG_VERBOSE, "WRITEVERIFY10 not supported on target. Skipped.");
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, -1);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITEVERIFY12 fails with WRITE_PROTECTED");
|
|
ret = writeverify12(sd, 0,
|
|
block_size, block_size, 0, 0, 0, 0, buf,
|
|
EXPECT_WRITE_PROTECTED);
|
|
if (ret == -2) {
|
|
logging(LOG_VERBOSE, "WRITEVERIFY12 not supported on target. Skipped.");
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, -1);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITEVERIFY16 fails with WRITE_PROTECTED");
|
|
ret = writeverify16(sd, 0,
|
|
block_size, block_size, 0, 0, 0, 0, buf,
|
|
EXPECT_WRITE_PROTECTED);
|
|
if (ret == -2) {
|
|
logging(LOG_VERBOSE, "WRITEVERIFY16 not supported on target. Skipped.");
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, -1);
|
|
|
|
logging(LOG_VERBOSE, "Test ORWRITE fails with WRITE_PROTECTED");
|
|
ret = orwrite(sd, 0,
|
|
block_size, block_size, 0, 0, 0, 0, 0, buf,
|
|
EXPECT_WRITE_PROTECTED);
|
|
if (ret == -2) {
|
|
logging(LOG_VERBOSE, "ORWRITE not supported on target. Skipped.");
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, -1);
|
|
|
|
/* NOT implemented yet */
|
|
logging(LOG_VERBOSE, "Test for COMPAREANDWRITE not implemented yet.");
|
|
}
|