b3783b961b
Avoid that Valgrind reports complaints similar to the following: Syscall param writev(vector[...]) points to uninitialised byte(s) at 0x5567087: writev (writev.c:49) by 0x5265AE0: iscsi_iovector_readv_writev (socket.c:492) by 0x52666B5: iscsi_write_to_socket (socket.c:710) by 0x5266CCC: iscsi_service (socket.c:852) by 0x526751F: event_loop (sync.c:67) by 0x5269B41: iscsi_scsi_command_sync (sync.c:1153) by 0x4050F6: send_scsi_command (iscsi-support.c:245) by 0x408007: compareandwrite (iscsi-support.c:1512) by 0x40B6AD: test_compareandwrite_dpofua (test_compareandwrite_dpofua.c:69) by 0x503EC99: ??? (in /usr/lib/libcunit.so.1.0.1) by 0x503EF27: ??? (in /usr/lib/libcunit.so.1.0.1) by 0x503F2A5: CU_run_all_tests (in /usr/lib/libcunit.so.1.0.1) Address 0xffeffff10 is on thread 1's stack in frame #8, created by test_compareandwrite_dpofua (test_compareandwrite_dpofua.c:30) Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
84 lines
2.5 KiB
C
84 lines
2.5 KiB
C
/*
|
|
Copyright (C) 2013 Ronnie Sahlberg <ronniesahlberg@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <CUnit/CUnit.h>
|
|
|
|
#include "iscsi.h"
|
|
#include "scsi-lowlevel.h"
|
|
#include "iscsi-support.h"
|
|
#include "iscsi-test-cu.h"
|
|
|
|
|
|
void
|
|
test_writesame16_unmap_until_end(void)
|
|
{
|
|
int ret;
|
|
unsigned int i, j;
|
|
unsigned char *buf = alloca(256 * block_size);
|
|
unsigned char *zeroBlock;
|
|
|
|
CHECK_FOR_DATALOSS;
|
|
CHECK_FOR_THIN_PROVISIONING;
|
|
CHECK_FOR_LBPWS;
|
|
CHECK_FOR_SBC;
|
|
|
|
zeroBlock = alloca(block_size);
|
|
memset(zeroBlock, 0, block_size);
|
|
|
|
logging(LOG_VERBOSE, LOG_BLANK_LINE);
|
|
logging(LOG_VERBOSE, "Test WRITESAME16 of 1-256 blocks at the end of the LUN by setting number-of-blocks==0");
|
|
memset(buf, 0xa6, 256 * block_size);
|
|
for (i = 1; i <= 256; i++) {
|
|
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
|
memset(buf, 0xff, block_size * i);
|
|
ret = write16(sd, num_blocks - i,
|
|
i * block_size, block_size, 0, 0, 0, 0, 0, buf,
|
|
EXPECT_STATUS_GOOD);
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME16", i);
|
|
ret = writesame16(sd, num_blocks - i,
|
|
0, i, 0, 1, 0, 0, NULL,
|
|
EXPECT_STATUS_GOOD);
|
|
if (ret == -2) {
|
|
logging(LOG_NORMAL, "[SKIPPED] WRITESAME16 is not implemented.");
|
|
CU_PASS("[SKIPPED] Target does not support WRITESAME16. Skipping test");
|
|
return;
|
|
}
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
if (rc16->lbprz) {
|
|
logging(LOG_VERBOSE, "LBPRZ is set. Read the unmapped "
|
|
"blocks back and verify they are all zero");
|
|
|
|
logging(LOG_VERBOSE, "Read %d blocks and verify they "
|
|
"are now zero", i);
|
|
ret = read16(sd, num_blocks - i,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf,
|
|
EXPECT_STATUS_GOOD);
|
|
for (j = 0; j < i; j++) {
|
|
CU_ASSERT_EQUAL(memcmp(buf + j*block_size, zeroBlock, block_size), 0);
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
|
"and verify zero test");
|
|
}
|
|
}
|
|
}
|