Only perform the test with 65536 blocks on block devices with at least that number of blocks. Fix the 65536 block test log message. Generalize the WRITE SAME(10) 256-block test log messages. Fix interpretation of the MAXIMUM UNMAP BLOCK DESCRIPTOR COUNT field. A quote from SPC-4: "If there is no limit on the number of UNMAP block descriptors contained in the parameter data, then the device server shall set the MAXIMUM UNMAP BLOCK DESCRIPTOR COUNT field to FFFF_FFFFh." Signed-off-by: Bart Van Assche <bvanassche@acm.org>
252 lines
7.5 KiB
C
252 lines
7.5 KiB
C
/*
|
|
Copyright (C) 2013 Ronnie Sahlberg <ronniesahlberg@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <CUnit/CUnit.h>
|
|
|
|
#include "iscsi.h"
|
|
#include "scsi-lowlevel.h"
|
|
#include "iscsi-support.h"
|
|
#include "iscsi-test-cu.h"
|
|
|
|
|
|
void
|
|
test_writesame16_unmap(void)
|
|
{
|
|
int ret;
|
|
unsigned int i, j;
|
|
unsigned char *buf;
|
|
unsigned char *zeroBlock;
|
|
|
|
CHECK_FOR_DATALOSS;
|
|
CHECK_FOR_THIN_PROVISIONING;
|
|
CHECK_FOR_LBPWS;
|
|
CHECK_FOR_SBC;
|
|
|
|
logging(LOG_VERBOSE, LOG_BLANK_LINE);
|
|
logging(LOG_VERBOSE, "Test WRITESAME16 of 1-256 blocks at the start of the LUN");
|
|
buf = malloc(65536 * block_size);
|
|
zeroBlock = alloca(block_size);
|
|
memset(zeroBlock, 0, block_size);
|
|
for (i = 1; i <= 256; i++) {
|
|
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
|
memset(buf, 0xff, i * block_size);
|
|
ret = write16(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME16", i);
|
|
memset(buf, 0, block_size);
|
|
ret = writesame16(iscsic, tgt_lun, 0,
|
|
block_size, i,
|
|
0, 1, 0, 0, buf);
|
|
if (ret == -2) {
|
|
logging(LOG_NORMAL, "[SKIPPED] WRITESAME16 is not implemented.");
|
|
CU_PASS("[SKIPPED] Target does not support WRITESAME16. Skipping test");
|
|
goto finished;
|
|
}
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
if (rc16->lbprz) {
|
|
logging(LOG_VERBOSE, "LBPRZ is set. Read the unmapped "
|
|
"blocks back and verify they are all zero");
|
|
logging(LOG_VERBOSE, "Read %d blocks and verify they "
|
|
"are now zero", i);
|
|
ret = read16(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
for (j = 0; j < i; j++) {
|
|
CU_ASSERT_EQUAL(memcmp(buf + j*block_size, zeroBlock, block_size), 0);
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
|
"and verify zero test");
|
|
}
|
|
}
|
|
|
|
|
|
logging(LOG_VERBOSE, "Test WRITESAME16 of 1-256 blocks at the end of the LUN");
|
|
for (i = 1; i <= 256; i++) {
|
|
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
|
memset(buf, 0xff, i * block_size);
|
|
ret = write16(iscsic, tgt_lun, num_blocks - i,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME16", i);
|
|
memset(buf, 0, block_size);
|
|
ret = writesame16(iscsic, tgt_lun, num_blocks - i,
|
|
block_size, i,
|
|
0, 1, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
if (rc16->lbprz) {
|
|
logging(LOG_VERBOSE, "LBPRZ is set. Read the unmapped "
|
|
"blocks back and verify they are all zero");
|
|
logging(LOG_VERBOSE, "Read %d blocks and verify they "
|
|
"are now zero", i);
|
|
ret = read16(iscsic, tgt_lun, num_blocks - i,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
for (j = 0; j < i; j++) {
|
|
CU_ASSERT_EQUAL(memcmp(buf + j*block_size, zeroBlock, block_size), 0);
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
|
"and verify zero test");
|
|
}
|
|
}
|
|
|
|
logging(LOG_VERBOSE, "Verify that WRITESAME16 ANCHOR==1 + UNMAP==0 is invalid");
|
|
ret = writesame16_invalidfieldincdb(iscsic, tgt_lun, 0,
|
|
block_size, 1,
|
|
1, 0, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
|
|
|
|
if (inq_lbp->anc_sup) {
|
|
logging(LOG_VERBOSE, "Test WRITESAME16 ANCHOR==1 + UNMAP==0");
|
|
memset(buf, 0, block_size);
|
|
ret = writesame16(iscsic, tgt_lun, 0,
|
|
block_size, 1,
|
|
1, 1, 0, 0, buf);
|
|
} else {
|
|
logging(LOG_VERBOSE, "Test WRITESAME16 ANCHOR==1 + UNMAP==0 no ANC_SUP so expecting to fail");
|
|
ret = writesame16_invalidfieldincdb(iscsic, tgt_lun, 0,
|
|
block_size, 1,
|
|
1, 1, 0, 0, buf);
|
|
}
|
|
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
|
|
if (inq_bl == NULL) {
|
|
logging(LOG_VERBOSE, "[FAILED] WRITESAME16 works but "
|
|
"BlockLimits VPD is missing.");
|
|
CU_FAIL("[FAILED] WRITESAME16 works but "
|
|
"BlockLimits VPD is missing.");
|
|
goto finished;
|
|
}
|
|
|
|
i = 256;
|
|
if (i <= num_blocks
|
|
&& (inq_bl->max_ws_len == 0 || inq_bl->max_ws_len >= i)) {
|
|
logging(LOG_VERBOSE, "Block Limits VPD page reports MAX_WS_LEN "
|
|
"as either 0 (==no limit) or >= %d. Test Unmapping "
|
|
"%d blocks to verify that it can handle 2-byte "
|
|
"lengths", i, i);
|
|
|
|
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
|
memset(buf, 0xff, i * block_size);
|
|
ret = write16(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME16", i);
|
|
memset(buf, 0, block_size);
|
|
ret = writesame16(iscsic, tgt_lun, 0,
|
|
block_size, i,
|
|
0, 1, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
if (rc16->lbprz) {
|
|
logging(LOG_VERBOSE, "LBPRZ is set. Read the unmapped "
|
|
"blocks back and verify they are all zero");
|
|
|
|
logging(LOG_VERBOSE, "Read %d blocks and verify they "
|
|
"are now zero", i);
|
|
ret = read16(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
for (j = 0; j < i; j++) {
|
|
CU_ASSERT_EQUAL(memcmp(buf + j*block_size, zeroBlock, block_size), 0);
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
|
"and verify zero test");
|
|
}
|
|
} else if (i <= num_blocks) {
|
|
logging(LOG_VERBOSE, "Block Limits VPD page reports MAX_WS_LEN "
|
|
"as <256. Verify that a 256 block unmap fails with "
|
|
"INVALID_FIELD_IN_CDB.");
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME16", i);
|
|
ret = writesame16_invalidfieldincdb(iscsic, tgt_lun, 0,
|
|
block_size, i,
|
|
0, 1, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
}
|
|
|
|
|
|
i = 65536;
|
|
if (i <= num_blocks
|
|
&& (inq_bl->max_ws_len == 0 || inq_bl->max_ws_len >= i)) {
|
|
logging(LOG_VERBOSE, "Block Limits VPD page reports MAX_WS_LEN "
|
|
"as either 0 (==no limit) or >= %d. Test Unmapping "
|
|
"%d blocks to verify that it can handle 4-byte "
|
|
"lengths", i, i);
|
|
|
|
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
|
memset(buf, 0xff, i * block_size);
|
|
ret = write16(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME16", i);
|
|
memset(buf, 0, block_size);
|
|
ret = writesame16(iscsic, tgt_lun, 0,
|
|
block_size, i,
|
|
0, 1, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
if (rc16->lbprz) {
|
|
logging(LOG_VERBOSE, "LBPRZ is set. Read the unmapped "
|
|
"blocks back and verify they are all zero");
|
|
|
|
logging(LOG_VERBOSE, "Read %d blocks and verify they "
|
|
"are now zero", i);
|
|
ret = read16(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
for (j = 0; j < i; j++) {
|
|
CU_ASSERT_EQUAL(memcmp(buf + j*block_size, zeroBlock, block_size), 0);
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
|
"and verify zero test");
|
|
}
|
|
} else if (i <= num_blocks) {
|
|
logging(LOG_VERBOSE, "Block Limits VPD page reports MAX_WS_LEN "
|
|
"as <256. Verify that a 256 block unmap fails with "
|
|
"INVALID_FIELD_IN_CDB.");
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME16", i);
|
|
ret = writesame16_invalidfieldincdb(iscsic, tgt_lun, 0,
|
|
block_size, i,
|
|
0, 1, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
}
|
|
|
|
finished:
|
|
free(buf);
|
|
}
|