864bf81c56
If BLockLimits->MaxWriteSameLength is 0 (no limit) or >=256 then verify that both WRITESAME10 and WRITESAME16 can unmap with a number of blocks == 2 byte field. If not, then verify that a 256 block unmap results in INVALID FIELD IN CDB If BLockLimits->MaxWriteSameLength is 0 (no limit) or >=65536 then verify that WRITESAME16 can unmap with a number of blocks == 3 byte field. If not, then verify that a 65536 block unmap results in INVALID FIELD IN CDB From discussions on linux-scsi there are devices that support WRITESAME16 but where the implementation only looks at the low 2 bytes of the 4 bytes for num-blocks in the CDB. This added test aims to find and flag such devices.
252 lines
7.2 KiB
C
252 lines
7.2 KiB
C
/*
|
|
Copyright (C) 2013 Ronnie Sahlberg <ronniesahlberg@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <CUnit/CUnit.h>
|
|
|
|
#include "iscsi.h"
|
|
#include "scsi-lowlevel.h"
|
|
#include "iscsi-support.h"
|
|
#include "iscsi-test-cu.h"
|
|
|
|
|
|
void
|
|
test_writesame16_unmap(void)
|
|
{
|
|
int i, ret;
|
|
unsigned int j;
|
|
unsigned char *buf = malloc(block_size * 65536);
|
|
|
|
|
|
CHECK_FOR_DATALOSS;
|
|
CHECK_FOR_THIN_PROVISIONING;
|
|
CHECK_FOR_LBPWS;
|
|
CHECK_FOR_SBC;
|
|
|
|
logging(LOG_VERBOSE, LOG_BLANK_LINE);
|
|
logging(LOG_VERBOSE, "Test WRITESAME16 of 1-256 blocks at the start of the LUN");
|
|
for (i = 1; i <= 256; i++) {
|
|
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
|
memset(buf, 0xff, block_size * i);
|
|
ret = write16(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME16", i);
|
|
ret = writesame16(iscsic, tgt_lun, 0,
|
|
block_size, i,
|
|
0, 1, 0, 0, NULL);
|
|
if (ret == -2) {
|
|
logging(LOG_NORMAL, "[SKIPPED] WRITESAME16 is not implemented.");
|
|
CU_PASS("[SKIPPED] Target does not support WRITESAME16. Skipping test");
|
|
free(buf);
|
|
return;
|
|
}
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
if (rc16->lbprz) {
|
|
logging(LOG_VERBOSE, "LBPRZ is set. Read the unmapped "
|
|
"blocks back and verify they are all zero");
|
|
logging(LOG_VERBOSE, "Read %d blocks and verify they "
|
|
"are now zero", i);
|
|
ret = read16(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
for (j = 0; j < block_size * i; j++) {
|
|
if (buf[j] != 0) {
|
|
CU_ASSERT_EQUAL(buf[j], 0);
|
|
}
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
|
"and verify zero test");
|
|
}
|
|
}
|
|
|
|
|
|
logging(LOG_VERBOSE, "Test WRITESAME16 of 1-256 blocks at the end of the LUN");
|
|
for (i = 1; i <= 256; i++) {
|
|
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
|
memset(buf, 0xff, block_size * i);
|
|
ret = write16(iscsic, tgt_lun, num_blocks - i,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME16", i);
|
|
ret = writesame16(iscsic, tgt_lun, num_blocks - i,
|
|
block_size, i,
|
|
0, 1, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
if (rc16->lbprz) {
|
|
logging(LOG_VERBOSE, "LBPRZ is set. Read the unmapped "
|
|
"blocks back and verify they are all zero");
|
|
logging(LOG_VERBOSE, "Read %d blocks and verify they "
|
|
"are now zero", i);
|
|
ret = read16(iscsic, tgt_lun, num_blocks - i,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
for (j = 0; j < block_size * i; j++) {
|
|
if (buf[j] != 0) {
|
|
CU_ASSERT_EQUAL(buf[j], 0);
|
|
}
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
|
"and verify zero test");
|
|
}
|
|
}
|
|
|
|
logging(LOG_VERBOSE, "Verify that WRITESAME16 ANCHOR==1 + UNMAP==0 is invalid");
|
|
ret = writesame16_invalidfieldincdb(iscsic, tgt_lun, 0,
|
|
block_size, 1,
|
|
1, 0, 0, 0, NULL);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
|
|
|
|
if (inq_lbp->anc_sup) {
|
|
logging(LOG_VERBOSE, "Test WRITESAME16 ANCHOR==1 + UNMAP==0");
|
|
ret = writesame16(iscsic, tgt_lun, 0,
|
|
block_size, 1,
|
|
1, 1, 0, 0, NULL);
|
|
} else {
|
|
logging(LOG_VERBOSE, "Test WRITESAME16 ANCHOR==1 + UNMAP==0 no ANC_SUP so expecting to fail");
|
|
ret = writesame16_invalidfieldincdb(iscsic, tgt_lun, 0,
|
|
block_size, 1,
|
|
1, 1, 0, 0, NULL);
|
|
}
|
|
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
|
|
if (inq_bl == NULL) {
|
|
logging(LOG_VERBOSE, "[FAILED] WRITESAME16 works but "
|
|
"BlockLimits VPD is missing.");
|
|
CU_FAIL("[FAILED] WRITESAME10 works but "
|
|
"BlockLimits VPD is missing.");
|
|
free(buf);
|
|
return;
|
|
}
|
|
|
|
i = 256;
|
|
if (inq_bl->max_ws_len == 0 || inq_bl->max_ws_len >= 256) {
|
|
logging(LOG_VERBOSE, "Block Limits VPD page reports MAX_WS_LEN "
|
|
"as either 0 (==no limit) or >= 256. Test Unmapping "
|
|
"256 blocks to verify that it can handle 2-byte "
|
|
"lengths");
|
|
|
|
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
|
memset(buf, 0xff, block_size * i);
|
|
ret = write10(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME10", i);
|
|
ret = writesame10(iscsic, tgt_lun, 0,
|
|
block_size, i,
|
|
0, 1, 0, 0, NULL);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
if (rc16->lbprz) {
|
|
logging(LOG_VERBOSE, "LBPRZ is set. Read the unmapped "
|
|
"blocks back and verify they are all zero");
|
|
|
|
logging(LOG_VERBOSE, "Read %d blocks and verify they "
|
|
"are now zero", i);
|
|
ret = read10(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
for (j = 0; j < block_size * i; j++) {
|
|
if (buf[j] != 0) {
|
|
CU_ASSERT_EQUAL(buf[j], 0);
|
|
}
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
|
"and verify zero test");
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "Block Limits VPD page reports MAX_WS_LEN "
|
|
"as <256. Verify that a 256 block unmap fails with "
|
|
"INVALID_FIELD_IN_CDB.");
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME10", i);
|
|
ret = writesame10_invalidfieldincdb(iscsic, tgt_lun, 0,
|
|
block_size, i,
|
|
0, 1, 0, 0, NULL);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
}
|
|
|
|
|
|
|
|
i = 65536;
|
|
if (inq_bl->max_ws_len == 0 || inq_bl->max_ws_len >= 256) {
|
|
logging(LOG_VERBOSE, "Block Limits VPD page reports MAX_WS_LEN "
|
|
"as either 0 (==no limit) or >= 256. Test Unmapping "
|
|
"256 blocks to verify that it can handle 2-byte "
|
|
"lengths");
|
|
|
|
logging(LOG_VERBOSE, "Write %d blocks of 0xFF", i);
|
|
memset(buf, 0xff, block_size * i);
|
|
ret = write10(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME10", i);
|
|
ret = writesame10(iscsic, tgt_lun, 0,
|
|
block_size, i,
|
|
0, 1, 0, 0, NULL);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
if (rc16->lbprz) {
|
|
logging(LOG_VERBOSE, "LBPRZ is set. Read the unmapped "
|
|
"blocks back and verify they are all zero");
|
|
|
|
logging(LOG_VERBOSE, "Read %d blocks and verify they "
|
|
"are now zero", i);
|
|
ret = read10(iscsic, tgt_lun, 0,
|
|
i * block_size, block_size,
|
|
0, 0, 0, 0, 0, buf);
|
|
for (j = 0; j < block_size * i; j++) {
|
|
if (buf[j] != 0) {
|
|
CU_ASSERT_EQUAL(buf[j], 0);
|
|
}
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "LBPRZ is clear. Skip the read "
|
|
"and verify zero test");
|
|
}
|
|
} else {
|
|
logging(LOG_VERBOSE, "Block Limits VPD page reports MAX_WS_LEN "
|
|
"as <256. Verify that a 256 block unmap fails with "
|
|
"INVALID_FIELD_IN_CDB.");
|
|
|
|
logging(LOG_VERBOSE, "Unmap %d blocks using WRITESAME10", i);
|
|
ret = writesame10_invalidfieldincdb(iscsic, tgt_lun, 0,
|
|
block_size, i,
|
|
0, 1, 0, 0, NULL);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
}
|
|
|
|
free(buf);
|
|
}
|