b908bdeb99
The current WRITE SAME (WS) 0 blocks test at LBA 0 isn't always correct
because if:
- The target's WSNZ bit set is 0
- The target's MAXIMUM WRITE SAME LENGTH (MWSL) is greater than 0
- We are issuing a WS with a NUMBER OF LOGICAL BLOCKS of 0
then whether the command should return success or failure depends on
whether the starting LBA is within MWSL blocks of the end of the LUN
(see http://www.t10.org/pipermail/t10/2016-May/017988.html for details).
Replace the vestigial code which tried to handle this (but no longer
worked since commit 8585e4509b ) and add
some additional MAXIMUM WRITE SAME LENGTH tests.
Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
103 lines
4.0 KiB
C
103 lines
4.0 KiB
C
/* -*- mode:c; tab-width:8; c-basic-offset:8; indent-tabs-mode:nil; -*- */
|
|
/*
|
|
Copyright (C) 2013 Ronnie Sahlberg <ronniesahlberg@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <CUnit/CUnit.h>
|
|
|
|
#include "iscsi.h"
|
|
#include "scsi-lowlevel.h"
|
|
#include "iscsi-test-cu.h"
|
|
|
|
|
|
void
|
|
test_writesame10_0blocks(void)
|
|
{
|
|
CHECK_FOR_DATALOSS;
|
|
CHECK_FOR_SBC;
|
|
|
|
if (num_blocks >= 0x80000000) {
|
|
CU_PASS("LUN is too big for write-beyond-eol tests with WRITESAME10. Skipping test.\n");
|
|
return;
|
|
}
|
|
if (!inq_bl) {
|
|
CU_PASS("BlockLimits VPD is not available. Skipping test.\n");
|
|
return;
|
|
}
|
|
|
|
logging(LOG_VERBOSE, LOG_BLANK_LINE);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITESAME10 0-blocks at LBA==0 (WSNZ=%d)",
|
|
inq_bl->wsnz);
|
|
memset(scratch, 0, block_size);
|
|
|
|
if (inq_bl->wsnz) {
|
|
WRITESAME10(sd, 0, block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_INVALID_FIELD_IN_CDB);
|
|
logging(LOG_NORMAL, "[SKIPPED] WRITESAME10 does not support 0-blocks.");
|
|
return;
|
|
}
|
|
|
|
if (inq_bl->max_ws_len > 0 && num_blocks >= inq_bl->max_ws_len) {
|
|
WRITESAME10(sd, 0, block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_INVALID_FIELD_IN_CDB);
|
|
} else {
|
|
WRITESAME10(sd, 0, block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_STATUS_GOOD);
|
|
}
|
|
|
|
if (inq_bl->max_ws_len > 0) {
|
|
logging(LOG_VERBOSE,
|
|
"Test WRITESAME10 at MAXIMUM WRITE SAME LENGTH + 1 blocks "
|
|
"from end-of-LUN");
|
|
CHECK_SIZE((inq_bl->max_ws_len + 1),
|
|
WRITESAME10(sd, num_blocks - (inq_bl->max_ws_len + 1),
|
|
block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_INVALID_FIELD_IN_CDB));
|
|
logging(LOG_VERBOSE,
|
|
"Test WRITESAME10 at MAXIMUM WRITE SAME LENGTH blocks "
|
|
"from end-of-LUN");
|
|
CHECK_SIZE(inq_bl->max_ws_len,
|
|
WRITESAME10(sd, num_blocks - inq_bl->max_ws_len,
|
|
block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_STATUS_GOOD));
|
|
logging(LOG_VERBOSE,
|
|
"Test WRITESAME10 at MAXIMUM WRITE SAME LENGTH - 1 blocks "
|
|
"from end-of-LUN");
|
|
CHECK_SIZE((inq_bl->max_ws_len - 1),
|
|
WRITESAME10(sd, num_blocks - (inq_bl->max_ws_len - 1),
|
|
block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_STATUS_GOOD));
|
|
} else {
|
|
logging(LOG_VERBOSE, "[SKIPPING] No MAXIMUM WRITE SAME LENGTH - "
|
|
"skipping MAXIMUM WRITE SAME LENGTH asserts.");
|
|
}
|
|
|
|
logging(LOG_VERBOSE, "Test WRITESAME10 0-blocks one block past end-of-LUN");
|
|
WRITESAME10(sd, num_blocks + 1, block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_LBA_OOB);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITESAME10 0-blocks at LBA==2^31");
|
|
WRITESAME10(sd, 0x80000000, block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_LBA_OOB);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITESAME10 0-blocks at LBA==-1");
|
|
WRITESAME10(sd, -1, block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_LBA_OOB);
|
|
}
|