b3783b961b
Avoid that Valgrind reports complaints similar to the following: Syscall param writev(vector[...]) points to uninitialised byte(s) at 0x5567087: writev (writev.c:49) by 0x5265AE0: iscsi_iovector_readv_writev (socket.c:492) by 0x52666B5: iscsi_write_to_socket (socket.c:710) by 0x5266CCC: iscsi_service (socket.c:852) by 0x526751F: event_loop (sync.c:67) by 0x5269B41: iscsi_scsi_command_sync (sync.c:1153) by 0x4050F6: send_scsi_command (iscsi-support.c:245) by 0x408007: compareandwrite (iscsi-support.c:1512) by 0x40B6AD: test_compareandwrite_dpofua (test_compareandwrite_dpofua.c:69) by 0x503EC99: ??? (in /usr/lib/libcunit.so.1.0.1) by 0x503EF27: ??? (in /usr/lib/libcunit.so.1.0.1) by 0x503F2A5: CU_run_all_tests (in /usr/lib/libcunit.so.1.0.1) Address 0xffeffff10 is on thread 1's stack in frame #8, created by test_compareandwrite_dpofua (test_compareandwrite_dpofua.c:30) Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
119 lines
3.6 KiB
C
119 lines
3.6 KiB
C
/*
|
|
Copyright (C) 2014 by Ronnie Sahlberg <sahlberg@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include <CUnit/CUnit.h>
|
|
|
|
#include "iscsi.h"
|
|
#include "scsi-lowlevel.h"
|
|
#include "iscsi-test-cu.h"
|
|
|
|
void
|
|
test_writeverify16_dpo(void)
|
|
{
|
|
int ret, dpofua, usage_data_dpo;
|
|
struct scsi_task *ms_task = NULL;
|
|
struct scsi_mode_sense *ms;
|
|
struct scsi_task *rso_task = NULL;
|
|
struct scsi_report_supported_op_codes_one_command *rsoc;
|
|
unsigned char *buf = alloca(block_size);
|
|
|
|
logging(LOG_VERBOSE, LOG_BLANK_LINE);
|
|
logging(LOG_VERBOSE, "Test WRITEVERIFY16 DPO flag");
|
|
|
|
CHECK_FOR_SBC;
|
|
|
|
ret = read10(sd, NULL, 0, block_size,
|
|
block_size, 0, 0, 0, 0, 0, buf,
|
|
EXPECT_STATUS_GOOD);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Read the DPOFUA flag from mode sense data");
|
|
ret = modesense6(sd, &ms_task, 0, SCSI_MODESENSE_PC_CURRENT,
|
|
SCSI_MODEPAGE_RETURN_ALL_PAGES, 0, 255,
|
|
EXPECT_STATUS_GOOD);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
logging(LOG_VERBOSE, "[SUCCESS] Mode sense returned status GOOD");
|
|
ms = scsi_datain_unmarshall(ms_task);
|
|
dpofua = ms && (ms->device_specific_parameter & 0x10);
|
|
scsi_free_scsi_task(ms_task);
|
|
|
|
if (dpofua) {
|
|
logging(LOG_VERBOSE, "DPOFUA flag is set. Device should allow "
|
|
"DPO/FUA flags in CDBs");
|
|
} else {
|
|
logging(LOG_VERBOSE, "DPOFUA flag is clear. Device should fail "
|
|
"CDBs with DPO/FUA set");
|
|
}
|
|
|
|
logging(LOG_VERBOSE, "Test WRITEVERIFY16 with DPO==1");
|
|
memset(buf, 0xa6, block_size);
|
|
if (dpofua) {
|
|
ret = writeverify16(sd, 0, block_size,
|
|
block_size, 0, 1, 0, 0, buf,
|
|
EXPECT_STATUS_GOOD);
|
|
if (ret == -2) {
|
|
logging(LOG_NORMAL, "[SKIPPED] WRITEVERIFY16 is not implemented.");
|
|
CU_PASS("WRITEVERIFY16 is not implemented.");
|
|
return;
|
|
}
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
} else {
|
|
ret = writeverify16(sd, 0, block_size,
|
|
block_size, 0, 1, 0, 0, buf,
|
|
EXPECT_INVALID_FIELD_IN_CDB);
|
|
if (ret == -2) {
|
|
logging(LOG_NORMAL, "[SKIPPED] WRITEVERIFY16 is not implemented.");
|
|
CU_PASS("WRITEVERIFY16 is not implemented.");
|
|
return;
|
|
}
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
}
|
|
|
|
|
|
logging(LOG_VERBOSE, "Try fetching REPORT_SUPPORTED_OPCODES "
|
|
"for WRITEVERIFY16");
|
|
ret = report_supported_opcodes(sd, &rso_task,
|
|
0, SCSI_REPORT_SUPPORTING_OPCODE,
|
|
SCSI_OPCODE_WRITE_VERIFY16,
|
|
0,
|
|
65535,
|
|
EXPECT_STATUS_GOOD);
|
|
if (ret == -2) {
|
|
logging(LOG_NORMAL, "REPORT_SUPPORTED_OPCODES not implemented. "
|
|
"Skipping this part of the test");
|
|
return;
|
|
}
|
|
logging(LOG_VERBOSE, "Unmarshall the DATA-IN buffer");
|
|
rsoc = scsi_datain_unmarshall(rso_task);
|
|
CU_ASSERT_NOT_EQUAL(rsoc, NULL);
|
|
usage_data_dpo = rsoc ? rsoc->cdb_usage_data[1] & 0x10 : -1;
|
|
if (dpofua) {
|
|
logging(LOG_VERBOSE, "DPOFUA is set. Verify the DPO flag "
|
|
"is set in the CDB_USAGE_DATA");
|
|
CU_ASSERT_EQUAL(usage_data_dpo, 0x10);
|
|
} else {
|
|
logging(LOG_VERBOSE, "DPOFUA is clear. Verify the DPO "
|
|
"flag is clear in the CDB_USAGE_DATA");
|
|
CU_ASSERT_EQUAL(usage_data_dpo, 0x00);
|
|
}
|
|
scsi_free_scsi_task(rso_task);
|
|
}
|