This patch avoids that Valgrind reports that an uninitialized buffer is passed to writev(): Syscall param writev(vector[...]) points to uninitialised byte(s) at 0x5557D07: writev (in /lib64/libc-2.19.so) by 0x5269BFD: iscsi_iovector_readv_writev (socket.c:509) by 0x526A7A9: iscsi_write_to_socket (socket.c:727) by 0x526AE47: iscsi_service (socket.c:888) by 0x526B632: event_loop (sync.c:67) by 0x526D925: iscsi_scsi_command_sync (sync.c:1223) by 0x405970: send_scsi_command (iscsi-support.c:276) by 0x40B190: extendedcopy (iscsi-support.c:2673) by 0x40E9FE: test_extendedcopy_param (test_extendedcopy_param.c:63) by 0x503E260: ??? (in /usr/lib64/libcunit.so.1.0.1) by 0x503E56E: ??? (in /usr/lib64/libcunit.so.1.0.1) by 0x503E8A5: CU_run_all_tests (in /usr/lib64/libcunit.so.1.0.1) Address 0xffefff864 is on thread 1's stack in frame #8, created by test_extendedcopy_param (test_extendedcopy_param.c:31) Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
127 lines
3.9 KiB
C
127 lines
3.9 KiB
C
/*
|
|
Copyright (c) 2015 SanDisk Corp.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <CUnit/CUnit.h>
|
|
|
|
#include "iscsi.h"
|
|
#include "scsi-lowlevel.h"
|
|
#include "iscsi-test-cu.h"
|
|
|
|
int init_xcopy_descr(unsigned char *buf, int offset, int num_tgt_desc,
|
|
int num_seg_desc, int *tgt_desc_len, int *seg_desc_len)
|
|
{
|
|
int i;
|
|
|
|
/* Initialize target descriptor list with num_tgt_desc
|
|
* target descriptor */
|
|
for (i = 0; i < num_tgt_desc; i++)
|
|
offset += populate_tgt_desc(buf+offset, IDENT_DESCR_TGT_DESCR,
|
|
LU_ID_TYPE_LUN, 0, 0, 0, 0, sd);
|
|
*tgt_desc_len = offset - XCOPY_DESC_OFFSET;
|
|
|
|
/* Iniitialize segment descriptor list with num_seg_desc
|
|
* segment descriptor */
|
|
for (i = 0; i < num_seg_desc; i++)
|
|
offset += populate_seg_desc_b2b(buf+offset, 0, 0, 0, 0,
|
|
2048, 0, num_blocks - 2048);
|
|
*seg_desc_len = offset - XCOPY_DESC_OFFSET - *tgt_desc_len;
|
|
|
|
return offset;
|
|
}
|
|
|
|
void
|
|
test_extendedcopy_descr_limits(void)
|
|
{
|
|
int ret;
|
|
struct iscsi_data data;
|
|
unsigned char *xcopybuf;
|
|
struct scsi_copy_results_op_params *opp;
|
|
int tgt_desc_len = 0, seg_desc_len = 0;
|
|
unsigned int alloc_len;
|
|
|
|
logging(LOG_VERBOSE, LOG_BLANK_LINE);
|
|
logging(LOG_VERBOSE, "Test EXTENDED COPY descriptor limits");
|
|
|
|
CHECK_FOR_DATALOSS;
|
|
|
|
logging(LOG_VERBOSE, "Issue RECEIVE COPY RESULTS (OPERATING PARAMS)");
|
|
ret = receive_copy_results(sd, SCSI_COPY_RESULTS_OP_PARAMS, 0,
|
|
(void **)&opp, EXPECT_STATUS_GOOD);
|
|
if (ret < 0) {
|
|
CU_PASS("[SKIPPED] Target does not support "
|
|
"RECEIVE_COPY_RESULTS. Skipping test");
|
|
return;
|
|
}
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
/* Allocate buffer to accommodate (MAX+1) target and
|
|
* segment descriptors */
|
|
alloc_len = XCOPY_DESC_OFFSET +
|
|
(opp->max_target_desc_count+1) *
|
|
get_desc_len(IDENT_DESCR_TGT_DESCR) +
|
|
(opp->max_segment_desc_count+1) *
|
|
get_desc_len(BLK_TO_BLK_SEG_DESCR);
|
|
data.data = alloca(alloc_len);
|
|
xcopybuf = data.data;
|
|
memset(xcopybuf, 0, alloc_len);
|
|
|
|
logging(LOG_VERBOSE,
|
|
"Test sending more than supported target descriptors");
|
|
data.size = init_xcopy_descr(xcopybuf, XCOPY_DESC_OFFSET,
|
|
(opp->max_target_desc_count+1), 1,
|
|
&tgt_desc_len, &seg_desc_len);
|
|
populate_param_header(xcopybuf, 1, 0, 0, 0,
|
|
tgt_desc_len, seg_desc_len, 0);
|
|
ret = extendedcopy(sd, &data, EXPECT_TOO_MANY_DESCR);
|
|
if (ret == -2) {
|
|
CU_PASS("[SKIPPED] Target does not support "
|
|
"EXTENDED_COPY. Skipping test");
|
|
return;
|
|
}
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE,
|
|
"Test sending more than supported segment descriptors");
|
|
memset(xcopybuf, 0, alloc_len);
|
|
data.size = init_xcopy_descr(xcopybuf, XCOPY_DESC_OFFSET, 1,
|
|
(opp->max_segment_desc_count+1),
|
|
&tgt_desc_len, &seg_desc_len);
|
|
populate_param_header(xcopybuf, 2, 0, 0, 0,
|
|
tgt_desc_len, seg_desc_len, 0);
|
|
ret = extendedcopy(sd, &data, EXPECT_TOO_MANY_DESCR);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE,
|
|
"Test sending descriptors > Maximum Descriptor List Length");
|
|
memset(xcopybuf, 0, alloc_len);
|
|
if (opp->max_desc_list_length < alloc_len) {
|
|
data.size = init_xcopy_descr(xcopybuf, XCOPY_DESC_OFFSET,
|
|
(opp->max_target_desc_count+1),
|
|
(opp->max_segment_desc_count+1),
|
|
&tgt_desc_len, &seg_desc_len);
|
|
populate_param_header(xcopybuf, 3, 0, 0, 0,
|
|
tgt_desc_len, seg_desc_len, 0);
|
|
ret = extendedcopy(sd, &data, EXPECT_PARAM_LIST_LEN_ERR);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
}
|
|
}
|