In preparation for removing the test-tool iscsi_queue_pdu() dlsym overload hack, convert this test to use the regular transport driver callback for this purpose. This commit also removes a number of unnecessary "WRITE10 is not implemented" checks, which should all be caught by the first check. Signed-off-by: David Disseldorp <ddiss@suse.de>
156 lines
5.6 KiB
C
156 lines
5.6 KiB
C
/*
|
|
Copyright (C) 2014 by Ronnie Sahlberg <ronniesahlberg@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <arpa/inet.h>
|
|
#include <CUnit/CUnit.h>
|
|
|
|
#include "iscsi.h"
|
|
#include "iscsi-private.h"
|
|
#include "scsi-lowlevel.h"
|
|
#include "iscsi-test-cu.h"
|
|
|
|
static int change_datasn;
|
|
static struct iscsi_transport iscsi_drv_orig;
|
|
|
|
static int my_iscsi_queue_pdu(struct iscsi_context *iscsi, struct iscsi_pdu *pdu)
|
|
{
|
|
uint32_t datasn;
|
|
|
|
if (pdu->outdata.data[0] != ISCSI_PDU_DATA_OUT) {
|
|
goto out;
|
|
}
|
|
switch (change_datasn) {
|
|
case 1:
|
|
/* change DataSN to 0 */
|
|
scsi_set_uint32(&pdu->outdata.data[36], 0);
|
|
break;
|
|
case 2:
|
|
/* change DataSN to 27 */
|
|
scsi_set_uint32(&pdu->outdata.data[36], 27);
|
|
break;
|
|
case 3:
|
|
/* change DataSN to -1 */
|
|
scsi_set_uint32(&pdu->outdata.data[36], -1);
|
|
break;
|
|
case 4:
|
|
/* change DataSN from (0,1) to (1,0) */
|
|
datasn = scsi_get_uint32(&pdu->outdata.data[36]);
|
|
scsi_set_uint32(&pdu->outdata.data[36], 1 - datasn);
|
|
break;
|
|
}
|
|
out:
|
|
return iscsi_drv_orig.queue_pdu(iscsi, pdu);
|
|
}
|
|
|
|
void test_iscsi_datasn_invalid(void)
|
|
{
|
|
int ret;
|
|
|
|
CHECK_FOR_DATALOSS;
|
|
|
|
logging(LOG_VERBOSE, LOG_BLANK_LINE);
|
|
logging(LOG_VERBOSE, "Test sending invalid iSCSI DataSN");
|
|
|
|
if (sd->iscsi_ctx == NULL) {
|
|
const char *err = "[SKIPPED] This test is "
|
|
"only supported for iSCSI backends";
|
|
logging(LOG_NORMAL, "%s", err);
|
|
CU_PASS(err);
|
|
return;
|
|
}
|
|
|
|
logging(LOG_VERBOSE, "Send two Data-Out PDU's with DataSN==0. Should fail.");
|
|
change_datasn = 1;
|
|
|
|
sd->iscsi_ctx->use_immediate_data = ISCSI_IMMEDIATE_DATA_NO;
|
|
sd->iscsi_ctx->target_max_recv_data_segment_length = block_size;
|
|
/* override transport queue_pdu callback for PDU manipulation */
|
|
iscsi_drv_orig = *sd->iscsi_ctx->drv;
|
|
sd->iscsi_ctx->drv->queue_pdu = my_iscsi_queue_pdu;
|
|
iscsi_set_noautoreconnect(sd->iscsi_ctx, 1);
|
|
iscsi_set_timeout(sd->iscsi_ctx, 3);
|
|
|
|
memset(scratch, 0xa6, 2 * block_size);
|
|
|
|
ret = write10(sd, 100, 2 * block_size,
|
|
block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_STATUS_GOOD);
|
|
if (ret == -2) {
|
|
logging(LOG_NORMAL, "[SKIPPED] WRITE10 is not implemented.");
|
|
CU_PASS("WRITE10 is not implemented.");
|
|
goto out_ctx_restore;
|
|
}
|
|
CU_ASSERT_NOT_EQUAL(ret, 0);
|
|
|
|
/* avoid changing DataSN during reconnect */
|
|
*(sd->iscsi_ctx->drv) = iscsi_drv_orig;
|
|
iscsi_set_noautoreconnect(sd->iscsi_ctx, 0);
|
|
|
|
logging(LOG_VERBOSE, "Send Data-Out PDU with DataSN==27. Should fail");
|
|
change_datasn = 2;
|
|
|
|
sd->iscsi_ctx->use_immediate_data = ISCSI_IMMEDIATE_DATA_NO;
|
|
sd->iscsi_ctx->target_max_recv_data_segment_length = block_size;
|
|
sd->iscsi_ctx->drv->queue_pdu = my_iscsi_queue_pdu;
|
|
iscsi_set_noautoreconnect(sd->iscsi_ctx, 1);
|
|
iscsi_set_timeout(sd->iscsi_ctx, 3);
|
|
|
|
ret = write10(sd, 100, block_size,
|
|
block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_STATUS_GOOD);
|
|
CU_ASSERT_NOT_EQUAL(ret, 0);
|
|
|
|
*(sd->iscsi_ctx->drv) = iscsi_drv_orig;
|
|
iscsi_set_noautoreconnect(sd->iscsi_ctx, 0);
|
|
|
|
logging(LOG_VERBOSE, "Send Data-Out PDU with DataSN==-1. Should fail");
|
|
change_datasn = 3;
|
|
|
|
sd->iscsi_ctx->use_immediate_data = ISCSI_IMMEDIATE_DATA_NO;
|
|
sd->iscsi_ctx->target_max_recv_data_segment_length = block_size;
|
|
sd->iscsi_ctx->drv->queue_pdu = my_iscsi_queue_pdu;
|
|
iscsi_set_noautoreconnect(sd->iscsi_ctx, 1);
|
|
iscsi_set_timeout(sd->iscsi_ctx, 3);
|
|
|
|
ret = write10(sd, 100, block_size,
|
|
block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_STATUS_GOOD);
|
|
CU_ASSERT_NOT_EQUAL(ret, 0);
|
|
|
|
*(sd->iscsi_ctx->drv) = iscsi_drv_orig;
|
|
iscsi_set_noautoreconnect(sd->iscsi_ctx, 0);
|
|
|
|
logging(LOG_VERBOSE, "Send Data-Out PDU's in reverse order (DataSN == 1,0). Should fail");
|
|
change_datasn = 4;
|
|
|
|
sd->iscsi_ctx->use_immediate_data = ISCSI_IMMEDIATE_DATA_NO;
|
|
sd->iscsi_ctx->target_max_recv_data_segment_length = block_size;
|
|
sd->iscsi_ctx->drv->queue_pdu = my_iscsi_queue_pdu;
|
|
iscsi_set_noautoreconnect(sd->iscsi_ctx, 1);
|
|
iscsi_set_timeout(sd->iscsi_ctx, 3);
|
|
|
|
ret = write10(sd, 100, 2 * block_size,
|
|
block_size, 0, 0, 0, 0, 0, scratch,
|
|
EXPECT_STATUS_GOOD);
|
|
CU_ASSERT_NOT_EQUAL(ret, 0);
|
|
out_ctx_restore:
|
|
/* restore transport callbacks and autoreconnect */
|
|
*(sd->iscsi_ctx->drv) = iscsi_drv_orig;
|
|
iscsi_set_noautoreconnect(sd->iscsi_ctx, 0);
|
|
}
|